All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Gokce Kuler <gokcekuler@gmail.com>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org
Subject: Re: [Outreachy kernel] [PATCH v5] staging: qlge: Adjust end of block comment
Date: Mon, 30 Mar 2020 11:57:18 +0200	[thread overview]
Message-ID: <20200330115718.502d2c65@elisabeth> (raw)
In-Reply-To: <20200327174401.GA7763@siyah2>

Hi Gökçe,

On Fri, 27 Mar 2020 20:44:01 +0300
Gokce Kuler <gokcekuler@gmail.com> wrote:

> Drop an unnecessary * on the last line of a block comment to follow the Linux kernel coding conventions.

Thanks for sticking with this, I understand this might be frustrating
but it's important that you get familiar with it.

So... Greg suggested that you should fix the strange line wrapping in
the commit message -- not that you avoid it altogether. Messages should
still be wrapped (to 70, 72, or 76 columns, you choose) characters.

A message like the one above, 104 columns, won't really be practical
for usage with git.

-- 
Stefano



      reply	other threads:[~2020-03-30  9:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27 17:44 [PATCH v5] staging: qlge: Adjust end of block comment Gokce Kuler
2020-03-30  9:57 ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200330115718.502d2c65@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=gokcekuler@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.