From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, f.fainelli@gmail.com,
hkallweit1@gmail.com, davem@davemloft.net
Subject: Re: [PATCH] net: mdio: of: Do not treat fixed-link as PHY
Date: Mon, 30 Mar 2020 17:21:30 +0100 [thread overview]
Message-ID: <20200330162130.GF25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200330161740.GC23477@lunn.ch>
On Mon, Mar 30, 2020 at 06:17:40PM +0200, Andrew Lunn wrote:
> On Mon, Mar 30, 2020 at 07:01:36PM +0300, Codrin Ciubotariu wrote:
> > Some ethernet controllers, such as cadence's macb, have an embedded MDIO.
> > For this reason, the ethernet PHY nodes are not under an MDIO bus, but
> > directly under the ethernet node.
>
> Hi Codrin
>
> That is deprecated. It causes all sorts of problems putting PHY nodes
> in the MAC without a container.
>
> Please fix macb to look for an mdio node, and place your fixed link
> inside it.
Seems wrong.
fixed links have never needed to be under a mdio node - see
Documentation/devicetree/bindings/net/ethernet-controller.yaml
fixed-link is a child of the MAC controller, not of a mdio node.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
next prev parent reply other threads:[~2020-03-30 16:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 16:01 [PATCH] net: mdio: of: Do not treat fixed-link as PHY Codrin Ciubotariu
2020-03-30 16:17 ` Andrew Lunn
2020-03-30 16:21 ` Russell King - ARM Linux admin [this message]
2020-03-30 16:24 ` Andrew Lunn
2020-03-30 16:30 ` Andrew Lunn
2020-03-30 17:22 ` Florian Fainelli
2020-03-31 8:54 ` Codrin.Ciubotariu
2020-03-31 12:59 ` Andrew Lunn
2020-04-01 7:50 ` Codrin.Ciubotariu
2020-04-01 13:06 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330162130.GF25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=codrin.ciubotariu@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.