From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guru Das Srinagesh Subject: Re: [PATCH v11 08/12] pwm: stm32-lp: Use %llu format specifier for period Date: Mon, 30 Mar 2020 12:30:08 -0700 Message-ID: <20200330193008.GA5107@codeaurora.org> References: <5ea1fa27dd036ce732c1c7a1a5d84362752a911f.1584667964.git.gurus@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]:56673 "EHLO alexa-out-sd-01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727437AbgC3TaJ (ORCPT ); Mon, 30 Mar 2020 15:30:09 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Joe Perches Cc: linux-pwm@vger.kernel.org, Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Subbaraman Narayanamurthy , linux-kernel@vger.kernel.org, Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue On Fri, Mar 20, 2020 at 03:45:35AM -0700, Joe Perches wrote: > On Thu, 2020-03-19 at 18:41 -0700, Guru Das Srinagesh wrote: > > Since the PWM framework is switching struct pwm_args.period's > > datatype to u64, prepare for this transition by using the right > > specifier for printing a 64-bit value. > [] > > diff --git a/drivers/pwm/pwm-stm32-lp.c b/drivers/pwm/pwm-stm32-lp.c > [] > > @@ -61,7 +61,7 @@ static int stm32_pwm_lp_apply(struct pwm_chip *chip, struct pwm_device *pwm, > > do_div(div, NSEC_PER_SEC); > > if (!div) { > > /* Clock is too slow to achieve requested period. */ > > - dev_dbg(priv->chip.dev, "Can't reach %u ns\n", state->period); > > + dev_dbg(priv->chip.dev, "Can't reach %llu ns\n", state->period); > > return -EINVAL; > > } > > Doesn't this introduce a warning now without the > actual change to the type of state->period? You're right, it does. > Likely these patches should either not be separated > or this should also use a cast to avoid introducing > intermediate compilation warnings. Only this patch has this specific issue, so I'll squish it with the final patch in this series ("pwm: core: Convert period and duty cycle to u64") that modifies the framework structs. Thanks for pointing this out. Thank you. Guru Das.