From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/4] Revert "configs/nanopi_neo4: remove defconfig"
Date: Mon, 30 Mar 2020 21:17:45 +0200 [thread overview]
Message-ID: <20200330211745.7f4bb901@windsurf.home> (raw)
In-Reply-To: <1585588981-12498-2-git-send-email-marek.belisko@open-nandra.com>
On Mon, 30 Mar 2020 19:22:58 +0200
Marek Belisko <marek.belisko@open-nandra.com> wrote:
> This reverts commit 8af7b11bd8a95bc41e4de46f727f3b0afde465a4.
>
> neo4 config was removed due to the fact that 32 bit toolchain was missing
> for building AFT and was not added until some time.
>
> Recently in commit d9959b647f2afd09e564bddfc3d21476f9a0f669 package
> was added to return back neo4 config and use this new option.
Your Signed-off-by is missing. However, I think a revert is the bad
approach, indeed this commit by itself is still broken, it needs the
second patch in your series to work correctly.
So could you instead simply resubmit a new neo4 defconfig ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-03-30 19:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 17:22 [Buildroot] [PATCH v2 0/4] Add nanopi_neo4 board support Marek Belisko
2020-03-30 17:22 ` [Buildroot] [PATCH v2 1/4] Revert "configs/nanopi_neo4: remove defconfig" Marek Belisko
2020-03-30 19:17 ` Thomas Petazzoni [this message]
2020-03-30 19:34 ` Belisko Marek
2020-03-30 19:35 ` Thomas Petazzoni
2020-03-30 17:22 ` [Buildroot] [PATCH v2 2/4] nanpi_neo4_config: Enable BR2_TARGET_ARM_TRUSTED_FIRMWARE_NEEDS_ARM32_TOOLCHAIN option Marek Belisko
2020-03-30 17:23 ` [Buildroot] [PATCH v2 3/4] nanopi_neo4_defconfig: Bump kernel to 5.4 Marek Belisko
2020-03-30 17:23 ` [Buildroot] [PATCH v2 4/4] nanopi_neo4_defconfig: Bump rootfs size to 70M Marek Belisko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330211745.7f4bb901@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.