From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 409D0C43331 for ; Mon, 30 Mar 2020 22:29:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1796E20733 for ; Mon, 30 Mar 2020 22:29:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729223AbgC3W3b (ORCPT ); Mon, 30 Mar 2020 18:29:31 -0400 Received: from gofer.mess.org ([88.97.38.141]:59273 "EHLO gofer.mess.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728987AbgC3W3b (ORCPT ); Mon, 30 Mar 2020 18:29:31 -0400 Received: by gofer.mess.org (Postfix, from userid 1000) id 962AFC635C; Mon, 30 Mar 2020 23:29:29 +0100 (BST) Date: Mon, 30 Mar 2020 23:29:29 +0100 From: Sean Young To: Rosen Penev Cc: linux-media@vger.kernel.org Subject: Re: [PATCH] keytable: use input_event properly Message-ID: <20200330222929.GA7631@gofer.mess.org> References: <20200330212434.10155-1-rosenp@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200330212434.10155-1-rosenp@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Mar 30, 2020 at 02:24:34PM -0700, Rosen Penev wrote: > It does not use time_t under musl when time_t is 64-bit. The struct has > compatibility defines. Instead of using time_t directly, use those > defines. > > Fixes compilation under musl 1.2.0 under 32-bit OSes. Looks good, merged. Thanks, Sean > > Signed-off-by: Rosen Penev > --- > utils/keytable/keytable.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/utils/keytable/keytable.c b/utils/keytable/keytable.c > index aad993ea..bc890394 100644 > --- a/utils/keytable/keytable.c > +++ b/utils/keytable/keytable.c > @@ -1551,7 +1551,7 @@ static void test_event(struct rc_device *rc_dev, int fd) > > for (i = 0; i < rd / sizeof(struct input_event); i++) { > printf(_("%ld.%06ld: event type %s(0x%02x)"), > - ev[i].time.tv_sec, ev[i].time.tv_usec, > + ev[i].input_event_sec, ev[i].input_event_usec, > get_event_name(events_type, ev[i].type), ev[i].type); > > switch (ev[i].type) { > -- > 2.25.1