From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02FBBC43331 for ; Tue, 31 Mar 2020 10:29:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8E3E206DB for ; Tue, 31 Mar 2020 10:29:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="PcYpXo0Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730224AbgCaK3d (ORCPT ); Tue, 31 Mar 2020 06:29:33 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:60692 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729925AbgCaK3d (ORCPT ); Tue, 31 Mar 2020 06:29:33 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02VAP1wB016863; Tue, 31 Mar 2020 10:29:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=RE7RJ50ctwXcGb9Gg0IBmuEBmVKbP8bDDY8G4iwoz2M=; b=PcYpXo0YU0rSIuaCXPV8nY5W+qmkFEosxk7fLBlzRNQY4OlA6Mx2XK8h7CntMIHtZiYP 5JatUD3ErHtKeVAhK652hYHVh0G71Djq7pn4YNPGbWQCDc6RoFjEEKRGNGgK/05n4RNG 4RceUI6svHbXPt0pyHTXPlH/Pw5STfVh+dJe6hL8BIE2ZcuL3oHepnnA4f/P9S4pCHuH zKJ4E+5oxaTFnJ/ftfyN68Z4ATPGdjqOQ3UFIo9256az8wtU3EeswHJBjEg2/GZkifmi 7vOda4rtJSyILUXNKfMGeU5bXlZkpBVfOLPTXs+5XMAn7kujRSVVWlsciJb7bPf71Pw2 Tw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 303aqhf8ug-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 Mar 2020 10:29:20 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02VAMsmT010013; Tue, 31 Mar 2020 10:29:19 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 302g2dtk6c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 Mar 2020 10:29:19 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02VATFDd011762; Tue, 31 Mar 2020 10:29:15 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 31 Mar 2020 03:29:14 -0700 Date: Tue, 31 Mar 2020 13:29:06 +0300 From: Dan Carpenter To: Oscar Carter Cc: Forest Bond , Greg Kroah-Hartman , Malcolm Priestley , Quentin Deslandes , Amir Mahdi Ghorbanian , Colin Ian King , Gabriela Bittencourt , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vt6656: Use defines in vnt_mac_reg_bits_* functions Message-ID: <20200331102906.GA2066@kadam> References: <20200328095433.7879-1-oscar.carter@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200328095433.7879-1-oscar.carter@gmx.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9576 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 mlxscore=0 adultscore=0 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003310094 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9576 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 clxscore=1011 malwarescore=0 impostorscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003310094 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 28, 2020 at 10:54:33AM +0100, Oscar Carter wrote: > Define the necessary bits in the CHANNEL, PAPEDELAY and GPIOCTL0 > registers to can use them in the calls to vnt_mac_reg_bits_on and > vnt_mac_reg_bits_off functions. In this way, avoid the use of BIT() > macros and clarify the code. > > Fixes: 3017e587e368 ("staging: vt6656: Use BIT() macro in vnt_mac_reg_bits_* functions") > Suggested-by: Dan Carpenter > Signed-off-by: Oscar Carter > --- > drivers/staging/vt6656/baseband.c | 6 ++++-- > drivers/staging/vt6656/card.c | 3 +-- > drivers/staging/vt6656/mac.h | 12 ++++++++++++ > drivers/staging/vt6656/main_usb.c | 2 +- > 4 files changed, 18 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c > index a19a563d8bcc..dd3c3bf5e8b5 100644 > --- a/drivers/staging/vt6656/baseband.c > +++ b/drivers/staging/vt6656/baseband.c > @@ -442,7 +442,8 @@ int vnt_vt3184_init(struct vnt_private *priv) > if (ret) > goto end; > > - ret = vnt_mac_reg_bits_on(priv, MAC_REG_PAPEDELAY, BIT(0)); > + ret = vnt_mac_reg_bits_on(priv, MAC_REG_PAPEDELAY, > + PAPEDELAY_B0); This doesn't clarify anything. It makes it less clear because someone would assume B0 means something but it's just hiding a magic number behind a meaningless define. B0 means BIT(0) which means nothing. So now we have to jump through two hoops to find out that we don't know anything. Just leave it as-is. Same for the rest. There problem is a hardware spec which explains what this stuff is. regards, dan carpenter