Re: [PATCH 1/3] kernel/sysctl: support setting sysctl parameters from kernel command line

[Kees Cook <keescook@chromium.org>]

[-- Attachment #1: Type: text/plain, Size: 1828 bytes --]

On Tue, Mar 31, 2020 at 04:15:44AM +0800, kbuild test robot wrote:
> Hi Vlastimil,
> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on kees/for-next/pstore]
> [also build test WARNING on linus/master linux/master v5.6 next-20200330]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> 
> url:    https://github.com/0day-ci/linux/commits/Vlastimil-Babka/support-setting-sysctl-parameters-from-kernel-command-line/20200331-023453
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/pstore
> config: um-i386_defconfig (attached as .config)
> compiler: gcc-7 (Debian 7.4.0-6) 7.4.0
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=um SUBARCH=i386
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from include/linux/printk.h:7:0,
>                     from include/linux/kernel.h:15,
>                     from include/linux/list.h:9,
>                     from include/linux/sysctl.h:25,
>                     from fs/proc/proc_sysctl.c:6:
>    fs/proc/proc_sysctl.c: In function 'process_sysctl_arg':
>    include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'ssize_t {aka int}' [-Wformat=]

Ah yes, this should be %zd I think?

> > 1798			pr_err("Wrote only %ld bytes of %d writing to proc file %s to set sysctl parameter '%s=%s'",
>   1799				wret, len, path, param, val);


-Kees

-- 
Kees Cook