From: Mark Brown <broonie@kernel.org>
To: �̰��� <gt82.lee@samsung.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, tiwai@suse.com,
hmseo@samsung.com, tkjung@samsung.com, pilsun.jang@samsung.com
Subject: Re: [PATCH 3/3] ASoC: fix regwmask
Date: Tue, 31 Mar 2020 12:38:57 +0100 [thread overview]
Message-ID: <20200331113857.GC4802@sirena.org.uk> (raw)
In-Reply-To: <012801d60728$bdab3a50$3901aef0$@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
On Tue, Mar 31, 2020 at 03:51:01PM +0900, �̰��� wrote:
> If regwshift is 32 and the selected architecture compiles '<<' operator for signed int literal into rotating shift, '1<<regwshift'
> became 1 and it makes regwmask to 0x0.
> The literal is set to unsigned long to get intended regwmask.
Please do not submit new versions of already applied patches, please
submit incremental updates to the existing code. Modifying existing
commits creates problems for other users building on top of those
commits so it's best practice to only change pubished git commits if
absolutely essential.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-03-31 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200330073600epcas2p3712a5e92d86a524bedda790f2e273935@epcas2p3.samsung.com>
2020-03-30 7:35 ` [PATCH 3/3] ASoC: fix regwmask 이경택
2020-03-30 17:22 ` Applied "ASoC: fix regwmask" to the asoc tree Mark Brown
2020-03-31 5:27 ` [PATCH 3/3] ASoC: fix regwmask 이경택
2020-03-31 5:42 ` 이경택
2020-03-31 6:51 ` 이경택
2020-03-31 11:38 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331113857.GC4802@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=gt82.lee@samsung.com \
--cc=hmseo@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=pilsun.jang@samsung.com \
--cc=tiwai@suse.com \
--cc=tkjung@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.