From: Kevin Wolf <kwolf@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: ehabkost@redhat.com, qemu-block@nongnu.org, armbru@redhat.com,
philmd@redhat.com, qemu-devel@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v9 00/14] iotests: use python logging
Date: Tue, 31 Mar 2020 14:15:12 +0200 [thread overview]
Message-ID: <20200331121512.GC7030@linux.fritz.box> (raw)
In-Reply-To: <9e1cf69f-5aa1-eee2-d550-85dd85b7049f@redhat.com>
Am 30.03.2020 um 21:03 hat John Snow geschrieben:
>
>
> On 3/24/20 7:20 PM, John Snow wrote:
> > This series uses python logging to enable output conditionally on
> > iotests.log(). We unify an initialization call (which also enables
> > debugging output for those tests with -d) and then make the switch
> > inside of iotests.
> >
> > It will help alleviate the need to create logged/unlogged versions
> > of all the various helpers we have made.
> >
> > Also, I got lost and accidentally delinted iotests while I was here.
> > Sorry about that. By version 9, it's now the overwhelming focus of
> > this series. No good deed, etc.
>
>
> Version requirements, as discovered by Kevin's Python Museum:
>
> mypy >= 0.620
> pylint >= 2.2.0
> astroid == 2.1.0 (or >= 2.2.0 if using pylint >= 2.3.0)
>
>
> Hm, though ... pylint does not like 'Collection' very much:
>
> iotests.py:1139:41: E1136: Value 'Collection' is unsubscriptable
> (unsubscriptable-object)
>
> It works OK for the same pylint versions under 3.7, but it's busted a
> bit under 3.6. See https://github.com/PyCQA/pylint/issues/2377
>
> Well. Collection is indeed the actual type we want (we need Iterable and
> Container properties; i.e. supports 'for' and 'in'). There's no reason
> to require a Sequence (adds Reversible and some notion of a fixed
> ordering) -- but it will fix the typing problems in 3.6, so I'm going to
> do that.
I wouldn't actually worry about Python museums much as far as pylint and
mypy are concerned. 3.6 compatibility is important for actually running
the code, but if older mypy/pylint versions get false positives, I would
consider that acceptable.
Kevin
prev parent reply other threads:[~2020-03-31 12:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 23:20 [PATCH v9 00/14] iotests: use python logging John Snow
2020-03-24 23:20 ` [PATCH v9 01/14] iotests: do a light delinting John Snow
2020-03-30 14:39 ` Markus Armbruster
2020-03-30 17:28 ` John Snow
2020-03-30 15:41 ` Kevin Wolf
2020-03-30 17:25 ` John Snow
2020-03-24 23:20 ` [PATCH v9 02/14] iotests: don't use 'format' for drive_add John Snow
2020-03-24 23:20 ` [PATCH v9 03/14] iotests: ignore import warnings from pylint John Snow
2020-03-24 23:20 ` [PATCH v9 04/14] iotests: replace mutable list default args John Snow
2020-03-24 23:20 ` [PATCH v9 05/14] iotests: add pylintrc file John Snow
2020-03-30 14:45 ` Markus Armbruster
2020-03-30 17:35 ` John Snow
2020-03-30 15:49 ` Kevin Wolf
2020-03-30 18:10 ` John Snow
2020-03-24 23:20 ` [PATCH v9 06/14] iotests: alphabetize standard imports John Snow
2020-03-30 12:10 ` Max Reitz
2020-03-24 23:20 ` [PATCH v9 07/14] iotests: drop pre-Python 3.4 compatibility code John Snow
2020-03-30 12:12 ` Max Reitz
2020-03-24 23:20 ` [PATCH v9 08/14] iotests: touch up log function signature John Snow
2020-03-30 12:28 ` Max Reitz
2020-03-30 17:43 ` John Snow
2020-03-30 16:19 ` Kevin Wolf
2020-03-30 18:31 ` John Snow
2020-03-24 23:20 ` [PATCH v9 09/14] iotests: limit line length to 79 chars John Snow
2020-03-30 12:31 ` Max Reitz
2020-03-30 12:34 ` Max Reitz
2020-03-30 19:19 ` John Snow
2020-03-24 23:20 ` [PATCH v9 10/14] iotests: add hmp helper with logging John Snow
2020-03-30 12:44 ` Max Reitz
2020-03-30 16:27 ` Kevin Wolf
2020-03-24 23:21 ` [PATCH v9 11/14] iotests: add script_initialize John Snow
2020-03-24 23:21 ` [PATCH v9 12/14] iotest 258: use script_main John Snow
2020-03-24 23:21 ` [PATCH v9 13/14] iotests: Mark verify functions as private John Snow
2020-03-30 16:32 ` Kevin Wolf
2020-03-24 23:21 ` [PATCH v9 14/14] iotests: use python logging for iotests.log() John Snow
2020-03-30 13:00 ` [PATCH v9 00/14] iotests: use python logging Max Reitz
2020-03-30 19:41 ` John Snow
2020-03-30 19:03 ` John Snow
2020-03-31 12:15 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331121512.GC7030@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.