From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0771DC43331 for ; Tue, 31 Mar 2020 16:11:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C60C3206CC for ; Tue, 31 Mar 2020 16:11:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ecq2Uxo4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C60C3206CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJJU7-0004ss-Un for qemu-devel@archiver.kernel.org; Tue, 31 Mar 2020 12:11:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40902) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJJTR-0004Kb-Mh for qemu-devel@nongnu.org; Tue, 31 Mar 2020 12:10:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJJTQ-0002kw-9d for qemu-devel@nongnu.org; Tue, 31 Mar 2020 12:10:45 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:56643 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJJTQ-0002kf-68 for qemu-devel@nongnu.org; Tue, 31 Mar 2020 12:10:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585671042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xJMEObt099ILBREpWHE12Wp6qrNdzm1MauyLML7QBB4=; b=ecq2Uxo41eg/QzCO7nFZIyO/H66AKAoRQdqGcrFyJY4XTaau8s8CSuyPWjZopHfQW6ycw7 cyCZ37HAyROurF31JvdE7DxrMlrMndOIujfF+BAYeEv1V3L4hrVRpoqrK5rvVUVvGuiDH8 Gt39/22PmYSYiynhQSsfnSkVb67MpWw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-191-26YvaLqBOQm5BSwvdMt_KQ-1; Tue, 31 Mar 2020 12:10:40 -0400 X-MC-Unique: 26YvaLqBOQm5BSwvdMt_KQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A2F238010EB; Tue, 31 Mar 2020 16:10:37 +0000 (UTC) Received: from gondolin (ovpn-112-229.ams2.redhat.com [10.36.112.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7CA1819C58; Tue, 31 Mar 2020 16:10:36 +0000 (UTC) Date: Tue, 31 Mar 2020 18:10:33 +0200 From: Cornelia Huck To: Markus Armbruster Subject: Re: [PATCH] qemu-options.hx: 9p: clarify -virtfs vs. -fsdev Message-ID: <20200331181033.01d16aa2.cohuck@redhat.com> In-Reply-To: <87369otsqz.fsf@dusky.pond.sub.org> References: <208f1fceffce2feaf7c900b29e326b967dce7762.1585661532.git.qemu_oss@crudebyte.com> <20200331172727.6e844deb.cohuck@redhat.com> <6318846.9qTBnWfJNl@silver> <87369otsqz.fsf@dusky.pond.sub.org> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Schoenebeck , qemu-devel@nongnu.org, Greg Kurz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 31 Mar 2020 18:05:08 +0200 Markus Armbruster wrote: > Christian Schoenebeck writes: >=20 > > On Dienstag, 31. M=C3=A4rz 2020 17:27:27 CEST Cornelia Huck wrote: =20 > >> > diff --git a/qemu-options.hx b/qemu-options.hx > >> > index 962a5ebaa6..fd3830c6cd 100644 > >> > --- a/qemu-options.hx > >> > +++ b/qemu-options.hx > >> > @@ -1542,9 +1542,17 @@ SRST > >> >=20 > >> > ``-virtfs proxy,sock_fd=3Dsock_fd,mount_tag=3Dmount_tag =20 > >> > [,writeout=3Dwriteout][,readonly]``> =20 > >> > \ > >> > =20 > >> > ``-virtfs synth,mount_tag=3Dmount_tag`` > >> >=20 > >> > - Define a new filesystem device and expose it to the guest using= a > >> > - virtio-9p-device. The general form of a Virtual File system > >> > - pass-through options are: > >> > + Define a new virtual filesystem device and expose it to the gue= st > >> > using + a virtio-9p-device (a.k.a. 9pfs), which essentially means= that > >> > a certain + directory on host is made directly accessible by gues= t as > >> > a pass-through + file system by using the 9P network protocol for > >> > communication between + host and guests, if desired even accessib= le, > >> > shared by several guests + simultaniously. > >> > + > >> > + Note that ``-virtfs`` is actually just a convenience shortcut f= or its > >> > + generalized form ``-fsdev -device virtio-9p-pci``. =20 > >>=20 > >> Huh. This prompted me to try this on s390, and it actually creates a > >> virtio-9p-pci device there as well, not a virtio-9p-ccw device. A bit > >> surprising; but I don't see 9p used much (if at all) on s390 anyway. = =20 > > > > Yeah, "virtio-9p-pci" is currently hard coded in softmmu/vl.c [line 335= 2]: > > https://github.com/qemu/qemu/blob/17083d6d1e0635371418c26b613a6fa68d392= f49/softmmu/vl.c#L3352 =20 >=20 > Should it be "virtio-9p" instead? It's an alias for "virtio-9p-pci", > except for s390x, where it's an alias for "virtio-9p-ccw". Seems like a reasonable change (although I'm not sure it matters too much).