From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guru Das Srinagesh Subject: Re: [PATCH v10 00/12] Convert PWM period and duty cycle to u64 Date: Tue, 31 Mar 2020 12:59:40 -0700 Message-ID: <20200331195939.GA25781@codeaurora.org> References: <20200321114703.GB4672@kadam> <20200330191506.GA29534@codeaurora.org> <20200330202636.njjo4savgzf3g6yx@holly.lan> <20200330210012.GA27611@codeaurora.org> <20200331134804.xxrjaestztcazalc@holly.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200331134804.xxrjaestztcazalc@holly.lan> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+glpr-linux-riscv=m.gmane-mx.org@lists.infradead.org To: Daniel Thompson Cc: Kate Stewart , Daniel Vetter , linux-fbdev@vger.kernel.org, David Airlie , "Wesley W. Terpstra" , Michael Turquette , Joonas Lahtinen , Kamil Debski , dri-devel@lists.freedesktop.org, Liam Girdwood , Atish Patra , Thierry Reding , Benjamin Gaignard , linux-riscv@lists.infradead.org, Lee Jones , linux-clk@vger.kernel.org, Ville =?utf-8?B?U3lyasOkbMOk?= , Alexandre Torgue , Mauro Carvalho Chehab , Axel Lin , Arnd Bergmann , Alexander Shiyan , Fabio Estevam List-Id: linux-pwm@vger.kernel.org On Tue, Mar 31, 2020 at 02:48:04PM +0100, Daniel Thompson wrote: > On Mon, Mar 30, 2020 at 02:00:12PM -0700, Guru Das Srinagesh wrote: > > On Mon, Mar 30, 2020 at 09:26:36PM +0100, Daniel Thompson wrote: > > > On Mon, Mar 30, 2020 at 12:15:07PM -0700, Guru Das Srinagesh wrote: > > > > On Sat, Mar 21, 2020 at 02:47:03PM +0300, Dan Carpenter wrote: > > > > > This is a giant CC list. > > > > > > > > Yes, this is because I received feedback [1] on an earlier patchset > > > > directing me to add the reviewers of patches to the cover letter as > > > > well so that they get some context for the patch. > > > > ... > > > > [1] https://www.spinics.net/lists/linux-pwm/msg11735.html > > > > > > Strictly speaking I only asked for backlight maintainers to be Cc:ed. > > > I was fairly careful to be specific since I'm aware there are a variety > > > of differing habits when putting together the Cc: list for covering > > > letters. > > > > > > With the original patch header the purpose of the patch I was Cc:ed on > > > was impossible to determine without the covering letter. > > > > I suspect this might be the case for all the other reviewers as well - > > that they also would appreciate context for the specific patch they are > > being added to review. > > > > I wasn't entirely sure what the convention was, so I applied your > > suggestion to all the files. How do you suggest I handle this in my next > > patchset? I fully agree that such a large CC list does look really > > ungainly. > > IHMO there should not be a mechanical convention. Instead your goal > needs to be how to make it as easy as possible to review your patches. > > Think about it this way: Each person in the To: of a patch (and maybe > also Cc: depending on how you construct things) is a person you are > asking to review and comment on the patch. If that person will find it > easier to review the patch if they are included in the cover letter then > either they should be included or you should improve the patch > description of the patch itself (sometimes both). > > Either way it is about optimizing the patchset for readability. More > people read them than write them. Thank you for the explanation! I shall keep your suggestions in mind while sending out future patchsets. Thank you. Guru Das. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DA27C43331 for ; Tue, 31 Mar 2020 19:59:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 023B220658 for ; Tue, 31 Mar 2020 19:59:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GuE4i6nT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 023B220658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JQBqdW7+O240vDBRZnDju2ru6J6Cxc0SeGezNWkQRlM=; b=GuE4i6nT9c25mBFX98S1twyTZ DK5boRRPKlvgaXazdYoyWmGiBgFZR3shK7hmykdDpTf/zf5l7F9SXDgInXgkv+nPbo2Z6e1JmXzaf TJb4DXtHm918JHUFQpKmDT2Po87l3t3llMoBt6367g0ucjQjfh/onO09JwqWFRO5U1Fx8QrgP3tNS fIE5ZG3pbIdkhFMk16MkkQJVD0zLtREyF1lsV0z42cyXL6SqY8YUy2BmRL0+HzNVlch3zKK56dRzY 3cuuhngQ6m/zyRi3m04PwsamVmySBR5J+xUTh8c+i9y4C8/w5nskDkzPUEBUIgxSLJuO8OJr3E6vW gbUHwpMSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJN34-0001OQ-K5; Tue, 31 Mar 2020 19:59:46 +0000 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJN31-0001Nz-3r for linux-riscv@lists.infradead.org; Tue, 31 Mar 2020 19:59:45 +0000 Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 31 Mar 2020 12:59:41 -0700 Received: from gurus-linux.qualcomm.com ([10.46.162.81]) by ironmsg01-sd.qualcomm.com with ESMTP; 31 Mar 2020 12:59:40 -0700 Received: by gurus-linux.qualcomm.com (Postfix, from userid 383780) id 3E60B4BE8; Tue, 31 Mar 2020 12:59:40 -0700 (PDT) Date: Tue, 31 Mar 2020 12:59:40 -0700 From: Guru Das Srinagesh To: Daniel Thompson Subject: Re: [PATCH v10 00/12] Convert PWM period and duty cycle to u64 Message-ID: <20200331195939.GA25781@codeaurora.org> References: <20200321114703.GB4672@kadam> <20200330191506.GA29534@codeaurora.org> <20200330202636.njjo4savgzf3g6yx@holly.lan> <20200330210012.GA27611@codeaurora.org> <20200331134804.xxrjaestztcazalc@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200331134804.xxrjaestztcazalc@holly.lan> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200331_125943_177305_6339F06B X-CRM114-Status: GOOD ( 22.04 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , Daniel Vetter , linux-fbdev@vger.kernel.org, David Airlie , "Wesley W. Terpstra" , Michael Turquette , Joonas Lahtinen , Kamil Debski , dri-devel@lists.freedesktop.org, Liam Girdwood , Atish Patra , Thierry Reding , Benjamin Gaignard , linux-riscv@lists.infradead.org, Lee Jones , linux-clk@vger.kernel.org, Ville =?utf-8?B?U3lyasOkbMOk?= , Alexandre Torgue , Mauro Carvalho Chehab , Axel Lin , Arnd Bergmann , Alexander Shiyan , Fabio Estevam , Chen-Yu Tsai , NXP Linux Team , Mukesh Ojha , Gerald Baeza , intel-gfx@lists.freedesktop.org, Dan Carpenter , linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, Jean Delvare , Philipp Zabel , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Bartlomiej Zolnierkiewicz , Sascha Hauer , Maarten Lankhorst , Maxime Ripard , Rodrigo Vivi , Mark Brown , Jani Nikula , Paul Walmsley , Subbaraman Narayanamurthy , Thomas Gleixner , Fabrice Gasnier , Ding Xiang , Pengutronix Kernel Team , Allison Randal , linux-hwmon@vger.kernel.org, Chris Wilson , Anson Huang , Richard Fontana , Stephen Boyd , Jingoo Han , linux-kernel@vger.kernel.org, Yash Shah , Palmer Dabbelt , Guenter Roeck , Maxime Coquelin , Shawn Guo Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Mar 31, 2020 at 02:48:04PM +0100, Daniel Thompson wrote: > On Mon, Mar 30, 2020 at 02:00:12PM -0700, Guru Das Srinagesh wrote: > > On Mon, Mar 30, 2020 at 09:26:36PM +0100, Daniel Thompson wrote: > > > On Mon, Mar 30, 2020 at 12:15:07PM -0700, Guru Das Srinagesh wrote: > > > > On Sat, Mar 21, 2020 at 02:47:03PM +0300, Dan Carpenter wrote: > > > > > This is a giant CC list. > > > > > > > > Yes, this is because I received feedback [1] on an earlier patchset > > > > directing me to add the reviewers of patches to the cover letter as > > > > well so that they get some context for the patch. > > > > ... > > > > [1] https://www.spinics.net/lists/linux-pwm/msg11735.html > > > > > > Strictly speaking I only asked for backlight maintainers to be Cc:ed. > > > I was fairly careful to be specific since I'm aware there are a variety > > > of differing habits when putting together the Cc: list for covering > > > letters. > > > > > > With the original patch header the purpose of the patch I was Cc:ed on > > > was impossible to determine without the covering letter. > > > > I suspect this might be the case for all the other reviewers as well - > > that they also would appreciate context for the specific patch they are > > being added to review. > > > > I wasn't entirely sure what the convention was, so I applied your > > suggestion to all the files. How do you suggest I handle this in my next > > patchset? I fully agree that such a large CC list does look really > > ungainly. > > IHMO there should not be a mechanical convention. Instead your goal > needs to be how to make it as easy as possible to review your patches. > > Think about it this way: Each person in the To: of a patch (and maybe > also Cc: depending on how you construct things) is a person you are > asking to review and comment on the patch. If that person will find it > easier to review the patch if they are included in the cover letter then > either they should be included or you should improve the patch > description of the patch itself (sometimes both). > > Either way it is about optimizing the patchset for readability. More > people read them than write them. Thank you for the explanation! I shall keep your suggestions in mind while sending out future patchsets. Thank you. Guru Das. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB28C18E5B for ; Wed, 1 Apr 2020 07:04:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A2F72073B for ; Wed, 1 Apr 2020 07:04:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A2F72073B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 053206E8F6; Wed, 1 Apr 2020 07:04:22 +0000 (UTC) Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5F2A26E881; Tue, 31 Mar 2020 19:59:43 +0000 (UTC) Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 31 Mar 2020 12:59:41 -0700 Received: from gurus-linux.qualcomm.com ([10.46.162.81]) by ironmsg01-sd.qualcomm.com with ESMTP; 31 Mar 2020 12:59:40 -0700 Received: by gurus-linux.qualcomm.com (Postfix, from userid 383780) id 3E60B4BE8; Tue, 31 Mar 2020 12:59:40 -0700 (PDT) Date: Tue, 31 Mar 2020 12:59:40 -0700 From: Guru Das Srinagesh To: Daniel Thompson Subject: Re: [PATCH v10 00/12] Convert PWM period and duty cycle to u64 Message-ID: <20200331195939.GA25781@codeaurora.org> References: <20200321114703.GB4672@kadam> <20200330191506.GA29534@codeaurora.org> <20200330202636.njjo4savgzf3g6yx@holly.lan> <20200330210012.GA27611@codeaurora.org> <20200331134804.xxrjaestztcazalc@holly.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200331134804.xxrjaestztcazalc@holly.lan> User-Agent: Mutt/1.5.21 (2010-09-15) X-Mailman-Approved-At: Wed, 01 Apr 2020 07:03:42 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , linux-fbdev@vger.kernel.org, David Airlie , "Wesley W. Terpstra" , Michael Turquette , Kamil Debski , dri-devel@lists.freedesktop.org, Liam Girdwood , Atish Patra , Thierry Reding , linux-riscv@lists.infradead.org, Lee Jones , linux-clk@vger.kernel.org, Alexandre Torgue , Mauro Carvalho Chehab , Axel Lin , Arnd Bergmann , Alexander Shiyan , Chen-Yu Tsai , NXP Linux Team , Mukesh Ojha , Gerald Baeza , intel-gfx@lists.freedesktop.org, Dan Carpenter , linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, Jean Delvare , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Bartlomiej Zolnierkiewicz , Sascha Hauer , Rodrigo Vivi , Mark Brown , Paul Walmsley , Subbaraman Narayanamurthy , Thomas Gleixner , Fabrice Gasnier , Ding Xiang , Pengutronix Kernel Team , Allison Randal , linux-hwmon@vger.kernel.org, Chris Wilson , Anson Huang , Richard Fontana , Stephen Boyd , Jingoo Han , linux-kernel@vger.kernel.org, Yash Shah , Palmer Dabbelt , Guenter Roeck , Maxime Coquelin , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Mar 31, 2020 at 02:48:04PM +0100, Daniel Thompson wrote: > On Mon, Mar 30, 2020 at 02:00:12PM -0700, Guru Das Srinagesh wrote: > > On Mon, Mar 30, 2020 at 09:26:36PM +0100, Daniel Thompson wrote: > > > On Mon, Mar 30, 2020 at 12:15:07PM -0700, Guru Das Srinagesh wrote: > > > > On Sat, Mar 21, 2020 at 02:47:03PM +0300, Dan Carpenter wrote: > > > > > This is a giant CC list. > > > > > > > > Yes, this is because I received feedback [1] on an earlier patchset > > > > directing me to add the reviewers of patches to the cover letter as > > > > well so that they get some context for the patch. > > > > ... > > > > [1] https://www.spinics.net/lists/linux-pwm/msg11735.html > > > > > > Strictly speaking I only asked for backlight maintainers to be Cc:ed. > > > I was fairly careful to be specific since I'm aware there are a variety > > > of differing habits when putting together the Cc: list for covering > > > letters. > > > > > > With the original patch header the purpose of the patch I was Cc:ed on > > > was impossible to determine without the covering letter. > > > > I suspect this might be the case for all the other reviewers as well - > > that they also would appreciate context for the specific patch they are > > being added to review. > > > > I wasn't entirely sure what the convention was, so I applied your > > suggestion to all the files. How do you suggest I handle this in my next > > patchset? I fully agree that such a large CC list does look really > > ungainly. > > IHMO there should not be a mechanical convention. Instead your goal > needs to be how to make it as easy as possible to review your patches. > > Think about it this way: Each person in the To: of a patch (and maybe > also Cc: depending on how you construct things) is a person you are > asking to review and comment on the patch. If that person will find it > easier to review the patch if they are included in the cover letter then > either they should be included or you should improve the patch > description of the patch itself (sometimes both). > > Either way it is about optimizing the patchset for readability. More > people read them than write them. Thank you for the explanation! I shall keep your suggestions in mind while sending out future patchsets. Thank you. Guru Das. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A19EC43331 for ; Tue, 31 Mar 2020 20:19:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A31820578 for ; Tue, 31 Mar 2020 20:19:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A31820578 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8C0736E884; Tue, 31 Mar 2020 20:19:20 +0000 (UTC) Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5F2A26E881; Tue, 31 Mar 2020 19:59:43 +0000 (UTC) Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 31 Mar 2020 12:59:41 -0700 Received: from gurus-linux.qualcomm.com ([10.46.162.81]) by ironmsg01-sd.qualcomm.com with ESMTP; 31 Mar 2020 12:59:40 -0700 Received: by gurus-linux.qualcomm.com (Postfix, from userid 383780) id 3E60B4BE8; Tue, 31 Mar 2020 12:59:40 -0700 (PDT) Date: Tue, 31 Mar 2020 12:59:40 -0700 From: Guru Das Srinagesh To: Daniel Thompson Message-ID: <20200331195939.GA25781@codeaurora.org> References: <20200321114703.GB4672@kadam> <20200330191506.GA29534@codeaurora.org> <20200330202636.njjo4savgzf3g6yx@holly.lan> <20200330210012.GA27611@codeaurora.org> <20200331134804.xxrjaestztcazalc@holly.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200331134804.xxrjaestztcazalc@holly.lan> User-Agent: Mutt/1.5.21 (2010-09-15) X-Mailman-Approved-At: Tue, 31 Mar 2020 20:19:19 +0000 Subject: Re: [Intel-gfx] [PATCH v10 00/12] Convert PWM period and duty cycle to u64 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , linux-fbdev@vger.kernel.org, David Airlie , "Wesley W. Terpstra" , Michael Turquette , Kamil Debski , dri-devel@lists.freedesktop.org, Liam Girdwood , Atish Patra , Benjamin Gaignard , linux-riscv@lists.infradead.org, Lee Jones , linux-clk@vger.kernel.org, Alexandre Torgue , Mauro Carvalho Chehab , Axel Lin , Arnd Bergmann , Alexander Shiyan , Fabio Estevam , Chen-Yu Tsai , NXP Linux Team , Mukesh Ojha , Gerald Baeza , intel-gfx@lists.freedesktop.org, Dan Carpenter , linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, Jean Delvare , Philipp Zabel , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Bartlomiej Zolnierkiewicz , Sascha Hauer , Maxime Ripard , Mark Brown , Paul Walmsley , Subbaraman Narayanamurthy , Thomas Gleixner , Fabrice Gasnier , Ding Xiang , Pengutronix Kernel Team , Allison Randal , linux-hwmon@vger.kernel.org, Chris Wilson , Anson Huang , Richard Fontana , Stephen Boyd , Jingoo Han , linux-kernel@vger.kernel.org, Yash Shah , Palmer Dabbelt , Guenter Roeck , Maxime Coquelin , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Mar 31, 2020 at 02:48:04PM +0100, Daniel Thompson wrote: > On Mon, Mar 30, 2020 at 02:00:12PM -0700, Guru Das Srinagesh wrote: > > On Mon, Mar 30, 2020 at 09:26:36PM +0100, Daniel Thompson wrote: > > > On Mon, Mar 30, 2020 at 12:15:07PM -0700, Guru Das Srinagesh wrote: > > > > On Sat, Mar 21, 2020 at 02:47:03PM +0300, Dan Carpenter wrote: > > > > > This is a giant CC list. > > > > > > > > Yes, this is because I received feedback [1] on an earlier patchset > > > > directing me to add the reviewers of patches to the cover letter as > > > > well so that they get some context for the patch. > > > > ... > > > > [1] https://www.spinics.net/lists/linux-pwm/msg11735.html > > > > > > Strictly speaking I only asked for backlight maintainers to be Cc:ed. > > > I was fairly careful to be specific since I'm aware there are a variety > > > of differing habits when putting together the Cc: list for covering > > > letters. > > > > > > With the original patch header the purpose of the patch I was Cc:ed on > > > was impossible to determine without the covering letter. > > > > I suspect this might be the case for all the other reviewers as well - > > that they also would appreciate context for the specific patch they are > > being added to review. > > > > I wasn't entirely sure what the convention was, so I applied your > > suggestion to all the files. How do you suggest I handle this in my next > > patchset? I fully agree that such a large CC list does look really > > ungainly. > > IHMO there should not be a mechanical convention. Instead your goal > needs to be how to make it as easy as possible to review your patches. > > Think about it this way: Each person in the To: of a patch (and maybe > also Cc: depending on how you construct things) is a person you are > asking to review and comment on the patch. If that person will find it > easier to review the patch if they are included in the cover letter then > either they should be included or you should improve the patch > description of the patch itself (sometimes both). > > Either way it is about optimizing the patchset for readability. More > people read them than write them. Thank you for the explanation! I shall keep your suggestions in mind while sending out future patchsets. Thank you. Guru Das. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx