From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA96BC43331 for ; Tue, 31 Mar 2020 20:02:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B37A20658 for ; Tue, 31 Mar 2020 20:02:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Whc6c+j2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B37A20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A7D261654; Tue, 31 Mar 2020 22:01:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A7D261654 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1585684947; bh=o4swV1vDj7xy+g2oomhyj2u5Kn0oFiLjBvW+QPxd+hw=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Whc6c+j2jUuCP5p85K26XyVpaLcVoKTxviqesN+HTfsXLzZj8+a8HJfzFziLck4Ji 1g08FM9XWV23iLXxLfwIzzNCLjOq/necEeO0lg48gT3sszuc9xOwMCkC0cKRP4clZV yreWqPloK+SQJC73o0AxAu5NLU37ASM8+CEQK/5o= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 01EABF8014F; Tue, 31 Mar 2020 22:01:37 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 00AA4F80157; Tue, 31 Mar 2020 22:01:35 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2D982F800AA for ; Tue, 31 Mar 2020 22:01:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2D982F800AA Received: by mail-io1-f67.google.com with SMTP id h131so23115994iof.1 for ; Tue, 31 Mar 2020 13:01:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vkxxip8s1ZW0GnbenbnFeoJyggUhdVdybES6+NRkTls=; b=BWe2rwd8nNgD4f8cMGQ5OWCyRZLrFc1YokxyBP2gyTUQohLYG473lnRVtTWt3Qu2dp 6Zo5OQq//af0EgZjAUxBoZf3WxOPszQ+W2ZDRivnXDzdoXUaFvVVyBGkk9vijTjyXATK y/6Z/2a4kL/mpIlRZ1RPx1oZj0AsBXiWL7wHi7YpD0J4jEdW1e3WJiu72yxI6lB7LOdz 6UZTqTiX8gJKbHgI0X6ZSYBxOX3ns+NT9WDWx6//qItV59LKsH6PuhzTbHB5M0z5kVpA L6ywBkCRYsZ9TO1wNEJ7+FKYKmUwvAfstGtUBV2s5X6FWWcpHFicJI04/n5NqV3Z83VU yN/g== X-Gm-Message-State: ANhLgQ33SPFpp77S6Ao9In7jnhgqjnJ6xQdmqOdLcjuCxaCWVwy2VbsO tRfSXwtGIyuI7voOVbyaFQ== X-Google-Smtp-Source: ADFU+vvBejlhKFx9aVEK9Es2UC6IoLSf1k2SdAYxRxDFr5MBW3pEn/d1O633AZt6lRcbhYJICsvimw== X-Received: by 2002:a02:2505:: with SMTP id g5mr15167286jag.114.1585684891883; Tue, 31 Mar 2020 13:01:31 -0700 (PDT) Received: from rob-hp-laptop ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id h29sm6197193ili.19.2020.03.31.13.01.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 13:01:30 -0700 (PDT) Received: (nullmailer pid 6517 invoked by uid 1000); Tue, 31 Mar 2020 20:01:29 -0000 Date: Tue, 31 Mar 2020 14:01:29 -0600 From: Rob Herring To: Johan Jonker Subject: Re: [PATCH v2 2/3] dt-bindings: sound: rockchip-spdif: add #sound-dai-cells property Message-ID: <20200331200129.GA6458@bogus> References: <20200324123155.11858-1-jbx6244@gmail.com> <20200324123155.11858-2-jbx6244@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200324123155.11858-2-jbx6244@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, heiko@sntech.de, lgirdwood@gmail.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 24 Mar 2020 13:31:54 +0100, Johan Jonker wrote: > '#sound-dai-cells' is required to properly interpret > the list of DAI specified in the 'sound-dai' property, > so add them to 'rockchip-spdif.yaml' > > Signed-off-by: Johan Jonker > --- > Documentation/devicetree/bindings/sound/rockchip-spdif.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 2/3] dt-bindings: sound: rockchip-spdif: add #sound-dai-cells property Date: Tue, 31 Mar 2020 14:01:29 -0600 Message-ID: <20200331200129.GA6458@bogus> References: <20200324123155.11858-1-jbx6244@gmail.com> <20200324123155.11858-2-jbx6244@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200324123155.11858-2-jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Johan Jonker Cc: lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rockchip.vger.kernel.org On Tue, 24 Mar 2020 13:31:54 +0100, Johan Jonker wrote: > '#sound-dai-cells' is required to properly interpret > the list of DAI specified in the 'sound-dai' property, > so add them to 'rockchip-spdif.yaml' > > Signed-off-by: Johan Jonker > --- > Documentation/devicetree/bindings/sound/rockchip-spdif.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6255C43331 for ; Tue, 31 Mar 2020 20:01:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 489AE20658 for ; Tue, 31 Mar 2020 20:01:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aiM3ZAa7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 489AE20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=75UsFh5zLJ17R3Ps8MMp/7N6J9VbLLlS6izGTsPmr3k=; b=aiM3ZAa7d2Ngug XJ3ka6FrV6I4/ZqFAAfT7M9M3LZa5BFmlLUUPObhwEF2y36rn4bryNYl2zzi/iwOYhQY/uJd84Dzk +MmucaOv4MStjxLlBxS5C+Mve/TnJ9C5gQPsMDgorol8o7HJus3PFPqMzYWM6bAUuKcqir+0PSqfu pl/zY/aNezi4lZ4c8GfBkTb4IcchflU7mprSC3r64K3uOlZyvzH3e5+Bj6JEXSLPPcMKHUbpctNtC gKUq15SZkQGH6J+tX2dL0QGTFrSyOwrJ1mBluMUpv+MDGe7YtLwMNM+LSCqpsWWDZ4V0HCaDotAs7 3qKSmZCYMuHmcRI9emWQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJN4u-0004Jq-W5; Tue, 31 Mar 2020 20:01:41 +0000 Received: from mail-io1-f65.google.com ([209.85.166.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJN4m-0004IS-NU; Tue, 31 Mar 2020 20:01:35 +0000 Received: by mail-io1-f65.google.com with SMTP id y14so6015115iol.12; Tue, 31 Mar 2020 13:01:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vkxxip8s1ZW0GnbenbnFeoJyggUhdVdybES6+NRkTls=; b=KJweKYKpYNR4yKPVQQxuTTelZWr7Q/ezEPJbtDAQe8VntX6UCowdBICe4mHVzsHVS7 Tdw2ilpBObFPUTCmRbFFEPovnHNh/0hyuAOZNoiEmPpQqSVOmzNL2T8JCfmW/FwVnzBa WOMNIMAu2tgTkyVNTtbyXXp7NlM4Ub8xwYJEBmyKwh6UoRaPQLuJIGPecHkOu0JUuehg zOdoyfpni8y00omqH7PrdSQpTCXjN5PnfkZ+Ic9x2ObK5iu9+cPy2W+7qlUolbpKIU4c CToOkYGwgOa++ebr0hLxr7v6BoU0RFyXskyxQcSO3uVhJsHE1P7dKY0mALNTtVg2OVot AA+Q== X-Gm-Message-State: ANhLgQ0HRRVaJqcVoaGNsSR5JIU/8B0MH1Dss1Cr/pxreZMgPcfdMxlZ 8IuAHhm9O7zmAMxoyLTGkQ== X-Google-Smtp-Source: ADFU+vvBejlhKFx9aVEK9Es2UC6IoLSf1k2SdAYxRxDFr5MBW3pEn/d1O633AZt6lRcbhYJICsvimw== X-Received: by 2002:a02:2505:: with SMTP id g5mr15167286jag.114.1585684891883; Tue, 31 Mar 2020 13:01:31 -0700 (PDT) Received: from rob-hp-laptop ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id h29sm6197193ili.19.2020.03.31.13.01.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 13:01:30 -0700 (PDT) Received: (nullmailer pid 6517 invoked by uid 1000); Tue, 31 Mar 2020 20:01:29 -0000 Date: Tue, 31 Mar 2020 14:01:29 -0600 From: Rob Herring To: Johan Jonker Subject: Re: [PATCH v2 2/3] dt-bindings: sound: rockchip-spdif: add #sound-dai-cells property Message-ID: <20200331200129.GA6458@bogus> References: <20200324123155.11858-1-jbx6244@gmail.com> <20200324123155.11858-2-jbx6244@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200324123155.11858-2-jbx6244@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200331_130132_763697_B80CB7E1 X-CRM114-Status: UNSURE ( 9.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, heiko@sntech.de, lgirdwood@gmail.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 24 Mar 2020 13:31:54 +0100, Johan Jonker wrote: > '#sound-dai-cells' is required to properly interpret > the list of DAI specified in the 'sound-dai' property, > so add them to 'rockchip-spdif.yaml' > > Signed-off-by: Johan Jonker > --- > Documentation/devicetree/bindings/sound/rockchip-spdif.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AFBEC2D0EF for ; Tue, 31 Mar 2020 20:01:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2713C2080C for ; Tue, 31 Mar 2020 20:01:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585684893; bh=o4swV1vDj7xy+g2oomhyj2u5Kn0oFiLjBvW+QPxd+hw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=z7DnM2FvuP25ktSHn1znx1Gw5S2aTX+iFKh2/J7d3iLqruEfp8Agl89kVkL1aG1g/ pSCcoxvnRYD8ZGjZQhl8DLbTTBVDqjaJqP+Dyfg61HNHdcws1K6bHWMnLEud6j3JKs Rljz5xoYYzXbJqwE5uPx12DXCCBCMbNUXKw62OFU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726411AbgCaUBc (ORCPT ); Tue, 31 Mar 2020 16:01:32 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:33550 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728124AbgCaUBc (ORCPT ); Tue, 31 Mar 2020 16:01:32 -0400 Received: by mail-io1-f67.google.com with SMTP id o127so23123317iof.0; Tue, 31 Mar 2020 13:01:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vkxxip8s1ZW0GnbenbnFeoJyggUhdVdybES6+NRkTls=; b=VMWUWHT2WLebfuFIJxAG0k6OCkisqUYZSv2x5+Vck+QDmHn4EdnYKpbieNPbls/vh8 kA23iobISUi2hZMj+P1nbo20UT99dWIa1KlRaN/DJB0J7icg0TBcBnfm2T/froCxUhcY i6LmSxQuxdrrH18eOpuTMP7XOpxpU+kYRUhcwKQ4oHiGE0PslrfYeUZPw+QowtNEsStf B5Lq1L2/9LT5EqqOUboxeOfDDUqxF7/2wOctrrDwvkN1RXHY4mPJoXyKBKcU1NS/IP9E ECDxQSAke3CSYlPRAHQlS6EzctBZhWCh0UFjdfKBlPtYx1RqWvJ+FeB8Pa+4iVcR+Ob+ Lz/g== X-Gm-Message-State: ANhLgQ3Me4s42Qz3tvzAEfJKVDHvt1nezj7ZxgfDFyJ8GWJTANfuqOou /5APX5xIN6hidX+MGA3WAg== X-Google-Smtp-Source: ADFU+vvBejlhKFx9aVEK9Es2UC6IoLSf1k2SdAYxRxDFr5MBW3pEn/d1O633AZt6lRcbhYJICsvimw== X-Received: by 2002:a02:2505:: with SMTP id g5mr15167286jag.114.1585684891883; Tue, 31 Mar 2020 13:01:31 -0700 (PDT) Received: from rob-hp-laptop ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id h29sm6197193ili.19.2020.03.31.13.01.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 13:01:30 -0700 (PDT) Received: (nullmailer pid 6517 invoked by uid 1000); Tue, 31 Mar 2020 20:01:29 -0000 Date: Tue, 31 Mar 2020 14:01:29 -0600 From: Rob Herring To: Johan Jonker Cc: lgirdwood@gmail.com, broonie@kernel.org, heiko@sntech.de, robh+dt@kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] dt-bindings: sound: rockchip-spdif: add #sound-dai-cells property Message-ID: <20200331200129.GA6458@bogus> References: <20200324123155.11858-1-jbx6244@gmail.com> <20200324123155.11858-2-jbx6244@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200324123155.11858-2-jbx6244@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 24 Mar 2020 13:31:54 +0100, Johan Jonker wrote: > '#sound-dai-cells' is required to properly interpret > the list of DAI specified in the 'sound-dai' property, > so add them to 'rockchip-spdif.yaml' > > Signed-off-by: Johan Jonker > --- > Documentation/devicetree/bindings/sound/rockchip-spdif.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > Reviewed-by: Rob Herring