From: Stefano Brivio <sbrivio@redhat.com>
To: Soumyajit Deb <debsoumyajit100@gmail.com>
Cc: gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com,
Larry.Finger@lwfinger.net
Subject: Re: [Outreachy kernel] [Outreachy] [PATCH v2 0/3] staging: rtl8188eu: Resolve various warnings reported by checkpatch.pl
Date: Wed, 1 Apr 2020 04:47:54 +0200 [thread overview]
Message-ID: <20200401044754.3a12aeed@elisabeth> (raw)
In-Reply-To: <20200331183201.18386-1-debsoumyajit100@gmail.com>
On Wed, 1 Apr 2020 00:01:58 +0530
Soumyajit Deb <debsoumyajit100@gmail.com> wrote:
> Changes in v2:
> -PATCH 1/3: No change
> -PATCH 2/3: Add curly brackets in conditional statements to improve
> code readability and properly align the lines of a
> function call as suggested by Stefano Brivio.
> -PATCH 3/3: Remove extra unnecessary parentheses to improve code
> readability as suggested by Stefano Brivio
> <sbrivio@redhat.com>
On Mon, 30 Mar 2020 20:17:01 +0200
Stefano Brivio <sbrivio@redhat.com> wrote:
> This looks correct, but still it's horrible, all those excess
> parentheses make it quite hard to read. If you plan to remove them,
> perhaps it's easier to have a change doing that first, in the same
> series, so that this change can be checked more easily.
I really meant: remove them first. See also:
On Tue, 31 Mar 2020 16:49:47 +0200
Stefano Brivio <sbrivio@redhat.com> wrote:
> - the new patchset (v2) will have:
> - patch 1/3 v2 (no changes)
> - patch 2/3 v2 (for example, if you remove () here)
> - patch 3/3 v2 (this current patch with the changes I suggested)
This way, I could review 3/3 much quicker. Note that your patches are
also (almost) correct as they are, so this is not really a requirement
-- it would just help my eyes a bit.
--
Stefano
prev parent reply other threads:[~2020-04-01 2:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 18:31 [Outreachy] [PATCH v2 0/3] staging: rtl8188eu: Resolve various warnings reported by checkpatch.pl Soumyajit Deb
2020-03-31 18:31 ` [Outreachy] [PATCH v2 1/3] staging: rtl8188eu: Properly structure the multiline comment Soumyajit Deb
2020-03-31 18:32 ` [Outreachy] [PATCH v2 2/3] staging: rtl8188eu: Line over 80 characters Soumyajit Deb
2020-04-01 2:48 ` [Outreachy kernel] " Stefano Brivio
2020-04-01 7:59 ` Soumyajit Deb
2020-04-01 8:41 ` Julia Lawall
2020-04-02 13:01 ` Soumyajit Deb
2020-04-02 13:04 ` Julia Lawall
2020-04-02 14:41 ` Soumyajit Deb
2020-03-31 18:32 ` [Outreachy] [PATCH v2 3/3] staging: rtl8188eu: Remove unnecessary extra parentheses Soumyajit Deb
2020-04-01 2:47 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401044754.3a12aeed@elisabeth \
--to=sbrivio@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=debsoumyajit100@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.