All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: amirmizi6@gmail.com
Cc: Eyal.Cohen@nuvoton.com, oshrialkoby85@gmail.com,
	alexander.steffen@infineon.com, robh+dt@kernel.org,
	mark.rutland@arm.com, peterhuewe@gmx.de, jgg@ziepe.ca,
	arnd@arndb.de, gregkh@linuxfoundation.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-integrity@vger.kernel.org, oshri.alkoby@nuvoton.com,
	tmaimon77@gmail.com, gcwilson@us.ibm.com, kgoldman@us.ibm.com,
	Dan.Morav@nuvoton.com, oren.tanami@nuvoton.com,
	shmulik.hager@nuvoton.com, amir.mizinski@nuvoton.com,
	Christophe Richard <hristophe-h.ricard@st.com>
Subject: Re: [PATCH v4 2/7] tpm: tpm_tis: Add check_data handle to tpm_tis_phy_ops in order to check data integrity
Date: Wed, 1 Apr 2020 11:20:19 +0300	[thread overview]
Message-ID: <20200401082019.GB17325@linux.intel.com> (raw)
In-Reply-To: <20200331113207.107080-3-amirmizi6@gmail.com>

On Tue, Mar 31, 2020 at 02:32:02PM +0300, amirmizi6@gmail.com wrote:
> From: Amir Mizinski <amirmizi6@gmail.com>
> 
> In order to compute the crc over the data sent in lower layer
>  (I2C for instance), tpm_tis_check_data() calls an operation (if available)
>  to check data integrity. If data integrity cannot be verified, a retry
>  attempt to save the sent/received data is implemented.
> 
> The current steps are done when sending a command:
>     1. Host writes to TPM_STS.commandReady.
>     2. Host writes command.
>     3. Host checks that TPM received data is valid.
>     4. If data is currupted go to step 1.
> 
> When receiving data:
>     1. Host checks that TPM_STS.dataAvail is set.
>     2. Host saves received data.
>     3. Host checks that received data is correct.
>     4. If data is currupted Host writes to TPM_STS.responseRetry and go to
>         step 1.
> 
> Co-developed-by: Christophe Richard <hristophe-h.ricard@st.com>
> Signed-off-by: Christophe Richard <hristophe-h.ricard@st.com>
> Signed-off-by: Amir Mizinski <amirmizi6@gmail.com>

The email is malformed.

So.. How did Christophe participate on writing this patch? I haven't
seen him shouting anything about the subject and still his SOB is
there.

/Jarkko

  reply	other threads:[~2020-04-01  8:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-31 11:32 [PATCH v4 0/7] Add tpm i2c ptp driver amirmizi6
2020-03-31 11:32 ` [PATCH v4 1/7] tpm: tpm_tis: Make implementation of read16 read32 write32 optional amirmizi6
2020-03-31 12:04   ` Jarkko Sakkinen
2020-03-31 11:32 ` [PATCH v4 2/7] tpm: tpm_tis: Add check_data handle to tpm_tis_phy_ops in order to check data integrity amirmizi6
2020-04-01  8:20   ` Jarkko Sakkinen [this message]
2020-04-01 20:18     ` Benoit HOUYERE
     [not found]     ` <CAMHTsUUvStPHNL-W7vtjGrtehQx22jUZbN8kLib4h+JWH3p7_w@mail.gmail.com>
2020-04-02 20:17       ` Jarkko Sakkinen
2020-03-31 11:32 ` [PATCH v4 3/7] tpm: tpm_tis: rewrite "tpm_tis_req_canceled()" amirmizi6
2020-03-31 12:13   ` Jarkko Sakkinen
2020-03-31 13:52     ` Ken Goldman
2020-03-31 11:32 ` [PATCH v4 4/7] tpm: tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception amirmizi6
2020-03-31 12:17   ` Jarkko Sakkinen
2020-03-31 21:34     ` Benoit HOUYERE
2020-04-01  8:34       ` Jarkko Sakkinen
2020-03-31 11:32 ` [PATCH v4 5/7] tpm: Handle an exception for TPM Firmware Update mode amirmizi6
2020-03-31 11:32 ` [PATCH v4 6/7] dt-bindings: tpm: Add YAML schema for TPM TIS I2C options amirmizi6
2020-03-31 16:31   ` Rob Herring
2020-03-31 11:32 ` [PATCH v4 7/7] tpm: tpm_tis: add tpm_tis_i2c driver amirmizi6
2020-03-31 12:20   ` Jarkko Sakkinen
2020-03-31 15:38   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200401082019.GB17325@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=Dan.Morav@nuvoton.com \
    --cc=Eyal.Cohen@nuvoton.com \
    --cc=alexander.steffen@infineon.com \
    --cc=amir.mizinski@nuvoton.com \
    --cc=amirmizi6@gmail.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=gcwilson@us.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hristophe-h.ricard@st.com \
    --cc=jgg@ziepe.ca \
    --cc=kgoldman@us.ibm.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=oren.tanami@nuvoton.com \
    --cc=oshri.alkoby@nuvoton.com \
    --cc=oshrialkoby85@gmail.com \
    --cc=peterhuewe@gmx.de \
    --cc=robh+dt@kernel.org \
    --cc=shmulik.hager@nuvoton.com \
    --cc=tmaimon77@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.