From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D562C43331 for ; Wed, 1 Apr 2020 08:55:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3936D2080C for ; Wed, 1 Apr 2020 08:55:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585731352; bh=2lkU7aDUNcZPy67HrpmmAS88AU2gOLJri4GVeA1yePc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=azTVHHlkZ4Pgdr1k/R9G8QHWAeBdAGQzUKz3AYoXcDNjYp8WPPROGHfQr+7yuL1EN yvzhVfcReHgnXfMEUEU4L8dL9WUH1sjHOPmhYvszM9wHrh/fWmgZ3kFzOHqg5I54e9 +0RokaWi2fU249hOklLwwmTz4ToaDT5eOy65RYbY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727322AbgDAIzv (ORCPT ); Wed, 1 Apr 2020 04:55:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:54190 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726536AbgDAIzv (ORCPT ); Wed, 1 Apr 2020 04:55:51 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D5EEC20784; Wed, 1 Apr 2020 08:55:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585731350; bh=2lkU7aDUNcZPy67HrpmmAS88AU2gOLJri4GVeA1yePc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Bth9ooTGpGk47WkFhb8ZQYTHCLL4rF2ytX6k7MDqKodh7FaLEhpwBDK9nsj5akxoq sJQKhJJYAEUN4P5GvCTRkwN8NCD/SyPzdzhJKHcZCAJmsT0wlGanc15oucvzFFbrqk z70oKRvJNBQHcZbfxpespBB/JAkbiJKjw3rf1bYg= Date: Wed, 1 Apr 2020 10:55:48 +0200 From: Greg Kroah-Hartman To: Hyunki Koo Cc: hyunki00.koo@gmail.com, Kukjin Kim , Krzysztof Kozlowski , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tty: samsung_tty: 32-bit access for TX/RX hold registers Message-ID: <20200401085548.GC2026666@kroah.com> References: <20200401082721.19431-1-hyunki00.koo@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200401082721.19431-1-hyunki00.koo@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Wed, Apr 01, 2020 at 05:27:20PM +0900, Hyunki Koo wrote: > - if (np) > + if (np) { > of_property_read_u32(np, > "samsung,uart-fifosize", &ourport->port.fifosize); > > + if (of_property_read_u32(np, "reg-io-width", &prop) == 0) { > + switch (prop) { > + case 1: > + ourport->port.iotype = UPIO_MEM; > + break; > + case 4: > + ourport->port.iotype = UPIO_MEM32; > + break; > + default: > + dev_warn(&pdev->dev, "unsupported reg-io-width (%d)\n", > + prop); > + ret = -EINVAL; > + break; > + } > + } > + } > + Does this mean that reg-io-width is now a required property for all samsung uarts? Does this break older dts files? Or should you fall-back to the previous operation if the attribute is not there? And please fix your email client, the headers were all messed up, causing my initial response to be only sent to you :( thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F2FDC2D0F4 for ; Wed, 1 Apr 2020 08:55:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2BB12078B for ; Wed, 1 Apr 2020 08:55:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tX/I5OQQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bth9ooTG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2BB12078B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=veOgayncL/uUiGG7eoi+3SRjXedqT7fsXQCkxAcLuwI=; b=tX/I5OQQ16b/wF uLg7AZyhPMzCfCYq1XUjgihRjmlr5A2idXxTkubRS1OWGHO4M/fltxoaGTzgk+hPDM1YOlL7nF+Xl rxODB/3KvD0jbPpALmc/5AO8Z7thdmS7TbvPfwl/x5PqxUi17d8pav/Z0V1dPTBL2d0QaefrqYT4a cVoVbUXFaXdBVvaIKDru0IifVTGc3RmrNX3Xpa1JVbhZgN1poGjqYHP5IfA0oUC7l0kxyY4MNRgZ/ oIXbNGvQCPNMj/Pk4Y5Ak4JVMlfdz4EcifBZYoQ4gEvmCZS+OWKw2haRGmBGSCIzm/yUz0oFcV2XK 0xUeBOXS6ls8ye27NPpw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJZA9-00035F-HT; Wed, 01 Apr 2020 08:55:53 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJZA7-00034p-5B for linux-arm-kernel@lists.infradead.org; Wed, 01 Apr 2020 08:55:52 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D5EEC20784; Wed, 1 Apr 2020 08:55:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585731350; bh=2lkU7aDUNcZPy67HrpmmAS88AU2gOLJri4GVeA1yePc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Bth9ooTGpGk47WkFhb8ZQYTHCLL4rF2ytX6k7MDqKodh7FaLEhpwBDK9nsj5akxoq sJQKhJJYAEUN4P5GvCTRkwN8NCD/SyPzdzhJKHcZCAJmsT0wlGanc15oucvzFFbrqk z70oKRvJNBQHcZbfxpespBB/JAkbiJKjw3rf1bYg= Date: Wed, 1 Apr 2020 10:55:48 +0200 From: Greg Kroah-Hartman To: Hyunki Koo Subject: Re: [PATCH] tty: samsung_tty: 32-bit access for TX/RX hold registers Message-ID: <20200401085548.GC2026666@kroah.com> References: <20200401082721.19431-1-hyunki00.koo@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200401082721.19431-1-hyunki00.koo@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200401_015551_217844_56AB55D6 X-CRM114-Status: GOOD ( 10.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, hyunki00.koo@gmail.com, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Kukjin Kim , linux-serial@vger.kernel.org, Jiri Slaby , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 01, 2020 at 05:27:20PM +0900, Hyunki Koo wrote: > - if (np) > + if (np) { > of_property_read_u32(np, > "samsung,uart-fifosize", &ourport->port.fifosize); > > + if (of_property_read_u32(np, "reg-io-width", &prop) == 0) { > + switch (prop) { > + case 1: > + ourport->port.iotype = UPIO_MEM; > + break; > + case 4: > + ourport->port.iotype = UPIO_MEM32; > + break; > + default: > + dev_warn(&pdev->dev, "unsupported reg-io-width (%d)\n", > + prop); > + ret = -EINVAL; > + break; > + } > + } > + } > + Does this mean that reg-io-width is now a required property for all samsung uarts? Does this break older dts files? Or should you fall-back to the previous operation if the attribute is not there? And please fix your email client, the headers were all messed up, causing my initial response to be only sent to you :( thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel