From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93ABCC43331 for ; Wed, 1 Apr 2020 09:19:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6505E20784 for ; Wed, 1 Apr 2020 09:19:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585732799; bh=bZgzelA3UaTi5U8XMpF6gpsu/Vu2uMmzpccgocPvsVI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zVATSMyuaAy8BKXWniFEofZyP9F0ngHVh2uWmHWTtzHmCB+HQhOZ1rJs1SqdCQW+0 Fjwnj3DOd3/FgasUC9Nj294aBb7cqpthHrtMtXzv/uhq1SI2JWGuaY19ATMdk4w4wX i8v95NHDLpB2v3w3PAQkoI5O6JMNEdPHtxmc7eKA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726974AbgDAJT7 (ORCPT ); Wed, 1 Apr 2020 05:19:59 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:38350 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbgDAJT6 (ORCPT ); Wed, 1 Apr 2020 05:19:58 -0400 Received: by mail-ed1-f65.google.com with SMTP id e5so28782225edq.5; Wed, 01 Apr 2020 02:19:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oiXWCfIsx4h3K5MebDggs1yLqhBWHjw9GlgqdZt4chM=; b=EFspn04Dw6kDgs+6Fptn5RhSVJ5UlCnR+NZzW2BOEYJrOGUBa4wqM65ysM0LJWW+Bz wIfUXZ2Tt7GYeZaKWg2ay8L5Co/NvKn/KSjokyCwJX1hsld0lXq7URHCiP2Y45/R2VQN vDm1ECv7p7YPw3QL81VRagKwMxMs0oSlyoYmmv9KzsU5ksJjaXrZbHiY/DUx0lbccY6s z3DYLMw+jXnIa8rWujKCLI3tW8KqtTwG9+/b2HaufWP0hdzo91zD83JvrhJA3UXaIKlI 8OPGlQuJlQOYNUwYY3WT9M/IFxBhFcuAEPQwfbF8PMoLsO/9PA4Ajxb8rUqUbTM4Fxmt ckxg== X-Gm-Message-State: ANhLgQ2TDWxdFKcCEbNb0SdpsJabDVOQSdOt18Nm4UHTXHTCiAKJhq3F JG8lSp1pZe/iaab8JAwHA20= X-Google-Smtp-Source: ADFU+vtXO8qJ6/LomWoqPFo16aC2m31U0bjGq/5iuPLC69+YRJjCpnuSsVEXZGXdraHuzjQo5VWJNg== X-Received: by 2002:a17:906:50e:: with SMTP id j14mr18523296eja.300.1585732794952; Wed, 01 Apr 2020 02:19:54 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id w4sm393813ejz.44.2020.04.01.02.19.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Apr 2020 02:19:54 -0700 (PDT) Date: Wed, 1 Apr 2020 11:19:52 +0200 From: Krzysztof Kozlowski To: Greg Kroah-Hartman Cc: Hyunki Koo , hyunki00.koo@gmail.com, Kukjin Kim , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tty: samsung_tty: 32-bit access for TX/RX hold registers Message-ID: <20200401091952.GA14425@kozik-lap> References: <20200401082721.19431-1-hyunki00.koo@samsung.com> <20200401085548.GC2026666@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200401085548.GC2026666@kroah.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Wed, Apr 01, 2020 at 10:55:48AM +0200, Greg Kroah-Hartman wrote: > On Wed, Apr 01, 2020 at 05:27:20PM +0900, Hyunki Koo wrote: > > - if (np) > > + if (np) { > > of_property_read_u32(np, > > "samsung,uart-fifosize", &ourport->port.fifosize); > > > > + if (of_property_read_u32(np, "reg-io-width", &prop) == 0) { > > + switch (prop) { > > + case 1: > > + ourport->port.iotype = UPIO_MEM; > > + break; > > + case 4: > > + ourport->port.iotype = UPIO_MEM32; > > + break; > > + default: > > + dev_warn(&pdev->dev, "unsupported reg-io-width (%d)\n", > > + prop); > > + ret = -EINVAL; > > + break; > > + } > > + } > > + } > > + > > Does this mean that reg-io-width is now a required property for all > samsung uarts? Does this break older dts files? Or should you > fall-back to the previous operation if the attribute is not there? Yes, it looks like silently breaking all boards. Since of_property_read_u32() will return errno, the warning message won't be printed and all register reads will fail (return 0). This looks like not tested on real HW. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC2DAC2D0F2 for ; Wed, 1 Apr 2020 09:20:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FD6520784 for ; Wed, 1 Apr 2020 09:20:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MIEqKSxP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FD6520784 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mevZRWTnk7Udd8wkIKvUYhCriNy8Hx0Lp/qINqxamfY=; b=MIEqKSxPfKWutG 2XdugpbTvRI1B3onpmMs5n3/fofrm/Ti3PzPmCu+NSlSbeEIIDhOb5OMctQXHdJ/tUdTu0omfnDlg ptnwjxwwMjm8NZneeWpSg3pCGXb1cwb0cdGRllv78FRBfcMymrfltsh+FkmvUtmF6OX+CnnhZsaps K7fLpK2WS63RboBloA+HJQ4x+KDj7Py06f6lUw28kvxwHMxUTbQ2aHli9UOu6Nn47rxuwg+EIGvzs d13uwy7rxwUMYEu2HwrJLBephPwBLLkVyspXELuIu32LKpIUb2l5vNzXRl1ic7X2nm/4R1FlVnRmZ U+Xrt2xVs3iaEg4Ax4dA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJZXU-0000lL-Co; Wed, 01 Apr 2020 09:20:00 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJZXR-0000kh-0q for linux-arm-kernel@lists.infradead.org; Wed, 01 Apr 2020 09:19:58 +0000 Received: by mail-ed1-f66.google.com with SMTP id i7so23837273edq.3 for ; Wed, 01 Apr 2020 02:19:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oiXWCfIsx4h3K5MebDggs1yLqhBWHjw9GlgqdZt4chM=; b=EoGSYPCG4z3U7B7G8YIh3zO1cA7IJ4kl1BSnFhP8iwCRohmGTO/OCJoy4QMMmZHDiv M1ewZ2J0M+vqxh7mVPoBEvw8YQQzcCrNP2js/fKjo4/neAkrMbxlOx7OObOWX36hXYS+ c0fJRvE94s04ZLu+aPFqpBBVb3efZII4CYR8ZfCsh4lHogBHoeY5wm+HCauH3/ZRso8c CmfNOqsocneKmn3PnnBrsiSKIS3BcRGVBO0+rFf0Gcb8ChXwR2C+vxvzDv8hq1wasXw9 12R7/R2tlay0F9a4lZvHA5PBat0J1ENkJh9lA9Naqorhvs9T0BtOMTIDGP6h9ASX7sLT nHxQ== X-Gm-Message-State: ANhLgQ2D2JMYjlZsqS5glWr3+1agivM0pPVH5IPg3TXYWPgf+LiIM5S9 Q7lq+L1goEqAm7eqz/dgQ1I= X-Google-Smtp-Source: ADFU+vtXO8qJ6/LomWoqPFo16aC2m31U0bjGq/5iuPLC69+YRJjCpnuSsVEXZGXdraHuzjQo5VWJNg== X-Received: by 2002:a17:906:50e:: with SMTP id j14mr18523296eja.300.1585732794952; Wed, 01 Apr 2020 02:19:54 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id w4sm393813ejz.44.2020.04.01.02.19.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Apr 2020 02:19:54 -0700 (PDT) Date: Wed, 1 Apr 2020 11:19:52 +0200 From: Krzysztof Kozlowski To: Greg Kroah-Hartman Subject: Re: [PATCH] tty: samsung_tty: 32-bit access for TX/RX hold registers Message-ID: <20200401091952.GA14425@kozik-lap> References: <20200401082721.19431-1-hyunki00.koo@samsung.com> <20200401085548.GC2026666@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200401085548.GC2026666@kroah.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200401_021957_067002_2584463B X-CRM114-Status: GOOD ( 14.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, hyunki00.koo@gmail.com, linux-kernel@vger.kernel.org, Kukjin Kim , Hyunki Koo , linux-serial@vger.kernel.org, Jiri Slaby , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 01, 2020 at 10:55:48AM +0200, Greg Kroah-Hartman wrote: > On Wed, Apr 01, 2020 at 05:27:20PM +0900, Hyunki Koo wrote: > > - if (np) > > + if (np) { > > of_property_read_u32(np, > > "samsung,uart-fifosize", &ourport->port.fifosize); > > > > + if (of_property_read_u32(np, "reg-io-width", &prop) == 0) { > > + switch (prop) { > > + case 1: > > + ourport->port.iotype = UPIO_MEM; > > + break; > > + case 4: > > + ourport->port.iotype = UPIO_MEM32; > > + break; > > + default: > > + dev_warn(&pdev->dev, "unsupported reg-io-width (%d)\n", > > + prop); > > + ret = -EINVAL; > > + break; > > + } > > + } > > + } > > + > > Does this mean that reg-io-width is now a required property for all > samsung uarts? Does this break older dts files? Or should you > fall-back to the previous operation if the attribute is not there? Yes, it looks like silently breaking all boards. Since of_property_read_u32() will return errno, the warning message won't be printed and all register reads will fail (return 0). This looks like not tested on real HW. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel