From: Greg KH <gregkh@linuxfoundation.org>
To: "Schmid, Carsten" <Carsten_Schmid@mentor.com>
Cc: "sashal@kernel.org" <sashal@kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH Backport to stable/linux-4.14.y] make 'user_access_begin()' do 'access_ok()'
Date: Wed, 1 Apr 2020 13:01:00 +0200 [thread overview]
Message-ID: <20200401110100.GA2070530@kroah.com> (raw)
In-Reply-To: <1585737161954.11435@mentor.com>
On Wed, Apr 01, 2020 at 10:32:42AM +0000, Schmid, Carsten wrote:
> >>
> >> Fixes CVE-2018-20669
> >> Backported from v5.0-rc1
> >> Patch 1/1
> >
> > Also, that cve was "supposed" to already be fixed in the 4.19.13 kernel
> > release for some reason, and it's a drm issue, not a core access_ok()
> > issue.
> >
> > So why is this needed for 4.14?
> >
> See https://access.redhat.com/security/cve/cve-2018-20669
> Looks like Linus' fix was attacking this at the root cause, not only for DRM.
And are you _sure_ this really is an issue in 4.14? And in 4.19? There
was some reason I didn't backport this to 4.19 at the time...
> Also, i use https://www.linuxkernelcves.com/ as a research source,
> and they claim that CVE not fixed in 4.19.
That disagrees with the "main" CVE database. Not that I really trust
any of them further than I can throw their servers...
> (and i'll check for the other LTS kernels as well)
Please do.
> >> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> >
> > No s-o-by from you?
> Ops. Will add this in a resend.
>
> >> Want to give this work back to the community, as 4.14 is a SLTS.
> >
> > What is "SLTS"?
> Super Long Term Supported kernel - thanks to guys like you :-)
> 4.14 really is that (Jan. 2024, as of https://www.kernel.org/category/releases.html)
I don't use that term, don't make new things up where they aren't :)
> >
> > thanks,
> >
> > greg k-h
>
> Thanks, and i have some other patches backported to 4.14 as CVE fixes,
> which i'll propose in the next hours.
Make sure that they are really issues, and that they are fixed in all
current trees. I can't take patches for an older stable tree without a
newer one also having it otherwise people would upgrade and suffer a
regression.
thanks,
greg k-h
prev parent reply other threads:[~2020-04-01 11:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 8:49 [PATCH Backport to stable/linux-4.14.y] make 'user_access_begin()' do 'access_ok()' Schmid, Carsten
2020-04-01 9:24 ` Schmid, Carsten
2020-04-01 9:29 ` Greg KH
2020-04-01 9:32 ` Greg KH
[not found] ` <1585735684794.48644@mentor.com>
2020-04-01 10:32 ` AW: " Schmid, Carsten
2020-04-01 11:01 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401110100.GA2070530@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Carsten_Schmid@mentor.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.