All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: "Leonidas S. Barbosa" <kirotawa@gmail.com>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] Removing condition that will never be met after calls xmalloc and xrealloc
Date: Wed, 1 Apr 2020 14:44:46 +0200	[thread overview]
Message-ID: <20200401124446.GD29376@vergenet.net> (raw)
In-Reply-To: <20200303035649.GA726@kexec.lxd>

On Tue, Mar 03, 2020 at 03:56:49AM +0000, Leonidas S. Barbosa wrote:
> Hi,
> 
> Looking in the kexec-tools code I found these conditions that
> seems will never be met. Not sure if that was intentional for explicitity,
> if it was the case, please disconsider this patch.
> 
> 
> 
> 
> xmalloc and xrealloc when fails calls die() that calls exit(1).
> Checks for if(!memory) after they are called will never be met that
> condition, since the process will be exited after an allocation fail.
> 
> Signed-off-by: Leonidas S. Barbosa <kirotawa@gmail.com>

Thanks, applied.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

           reply	other threads:[~2020-04-01 12:44 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20200303035649.GA726@kexec.lxd>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200401124446.GD29376@vergenet.net \
    --to=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=kirotawa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.