Re: [PATCH v1 1/4] pinctrl: intel: Introduce common flags for GPIO mapping scheme

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Wed, Apr 01, 2020 at 12:51:42PM +0300, Mika Westerberg wrote:
> On Tue, Mar 31, 2020 at 06:25:44PM +0300, Andy Shevchenko wrote:
> > Few drivers are using the same flag to tell Intel pin control core
> > how to interpret GPIO base.
> > 
> > Provide a generic flags so all drivers can use.

...

> > - * @gpio_base: Starting GPIO base of this group (%0 if matches with @base,
> > - *	       and %-1 if no GPIO mapping should be created)
> > + * @gpio_base: Starting GPIO base of this group

> > @@ -64,6 +63,8 @@ struct intel_padgroup {
> >  	unsigned int reg_num;
> >  	unsigned int base;
> >  	unsigned int size;
> > +#define INTEL_GPIO_BASE_MATCH	0	/* matches with @base */
> > +#define INTEL_GPIO_BASE_NOMAP	(-1)	/* no GPIO mapping should be created */
> 
> Maybe use enum and add kernel-doc there?
> 
> >  	int gpio_base;

Will do it in v2, thanks!

-- 
With Best Regards,
Andy Shevchenko