From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Suman Anna <s-anna@ti.com>
Cc: bjorn.andersson@linaro.org, ohad@wizery.com,
loic.pallardy@st.com, peng.fan@nxp.com, arnaud.pouliquen@st.com,
fabien.dessenne@st.com, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v2 13/17] remoteproc: Introducting new functions to start and stop an MCU
Date: Wed, 1 Apr 2020 15:55:01 -0600 [thread overview]
Message-ID: <20200401215501.GH17383@xps15> (raw)
In-Reply-To: <1a3ca6eb-df01-6c54-e3ef-dad2f49d1b05@ti.com>
On Tue, Mar 31, 2020 at 04:46:32PM -0500, Suman Anna wrote:
> On 3/31/20 1:08 PM, Suman Anna wrote:
> > Hi Mathieu,
> >
> > On 3/24/20 4:45 PM, Mathieu Poirier wrote:
> >> Add new functions to replace direct calling of rproc->ops->start() and
> >> rproc->ops->stop(). That way different behaviour can be played out
> >> when booting an MCU or synchronising with it.
> >>
> >> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> >> ---
> >> drivers/remoteproc/remoteproc_core.c | 6 +++---
> >> drivers/remoteproc/remoteproc_internal.h | 12 ++++++++++++
> >> 2 files changed, 15 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> >> index 488723fcb142..d3c4d7e6ca25 100644
> >> --- a/drivers/remoteproc/remoteproc_core.c
> >> +++ b/drivers/remoteproc/remoteproc_core.c
> >> @@ -1330,7 +1330,7 @@ static int rproc_start(struct rproc *rproc, const struct firmware *fw)
> >> }
> >>
> >> /* power up the remote processor */
> >> - ret = rproc->ops->start(rproc);
> >> + ret = rproc_start_hw(rproc);
> >> if (ret) {
> >> dev_err(dev, "can't start rproc %s: %d\n", rproc->name, ret);
> >> goto unprepare_subdevices;
> >> @@ -1351,7 +1351,7 @@ static int rproc_start(struct rproc *rproc, const struct firmware *fw)
> >> return 0;
> >>
> >> stop_rproc:
> >> - rproc->ops->stop(rproc);
> >> + rproc_stop_hw(rproc);
> >> unprepare_subdevices:
> >> rproc_unprepare_subdevices(rproc);
> >> reset_table_ptr:
> >> @@ -1485,7 +1485,7 @@ static int rproc_stop(struct rproc *rproc, bool crashed)
> >> rproc->table_ptr = rproc->cached_table;
> >>
> >> /* power off the remote processor */
> >> - ret = rproc->ops->stop(rproc);
> >> + ret = rproc_stop_hw(rproc);
> >> if (ret) {
> >> dev_err(dev, "can't stop rproc: %d\n", ret);
> >> return ret;
> >> diff --git a/drivers/remoteproc/remoteproc_internal.h b/drivers/remoteproc/remoteproc_internal.h
> >> index 5f711ceb97ba..7ca23d46dfd4 100644
> >> --- a/drivers/remoteproc/remoteproc_internal.h
> >> +++ b/drivers/remoteproc/remoteproc_internal.h
> >> @@ -160,4 +160,16 @@ struct resource_table *rproc_find_loaded_rsc_table(struct rproc *rproc,
> >> return NULL;
> >> }
> >>
> >> +static inline int rproc_start_hw(struct rproc *rproc)
> >> +{
> >> + RPROC_OPS_HELPER(start, rproc);
> >> + return -EINVAL;
> >> +}
> >> +
> >> +static inline int rproc_stop_hw(struct rproc *rproc)
> >> +{
> >> + RPROC_OPS_HELPER(stop, rproc);
> >> + return -EINVAL;
> >> +}
> >
> > Since we already have the concept of subdevices, how about we call these
> > rproc_{start/stop}_device?
>
> Actually, does this patch needs to be moved up in the order atleast
> prior to patch 11, may be after patch 9?
Sure, that can be done...
>
> regards
> Suman
>
> >
> >> +
> >> #endif /* REMOTEPROC_INTERNAL_H */
> >>
> >
>
next prev parent reply other threads:[~2020-04-01 21:55 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 21:45 [PATCH v2 00/17] remoteproc: Add support for synchronisation with MCU Mathieu Poirier
2020-03-24 21:45 ` [PATCH v2 01/17] remoteproc: Add new operation and state machine for MCU synchronisation Mathieu Poirier
2020-03-30 22:46 ` Suman Anna
2020-03-30 22:49 ` Suman Anna
2020-04-01 21:53 ` Mathieu Poirier
2020-04-09 21:38 ` Suman Anna
2020-04-09 21:38 ` Suman Anna
2020-03-24 21:45 ` [PATCH v2 02/17] remoteproc: Introduce function rproc_set_mcu_sync_state() Mathieu Poirier
2020-03-30 22:55 ` Suman Anna
2020-03-24 21:45 ` [PATCH v2 03/17] remoteproc: Split firmware name allocation from rproc_alloc() Mathieu Poirier
2020-03-27 11:05 ` Loic PALLARDY
2020-03-30 19:47 ` Suman Anna
2020-04-01 21:58 ` Mathieu Poirier
2020-03-24 21:45 ` [PATCH v2 04/17] remoteproc: Split rproc_ops " Mathieu Poirier
2020-03-30 19:54 ` Suman Anna
2020-03-24 21:45 ` [PATCH v2 05/17] remoteproc: Get rid of tedious error path Mathieu Poirier
2020-03-30 20:31 ` Suman Anna
2020-03-24 21:45 ` [PATCH v2 06/17] remoteproc: Introduce function rproc_alloc_internals() Mathieu Poirier
2020-03-27 11:10 ` Loic PALLARDY
2020-03-30 20:38 ` Suman Anna
2020-04-01 20:29 ` Mathieu Poirier
2020-04-09 21:53 ` Suman Anna
2020-03-30 23:07 ` Mathieu Poirier
2020-03-24 21:45 ` [PATCH v2 07/17] remoteproc: Introduce function rproc_alloc_state_machine() Mathieu Poirier
2020-03-27 13:12 ` Loic PALLARDY
2020-03-30 23:10 ` Suman Anna
2020-04-01 20:41 ` Mathieu Poirier
2020-04-09 18:35 ` Suman Anna
2020-03-30 23:13 ` Mathieu Poirier
2020-03-24 21:45 ` [PATCH v2 08/17] remoteproc: Allocate synchronisation state machine Mathieu Poirier
2020-03-27 13:47 ` Loic PALLARDY
2020-03-30 23:16 ` Mathieu Poirier
2020-03-30 23:20 ` Suman Anna
2020-04-01 20:46 ` Mathieu Poirier
2020-03-24 21:45 ` [PATCH v2 09/17] remoteproc: Call the right core function based on synchronisation state Mathieu Poirier
2020-03-31 15:10 ` Suman Anna
2020-04-02 20:16 ` Mathieu Poirier
2020-04-09 18:48 ` Suman Anna
2020-04-09 18:48 ` Suman Anna
2020-03-24 21:45 ` [PATCH v2 10/17] remoteproc: Decouple firmware load and remoteproc booting Mathieu Poirier
2020-03-31 21:27 ` Suman Anna
2020-03-24 21:45 ` [PATCH v2 11/17] remoteproc: Repurpose function rproc_trigger_auto_boot() Mathieu Poirier
2020-03-31 21:32 ` Suman Anna
2020-03-24 21:45 ` [PATCH v2 12/17] remoteproc: Rename function rproc_fw_boot() Mathieu Poirier
2020-03-31 21:42 ` Suman Anna
2020-03-24 21:45 ` [PATCH v2 13/17] remoteproc: Introducting new functions to start and stop an MCU Mathieu Poirier
2020-03-31 18:08 ` Suman Anna
2020-03-31 21:46 ` Suman Anna
2020-04-01 21:55 ` Mathieu Poirier [this message]
2020-03-24 21:46 ` [PATCH v2 14/17] remoteproc: Refactor function rproc_trigger_recovery() Mathieu Poirier
2020-03-31 21:52 ` Suman Anna
2020-04-02 20:35 ` Mathieu Poirier
2020-04-09 19:02 ` Suman Anna
2020-04-09 19:02 ` Suman Anna
2020-03-24 21:46 ` [PATCH v2 15/17] remoteproc: Correctly deal with MCU synchronisation when changing FW image Mathieu Poirier
2020-03-27 13:50 ` Loic PALLARDY
2020-03-30 23:21 ` Mathieu Poirier
2020-03-31 22:14 ` Suman Anna
2020-04-01 20:55 ` Mathieu Poirier
2020-04-22 21:29 ` Mathieu Poirier
2020-04-22 22:56 ` Suman Anna
2020-03-24 21:46 ` [PATCH v2 16/17] remoteproc: Correctly deal with MCU synchronisation when changing state Mathieu Poirier
2020-03-27 14:04 ` Loic PALLARDY
2020-03-30 23:49 ` Mathieu Poirier
2020-03-31 22:35 ` Suman Anna
2020-04-01 21:29 ` Mathieu Poirier
2020-04-09 20:55 ` Suman Anna
2020-04-02 20:42 ` Mathieu Poirier
2020-04-09 20:40 ` Suman Anna
2020-03-24 21:46 ` [PATCH v2 17/17] remoteproc: Make MCU synchronisation state changes on stop and crashed Mathieu Poirier
2020-03-27 17:20 ` [PATCH v2 00/17] remoteproc: Add support for synchronisation with MCU Loic PALLARDY
2020-03-31 22:51 ` Suman Anna
2020-04-01 21:39 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401215501.GH17383@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=fabien.dessenne@st.com \
--cc=linux-remoteproc@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=ohad@wizery.com \
--cc=peng.fan@nxp.com \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.