From: Kunal Joshi <kunal1.joshi@intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>,
imre.deak@intel.com, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 3/4] tests/kms_chamelium: Issue disabling modeset when resetting state
Date: Thu, 2 Apr 2020 08:58:41 +0530 [thread overview]
Message-ID: <20200402032841.GA13798@intel.com> (raw)
In-Reply-To: <20200331123857.1212432-4-arkadiusz.hiler@intel.com>
On 2020-03-31 at 15:38:56 +0300, Arkadiusz Hiler wrote:
> Each tests resets the state to be sure it starts with a clean slate.
> Let's add disabling modeset to the pile, to be sure that we get the
> hotplug events and the connector state is correct.
>
> Cc: Kunal Joshi <kunal1.joshi@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Issue: https://gitlab.freedesktop.org/drm/intel/issues/323
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> ---
> tests/kms_chamelium.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
> index 08abd961..236e1010 100644
> --- a/tests/kms_chamelium.c
> +++ b/tests/kms_chamelium.c
> @@ -273,7 +273,14 @@ check_analog_bridge(data_t *data, struct chamelium_port *port)
> static void
> reset_state(data_t *data, struct chamelium_port *port)
> {
> - int p;
> + int p, i;
> +
> + for (i = 0; i < data->display.n_outputs; i++) {
> + igt_output_t *output = &data->display.outputs[i];
> + igt_output_set_pipe(output, PIPE_NONE);
> + }
> +
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
>
> chamelium_reset(data->chamelium);
>
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>
> --
> 2.24.1
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-04-02 10:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 12:38 [igt-dev] [PATCH i-g-t 0/4] Chamelium and TypeC Arkadiusz Hiler
2020-03-31 12:38 ` [igt-dev] [PATCH i-g-t 1/4] lib/kms: Commit reasonable defaults on display init Arkadiusz Hiler
2020-03-31 12:38 ` [igt-dev] [PATCH i-g-t 2/4] lib/kms: Reprobe connector state after disabling modest Arkadiusz Hiler
2020-04-02 14:53 ` Imre Deak
2020-03-31 12:38 ` [igt-dev] [PATCH i-g-t 3/4] tests/kms_chamelium: Issue disabling modeset when resetting state Arkadiusz Hiler
2020-04-02 3:28 ` Kunal Joshi [this message]
2020-03-31 12:38 ` [igt-dev] [PATCH i-g-t 4/4] tests/kms_chamelium: Test HPD for different mode handling scenarios Arkadiusz Hiler
2020-04-01 16:29 ` [igt-dev] [PATCH i-g-t v2 " Arkadiusz Hiler
2020-04-02 2:25 ` Kunal Joshi
2020-04-02 9:56 ` Arkadiusz Hiler
2020-04-01 2:23 ` [igt-dev] ✓ Fi.CI.BAT: success for Chamelium and TypeC Patchwork
2020-04-01 17:04 ` [igt-dev] ✓ Fi.CI.BAT: success for Chamelium and TypeC (rev2) Patchwork
2020-04-01 18:17 ` [igt-dev] ✗ Fi.CI.IGT: failure for Chamelium and TypeC Patchwork
2020-04-02 13:00 ` [igt-dev] ✗ Fi.CI.IGT: failure for Chamelium and TypeC (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402032841.GA13798@intel.com \
--to=kunal1.joshi@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=imre.deak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.