From: "Michael S. Tsirkin" <mst@redhat.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: jasowang@redhat.com, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] virtio-balloon: Make virtballoon_free_page_report static
Date: Thu, 2 Apr 2020 09:06:38 -0400 [thread overview]
Message-ID: <20200402090550-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200402024302.35192-1-yuehaibing@huawei.com>
On Thu, Apr 02, 2020 at 10:43:02AM +0800, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/virtio/virtio_balloon.c:168:5: warning:
> symbol 'virtballoon_free_page_report' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
This is for the mm tree right? You need to tag the subject
appropriately and copy the relevant lists.
> ---
> drivers/virtio/virtio_balloon.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index 0ef16566c3f3..bc10f94718e3 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -165,8 +165,9 @@ static void tell_host(struct virtio_balloon *vb, struct virtqueue *vq)
>
> }
>
> +static
> int virtballoon_free_page_report(struct page_reporting_dev_info *pr_dev_info,
> - struct scatterlist *sg, unsigned int nents)
> + struct scatterlist *sg, unsigned int nents)
> {
> struct virtio_balloon *vb =
> container_of(pr_dev_info, struct virtio_balloon, pr_dev_info);
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-04-02 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 2:43 [PATCH -next] virtio-balloon: Make virtballoon_free_page_report static YueHaibing
2020-04-02 2:43 ` YueHaibing
2020-04-02 13:06 ` Michael S. Tsirkin [this message]
2020-04-02 13:27 ` Yuehaibing
2020-04-02 13:27 ` Yuehaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402090550-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.