From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 997D5C10F26 for ; Thu, 2 Apr 2020 09:48:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E9AE2077D for ; Thu, 2 Apr 2020 09:48:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585820894; bh=tQn980VNVD2NF8f3vV6R1mgERuk6VHI+6dEM25XXfqI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KyHYy7phpFyHvLEiSeCMA2PdC0tT7gbmFxEvDoTADWG/RNtEBKtwbRQs1ka68xFHt RSBmV4nqc+CjUVRxdXXXkSCGKZWcYvDVddifUHu2tQUoq/tHybGjhUsmtZRH05Kl/c VQMePdBan9Dy3NtYDme9v9ooKyVyP76VJ5Gcn7ig= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387895AbgDBJsO (ORCPT ); Thu, 2 Apr 2020 05:48:14 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:44705 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbgDBJsO (ORCPT ); Thu, 2 Apr 2020 05:48:14 -0400 Received: by mail-ed1-f67.google.com with SMTP id i16so3301937edy.11; Thu, 02 Apr 2020 02:48:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EebgA10aQonHAdiMTRoJOB7z11b/IU502qlsS+rdf6o=; b=HQjEdUKPZeSEOI8knQyUZQUexZP58MzcnenQuTu7L5Ea9Qsk5uPlEba7VWaq2ybhN+ oXm4P8J+OckTV691brK5BNdpwXDhBjCcr9i7RmifNbb3Y70TmZ7MTxopEguf88kyrrjR BxLG4/J6jIf60XJP6OGBPeld8RwLFbiEUZPDXtMlfRr/3nNmmu7QJjOAM/jU+MTgNK26 3qpCLx4jr0T0ABTIFAV1Bv0JkiXRC80Jyofzct2JuGUJOFBAzxxTJKah9S3xlXWE7IWT wJXiTaaBspvcYlBZl1cD9A/L5dSXtIGNz4hTNAb2QU6dnAt41c7mw82df82vQnMAf853 HOiQ== X-Gm-Message-State: AGi0PubhvGdIxpIvMKbWtpbWQE96Ceegv+wAIIhMnkzDnBxSua9nsUPP r//ieJ2+Y68aXLjL4Hro6O+7EGzi X-Google-Smtp-Source: APiQypIF74oGksjMDueJN1n5kxiy+DMCIipIZolflLnnlWIJFFfGO84ldJuhdl2ALOj87wiqKoQ0fQ== X-Received: by 2002:a17:906:9ca:: with SMTP id r10mr2262131eje.151.1585820891869; Thu, 02 Apr 2020 02:48:11 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id qk2sm1008399ejb.80.2020.04.02.02.48.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Apr 2020 02:48:11 -0700 (PDT) Date: Thu, 2 Apr 2020 11:48:08 +0200 From: 'Krzysztof Kozlowski' To: Hyunki Koo Cc: 'Greg Kroah-Hartman' , hyunki00.koo@gmail.com, 'Kukjin Kim' , 'Jiri Slaby' , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tty: samsung_tty: 32-bit access for TX/RX hold registers Message-ID: <20200402094808.GA21903@kozik-lap> References: <20200401082721.19431-1-hyunki00.koo@samsung.com> <20200401085548.GC2026666@kroah.com> <20200401091952.GA14425@kozik-lap> <000001d608d3$5faa8260$1eff8720$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <000001d608d3$5faa8260$1eff8720$@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Thu, Apr 02, 2020 at 06:44:58PM +0900, Hyunki Koo wrote: > On Wed, Apr 01, 2020 at 6:20:20PM +0900, Krzysztof Kozlowski > wrote: > > On Wed, Apr 01, 2020 at 10:55:48AM +0200, Greg Kroah-Hartman > > wrote: > > > On Wed, Apr 01, 2020 at 05:27:20PM +0900, Hyunki Koo wrote: > > > > - if (np) > > > > + if (np) { > > > > of_property_read_u32(np, > > > > "samsung,uart-fifosize", &ourport->port.fifosize); > > > > > > > > + if (of_property_read_u32(np, "reg-io-width", &prop) == > > 0) { > > > > + switch (prop) { > > > > + case 1: > > > > + ourport->port.iotype = UPIO_MEM; > > > > + break; > > > > + case 4: > > > > + ourport->port.iotype = UPIO_MEM32; > > > > + break; > > > > + default: > > > > + dev_warn(&pdev->dev, "unsupported > > reg-io-width (%d)\n", > > > > + prop); > > > > + ret = -EINVAL; > > > > + break; > > > > + } > > > > + } > > > > + } > > > > + > > > > > > Does this mean that reg-io-width is now a required property for all > > > samsung uarts? Does this break older dts files? Or should you > > > fall-back to the previous operation if the attribute is not there? > > > > Yes, it looks like silently breaking all boards. Since > > of_property_read_u32() will return errno, the warning message won't be > > printed and all register reads will fail (return 0). > > > > This looks like not tested on real HW. > > > > Best regards, > > Krzysztof > > [Hyunki Koo] > reg-io-width =4 is required for Samsung uart > To do not break older dts files, I will set default value in else of of_property_read_u32 like below. > + if (of_property_read_u32(np, "reg-io-width", &prop) == 0) { > + ... > + } else { > + ourport->port.iotype = UPIO_MEM; > + } Thanks. Also, please test your patch on available Exynos boards, e.g. Odroid XU4 or HC1. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75156C10F26 for ; Thu, 2 Apr 2020 09:48:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 433AE2073B for ; Thu, 2 Apr 2020 09:48:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="U9L02bZ+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 433AE2073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gmSiFJdMHzWXbz0L+lTBNo4zzDR6lXUce6ihsZtV5Hs=; b=U9L02bZ+hKpFtC TgE2ps7jFMQQj0fvajodtY7vAPDcQFb3XKYZw8lhxe4e/5XrUoUH93NaQcVoL+rPOBMstozQzUlFf mzLN37jj6aLj4g46Liu2Bf6J4o/KrRnUA1uBbsCVAxr2nNDRLltopR/9uA7cJ/aYDTWPLnqbcVwP8 KTk4p2uVgKmv59KjM4DsPz6xxpiUQ/zZeqxMW2FZ72aL00Q2IN3hVVEWHln5/FDJM28ShA7l3chX0 xX9uhMv28ttiY2Cxla+j9hiNXczU3SbYRBMDowcvwYc+NO4ar4VEx4JZ0TFIxv9mzOA6xCm43JxGc 5GAIjQPFdcgHJKmvIOGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJwSP-0005Xe-LH; Thu, 02 Apr 2020 09:48:17 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJwSM-0005WM-Dh for linux-arm-kernel@lists.infradead.org; Thu, 02 Apr 2020 09:48:15 +0000 Received: by mail-ed1-f65.google.com with SMTP id z65so3387756ede.0 for ; Thu, 02 Apr 2020 02:48:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EebgA10aQonHAdiMTRoJOB7z11b/IU502qlsS+rdf6o=; b=T9pw5amkK+1BtLAeW01A0cN+Avu8qRPBGFm0NPSZX+zwwNQNC8Ouy/YV75ArzfjC4i c7hclc+mhISFK1vjBm6webT1m6SMwBdsKNvAAjISz3eXSTAFAmwENQF1ARXyIudC0Qmw b+SRjCQrpRMSChHh52JyLNTb8ny1oGHIZSWvHj82ZvN/K8/KR76l0uk/fY+21QO5sFI+ cD5zpLd6UYO+RCc4owj0orx5Q56zaeWSUId9kGP+1frUREZ3lM1YaNA5Ksss+sO+5zdt Zg2Km0s/YvMqJgklLtDFZINd0NzsyON73vSokSz7C7D8G2LWg8MF3qrwtMviPSHeUnLw gfZQ== X-Gm-Message-State: AGi0PuYKcfOLeY7M9WObaMGQ71NlQsiHD9skWXN1qGUBidG1/osDpy6x JNo/kLLmDl1KIjMcB9Vz0ks= X-Google-Smtp-Source: APiQypIF74oGksjMDueJN1n5kxiy+DMCIipIZolflLnnlWIJFFfGO84ldJuhdl2ALOj87wiqKoQ0fQ== X-Received: by 2002:a17:906:9ca:: with SMTP id r10mr2262131eje.151.1585820891869; Thu, 02 Apr 2020 02:48:11 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id qk2sm1008399ejb.80.2020.04.02.02.48.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Apr 2020 02:48:11 -0700 (PDT) Date: Thu, 2 Apr 2020 11:48:08 +0200 From: 'Krzysztof Kozlowski' To: Hyunki Koo Subject: Re: [PATCH] tty: samsung_tty: 32-bit access for TX/RX hold registers Message-ID: <20200402094808.GA21903@kozik-lap> References: <20200401082721.19431-1-hyunki00.koo@samsung.com> <20200401085548.GC2026666@kroah.com> <20200401091952.GA14425@kozik-lap> <000001d608d3$5faa8260$1eff8720$@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <000001d608d3$5faa8260$1eff8720$@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200402_024814_461440_8136E5F2 X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, hyunki00.koo@gmail.com, 'Greg Kroah-Hartman' , linux-kernel@vger.kernel.org, 'Kukjin Kim' , linux-serial@vger.kernel.org, 'Jiri Slaby' , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 02, 2020 at 06:44:58PM +0900, Hyunki Koo wrote: > On Wed, Apr 01, 2020 at 6:20:20PM +0900, Krzysztof Kozlowski > wrote: > > On Wed, Apr 01, 2020 at 10:55:48AM +0200, Greg Kroah-Hartman > > wrote: > > > On Wed, Apr 01, 2020 at 05:27:20PM +0900, Hyunki Koo wrote: > > > > - if (np) > > > > + if (np) { > > > > of_property_read_u32(np, > > > > "samsung,uart-fifosize", &ourport->port.fifosize); > > > > > > > > + if (of_property_read_u32(np, "reg-io-width", &prop) == > > 0) { > > > > + switch (prop) { > > > > + case 1: > > > > + ourport->port.iotype = UPIO_MEM; > > > > + break; > > > > + case 4: > > > > + ourport->port.iotype = UPIO_MEM32; > > > > + break; > > > > + default: > > > > + dev_warn(&pdev->dev, "unsupported > > reg-io-width (%d)\n", > > > > + prop); > > > > + ret = -EINVAL; > > > > + break; > > > > + } > > > > + } > > > > + } > > > > + > > > > > > Does this mean that reg-io-width is now a required property for all > > > samsung uarts? Does this break older dts files? Or should you > > > fall-back to the previous operation if the attribute is not there? > > > > Yes, it looks like silently breaking all boards. Since > > of_property_read_u32() will return errno, the warning message won't be > > printed and all register reads will fail (return 0). > > > > This looks like not tested on real HW. > > > > Best regards, > > Krzysztof > > [Hyunki Koo] > reg-io-width =4 is required for Samsung uart > To do not break older dts files, I will set default value in else of of_property_read_u32 like below. > + if (of_property_read_u32(np, "reg-io-width", &prop) == 0) { > + ... > + } else { > + ourport->port.iotype = UPIO_MEM; > + } Thanks. Also, please test your patch on available Exynos boards, e.g. Odroid XU4 or HC1. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel