All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: ceph-devel@vger.kernel.org
Cc: ukernel@gmail.com, idryomov@gmail.com, sage@redhat.com,
	jfajerski@suse.com, lhenriques@suse.com, gfarnum@redhat.com
Subject: [PATCH v2 0/2] ceph: fix long stalls on sync/syncfs
Date: Thu,  2 Apr 2020 07:29:09 -0400	[thread overview]
Message-ID: <20200402112911.17023-1-jlayton@kernel.org> (raw)

This is v2 of the patch I sent the other day to fix the problem of long
stalls when calling sync or syncfs.

This set converts the mdsc->cap_dirty list to a per-session list, and
then has the only caller that looks at cap_dirty walk the list of
sessions and issue flushes for each session in turn.

With this, we can use an empty s_cap_dirty list as an indicator that the
cap flush is the last one going to the session and can mark that one as
one we're waiting on so the MDS can expedite it.

This also attempts to clarify some of the locking around s_cap_dirty,
and adds a FIXME comment to raise the question about locking around
s_cap_flushing.

Jeff Layton (2):
  ceph: convert mdsc->cap_dirty to a per-session list
  ceph: request expedited service on session's last cap flush

 fs/ceph/caps.c       | 72 +++++++++++++++++++++++++++++++++++++++-----
 fs/ceph/mds_client.c |  2 +-
 fs/ceph/mds_client.h |  5 +--
 fs/ceph/super.h      | 21 +++++++++++--
 4 files changed, 87 insertions(+), 13 deletions(-)

-- 
2.25.1

             reply	other threads:[~2020-04-02 11:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02 11:29 Jeff Layton [this message]
2020-04-02 11:29 ` [PATCH v2 1/2] ceph: convert mdsc->cap_dirty to a per-session list Jeff Layton
2020-04-03  3:21   ` Yan, Zheng
2020-04-03 10:45     ` Jeff Layton
2020-04-02 11:29 ` [PATCH v2 2/2] ceph: request expedited service on session's last cap flush Jeff Layton
2020-04-03  3:22   ` Yan, Zheng
2020-04-03 10:23   ` Luis Henriques
2020-04-03 10:37     ` Jeff Layton
2020-04-02 15:54 ` [PATCH v2 0/2] ceph: fix long stalls on sync/syncfs Gregory Farnum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200402112911.17023-1-jlayton@kernel.org \
    --to=jlayton@kernel.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=gfarnum@redhat.com \
    --cc=idryomov@gmail.com \
    --cc=jfajerski@suse.com \
    --cc=lhenriques@suse.com \
    --cc=sage@redhat.com \
    --cc=ukernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.