From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Tang Bin <tangbin@cmss.chinamobile.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
nicolas.ferre@microchip.com, tiwai@suse.com,
ludovic.desroches@microchip.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ALSA:atmel:Use platform_get_irq_optional()
Date: Thu, 2 Apr 2020 13:58:51 +0200 [thread overview]
Message-ID: <20200402115851.GG3683@piout.net> (raw)
In-Reply-To: <20200402112135.18604-1-tangbin@cmss.chinamobile.com>
On 02/04/2020 19:21:35+0800, Tang Bin wrote:
> In order to simply code,because platform_get_irq() already has
> dev_err() message.
>
But what I see is a dev_dbg message so your patch actually changes the
behaviour when debugging is not enabled.
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> sound/atmel/ac97c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index a1dce9725..25cfd5710 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -715,7 +715,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev)
> return -ENXIO;
> }
>
> - irq = platform_get_irq(pdev, 0);
> + irq = platform_get_irq_optional(pdev, 0);
> if (irq < 0) {
> dev_dbg(&pdev->dev, "could not get irq: %d\n", irq);
> return irq;
> --
> 2.20.1.windows.1
>
>
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Tang Bin <tangbin@cmss.chinamobile.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.com, ludovic.desroches@microchip.com, perex@perex.cz,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ALSA:atmel:Use platform_get_irq_optional()
Date: Thu, 2 Apr 2020 13:58:51 +0200 [thread overview]
Message-ID: <20200402115851.GG3683@piout.net> (raw)
In-Reply-To: <20200402112135.18604-1-tangbin@cmss.chinamobile.com>
On 02/04/2020 19:21:35+0800, Tang Bin wrote:
> In order to simply code,because platform_get_irq() already has
> dev_err() message.
>
But what I see is a dev_dbg message so your patch actually changes the
behaviour when debugging is not enabled.
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> sound/atmel/ac97c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index a1dce9725..25cfd5710 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -715,7 +715,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev)
> return -ENXIO;
> }
>
> - irq = platform_get_irq(pdev, 0);
> + irq = platform_get_irq_optional(pdev, 0);
> if (irq < 0) {
> dev_dbg(&pdev->dev, "could not get irq: %d\n", irq);
> return irq;
> --
> 2.20.1.windows.1
>
>
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Tang Bin <tangbin@cmss.chinamobile.com>
Cc: perex@perex.cz, tiwai@suse.com, nicolas.ferre@microchip.com,
ludovic.desroches@microchip.com, alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA:atmel:Use platform_get_irq_optional()
Date: Thu, 2 Apr 2020 13:58:51 +0200 [thread overview]
Message-ID: <20200402115851.GG3683@piout.net> (raw)
In-Reply-To: <20200402112135.18604-1-tangbin@cmss.chinamobile.com>
On 02/04/2020 19:21:35+0800, Tang Bin wrote:
> In order to simply code,because platform_get_irq() already has
> dev_err() message.
>
But what I see is a dev_dbg message so your patch actually changes the
behaviour when debugging is not enabled.
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> sound/atmel/ac97c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index a1dce9725..25cfd5710 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -715,7 +715,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev)
> return -ENXIO;
> }
>
> - irq = platform_get_irq(pdev, 0);
> + irq = platform_get_irq_optional(pdev, 0);
> if (irq < 0) {
> dev_dbg(&pdev->dev, "could not get irq: %d\n", irq);
> return irq;
> --
> 2.20.1.windows.1
>
>
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-04-02 11:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 11:21 [PATCH] ALSA:atmel:Use platform_get_irq_optional() Tang Bin
2020-04-02 11:21 ` Tang Bin
2020-04-02 11:21 ` Tang Bin
2020-04-02 11:58 ` Alexandre Belloni [this message]
2020-04-02 11:58 ` Alexandre Belloni
2020-04-02 11:58 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402115851.GG3683@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=tangbin@cmss.chinamobile.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.