Re: [PATCH] staging: ralink-gdma: Move blank line to fix warning

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Apr 02, 2020 at 01:23:09AM -0700, John B. Wyatt IV wrote:
> Move a blank line within a struct to fix/silence a style warning.
> 
> Reported by checkpatch.
> 
> Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
> ---
> Note:
> ralink-gdma does not build; even with make allyesconfig.
> I did not find a menu option with make menuconfig.
> 
>  drivers/staging/ralink-gdma/ralink-gdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
> index eabf1093328e..9c398048daac 100644
> --- a/drivers/staging/ralink-gdma/ralink-gdma.c
> +++ b/drivers/staging/ralink-gdma/ralink-gdma.c
> @@ -122,9 +122,9 @@ struct gdma_dma_dev {
>  	struct gdma_data *data;
>  	void __iomem *base;
>  	struct tasklet_struct task;
> +
>  	volatile unsigned long chan_issued;
>  	atomic_t cnt;
> -
>  	struct gdma_dmaengine_chan chan[];
>  };

That's a funny style warning, and this patch isn't correct, sorry.

Please see the archives for the many times this has come up.

Remember, checkpatch is just a guide, it's not always right, you always
have to use your brain in considering what it is telling you.

thanks,

greg k-h