All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Add one more rcu_barrier() after draining the ppGTT freelist
Date: Thu, 02 Apr 2020 23:50:07 +0800	[thread overview]
Message-ID: <202004022357.w4wJTFQ4%lkp@intel.com> (raw)
In-Reply-To: <20200402080805.20292-1-chris@chris-wilson.co.uk>

[-- Attachment #1: Type: text/plain, Size: 2409 bytes --]

Hi Chris,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.6 next-20200402]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-gt-Add-one-more-rcu_barrier-after-draining-the-ppGTT-freelist/20200402-204936
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/gt/intel_ggtt.c: In function 'ggtt_cleanup_hw':
>> drivers/gpu/drm/i915/gt/intel_ggtt.c:671:11: error: void value not ignored as it ought to be
     } while (flush_workqueue(ggtt->vm.i915->wq));
              ^~~~~~~~~~~~~~~

vim +671 drivers/gpu/drm/i915/gt/intel_ggtt.c

   662	
   663	static void ggtt_cleanup_hw(struct i915_ggtt *ggtt)
   664	{
   665		struct i915_vma *vma, *vn;
   666	
   667		atomic_set(&ggtt->vm.open, 0);
   668	
   669		do { /* flush the RCU'ed__i915_vm_release */
   670			rcu_barrier();
 > 671		} while (flush_workqueue(ggtt->vm.i915->wq));
   672	
   673		mutex_lock(&ggtt->vm.mutex);
   674	
   675		list_for_each_entry_safe(vma, vn, &ggtt->vm.bound_list, vm_link)
   676			WARN_ON(__i915_vma_unbind(vma));
   677	
   678		if (drm_mm_node_allocated(&ggtt->error_capture))
   679			drm_mm_remove_node(&ggtt->error_capture);
   680		mutex_destroy(&ggtt->error_mutex);
   681	
   682		ggtt_release_guc_top(ggtt);
   683		intel_vgt_deballoon(ggtt);
   684	
   685		ggtt->vm.cleanup(&ggtt->vm);
   686	
   687		mutex_unlock(&ggtt->vm.mutex);
   688		i915_address_space_fini(&ggtt->vm);
   689	
   690		arch_phys_wc_del(ggtt->mtrr);
   691	
   692		if (ggtt->iomap.size)
   693			io_mapping_fini(&ggtt->iomap);
   694	}
   695	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 71706 bytes --]

      parent reply	other threads:[~2020-04-02 15:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02  8:08 [Intel-gfx] [PATCH] drm/i915/gt: Add one more rcu_barrier() after draining the ppGTT freelist Chris Wilson
2020-04-02  8:44 ` Mika Kuoppala
2020-04-02  8:48   ` Chris Wilson
2020-04-02  8:51     ` Chris Wilson
2020-04-02  9:30 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
2020-04-02 15:50 ` kbuild test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202004022357.w4wJTFQ4%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.