From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH] target: tcmu: add missing pr attributes to passthrough backends
Date: Thu, 02 Apr 2020 23:30:37 +0000 [thread overview]
Message-ID: <20200403013037.3da74123@suse.de> (raw)
In-Reply-To: <20200401132153.23501-1-bstroesser@ts.fujitsu.com>
Hi,
On Wed, 1 Apr 2020 15:21:53 +0200, Bodo Stroesser wrote:
> diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
> index ff82b21fdcce..c5a974c5b31d 100644
> --- a/drivers/target/target_core_configfs.c
> +++ b/drivers/target/target_core_configfs.c
> @@ -1203,6 +1203,9 @@ struct configfs_attribute *passthrough_attrib_attrs[] = {
> &attr_hw_block_size,
> &attr_hw_max_sectors,
> &attr_hw_queue_depth,
> + &attr_emulate_pr,
> + &attr_enforce_pr_isids,
> + &attr_force_pr_aptpl,
> &attr_alua_support,
> &attr_pgr_support,
> NULL,
The attr_emulate_pr addition here looks fine. If you and Mike agree to
proceed with the other two attrs then it probably makes sense to add
them via a separate patch.
Cheers, David
next prev parent reply other threads:[~2020-04-02 23:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 13:21 [PATCH] target: tcmu: add missing pr attributes to passthrough backends Bodo Stroesser
2020-04-01 20:05 ` Michael Christie
2020-04-02 14:11 ` Bodo Stroesser
2020-04-02 18:58 ` Michael Christie
2020-04-02 23:30 ` David Disseldorp [this message]
2020-04-03 10:26 ` Bodo Stroesser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403013037.3da74123@suse.de \
--to=ddiss@suse.de \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.