From: Ming Lei <ming.lei@redhat.com>
To: Douglas Anderson <dianders@chromium.org>
Cc: axboe@kernel.dk, jejb@linux.ibm.com, martin.petersen@oracle.com,
paolo.valente@linaro.org, sqazi@google.com,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
groeck@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] blk-mq: In blk_mq_dispatch_rq_list() "no budget" is a reason to kick
Date: Fri, 3 Apr 2020 09:55:16 +0800 [thread overview]
Message-ID: <20200403015516.GC6987@ming.t460p> (raw)
In-Reply-To: <20200402085050.v2.1.I1f95c459e51962b8d2c83e869913b6befda2255c@changeid>
On Thu, Apr 02, 2020 at 08:51:29AM -0700, Douglas Anderson wrote:
> In blk_mq_dispatch_rq_list(), if blk_mq_sched_needs_restart() returns
> true and the driver returns BLK_STS_RESOURCE then we'll kick the
> queue. However, there's another case where we might need to kick it.
> If we were unable to get budget we can be in much the same state as
> when the driver returns BLK_STS_RESOURCE, so we should treat it the
> same.
The situation is really similar, especially the restart handler may
not see the request which may not be added to hctx->dispatch, so
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
Ming
next prev parent reply other threads:[~2020-04-03 1:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 15:51 [PATCH v2 0/2] blk-mq: Fix two causes of IO stalls found in reboot testing Douglas Anderson
2020-04-02 15:51 ` [PATCH v2 1/2] blk-mq: In blk_mq_dispatch_rq_list() "no budget" is a reason to kick Douglas Anderson
2020-04-03 1:55 ` Ming Lei [this message]
2020-04-02 15:51 ` [PATCH v2 2/2] blk-mq: Rerun dispatching in the case of budget contention Douglas Anderson
2020-04-03 1:33 ` Ming Lei
2020-04-03 15:10 ` Doug Anderson
2020-04-03 15:49 ` Doug Anderson
2020-04-05 9:14 ` Ming Lei
2020-04-05 14:00 ` Doug Anderson
2020-04-05 14:57 ` Paolo Valente
2020-04-05 16:16 ` Doug Anderson
2020-04-07 10:43 ` Paolo Valente
2020-04-05 16:26 ` Doug Anderson
2020-04-07 2:14 ` Ming Lei
2020-04-07 22:04 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403015516.GC6987@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=paolo.valente@linaro.org \
--cc=sqazi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.