From: Greg KH <gregkh@linuxfoundation.org>
To: Soumyajit Deb <debsoumyajit100@gmail.com>
Cc: outreachy-kernel@googlegroups.com, sbrivio@redhat.com,
julia.lawall@inria.fr, Larry.Finger@lwfinger.net
Subject: Re: [Outreachy] [PATCH v3 1/3] staging: rtl8188eu: Properly structure the multiline comment
Date: Fri, 3 Apr 2020 09:39:56 +0200 [thread overview]
Message-ID: <20200403073956.GA3466197@kroah.com> (raw)
In-Reply-To: <20200402182621.61694-2-debsoumyajit100@gmail.com>
On Thu, Apr 02, 2020 at 11:56:19PM +0530, Soumyajit Deb wrote:
> Add "*" at the start of each line of the multiline comment to improve
> code readability and to adhere to the uniform Kernel coding style.
> Reported by checkpatch.pl
>
> Signed-off-by: Soumyajit Deb <debsoumyajit100@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_ap.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
> index 93283c7deec4..5b2b4d1d56f6 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_ap.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
> @@ -1226,17 +1226,17 @@ void update_beacon(struct adapter *padapter, u8 ie_id, u8 *oui, u8 tx)
> }
>
> /*
> -op_mode
> -Set to 0 (HT pure) under the following conditions
> - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> -Set to 1 (HT non-member protection) if there may be non-HT STAs
> - in both the primary and the secondary channel
> -Set to 2 if only HT STAs are associated in BSS,
> - however and at least one 20 MHz HT STA is associated
> -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> - (currently non-GF HT station is considered as non-HT STA also)
> -*/
> + *op_mode
> + *Set to 0 (HT pure) under the following conditions
Please add a ' ' character right after the '*' character, to match up
with the proper way to show comment blocks.
thanks,
greg k-h
next prev parent reply other threads:[~2020-04-03 7:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 18:26 [Outreachy] [PATCH v3 0/3] staging: rtl8188eu: Resolve various warnings reported by checkpatch.pl Soumyajit Deb
2020-04-02 18:26 ` [Outreachy] [PATCH v3 1/3] staging: rtl8188eu: Properly structure the multiline comment Soumyajit Deb
2020-04-03 7:39 ` Greg KH [this message]
2020-04-06 9:03 ` Soumyajit Deb
2020-04-02 18:26 ` [Outreachy] [PATCH v3 2/3] staging: rtl8188eu: Remove unnecessary extra parentheses Soumyajit Deb
2020-04-02 18:26 ` [Outreachy] [PATCH v3 3/3] staging: rtl8188eu: Line over 80 characters Soumyajit Deb
2020-04-02 19:20 ` Julia Lawall
2020-04-06 8:55 ` Soumyajit Deb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403073956.GA3466197@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=debsoumyajit100@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=outreachy-kernel@googlegroups.com \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.