From: Igor Mammedov <imammedo@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v2 01/12] move 'typedef Aml' to qemu/types.h
Date: Fri, 3 Apr 2020 11:41:02 +0200 [thread overview]
Message-ID: <20200403114102.383a8e71@redhat.com> (raw)
In-Reply-To: <20200403080502.8154-2-kraxel@redhat.com>
On Fri, 3 Apr 2020 10:04:51 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> include/hw/acpi/aml-build.h | 1 -
> include/qemu/typedefs.h | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index de4a4065682c..1bfe5844e984 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -32,7 +32,6 @@ struct Aml {
> uint8_t op;
> AmlBlockFlags block_flags;
> };
> -typedef struct Aml Aml;
>
> typedef enum {
> AML_COMPATIBILITY = 0,
> diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
> index 375770a80f06..ecf3cde26c3c 100644
> --- a/include/qemu/typedefs.h
> +++ b/include/qemu/typedefs.h
> @@ -24,6 +24,7 @@
> typedef struct AdapterInfo AdapterInfo;
> typedef struct AddressSpace AddressSpace;
> typedef struct AioContext AioContext;
> +typedef struct Aml Aml;
> typedef struct AnnounceTimer AnnounceTimer;
> typedef struct BdrvDirtyBitmap BdrvDirtyBitmap;
> typedef struct BdrvDirtyBitmapIter BdrvDirtyBitmapIter;
next prev parent reply other threads:[~2020-04-03 9:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 8:04 [PATCH v2 00/12] acpi: i386 tweaks Gerd Hoffmann
2020-04-03 8:04 ` [PATCH v2 01/12] move 'typedef Aml' to qemu/types.h Gerd Hoffmann
2020-04-03 9:41 ` Igor Mammedov [this message]
2020-04-03 8:04 ` [PATCH v2 02/12] acpi: add aml builder stubs Gerd Hoffmann
2020-04-03 9:43 ` Igor Mammedov
2020-04-03 8:04 ` [PATCH v2 03/12] acpi: drop pointless _STA method Gerd Hoffmann
2020-04-03 9:45 ` Igor Mammedov
2020-04-03 8:04 ` [PATCH v2 04/12] acpi: serial: don't use " Gerd Hoffmann
2020-04-03 10:00 ` Igor Mammedov
2020-04-06 10:20 ` Gerd Hoffmann
2020-04-03 8:04 ` [PATCH v2 05/12] acpi: parallel: " Gerd Hoffmann
2020-04-03 10:01 ` Igor Mammedov
2020-04-03 8:04 ` [PATCH v2 06/12] acpi: add ISADeviceClass->build_aml() Gerd Hoffmann
2020-04-03 10:05 ` Igor Mammedov
2020-04-06 10:22 ` Igor Mammedov
2020-04-07 10:18 ` Gerd Hoffmann
2020-04-03 8:04 ` [PATCH v2 07/12] acpi: move aml builder code for rtc device Gerd Hoffmann
2020-04-03 10:09 ` Igor Mammedov
2020-04-06 8:25 ` Gerd Hoffmann
2020-04-06 12:17 ` Igor Mammedov
2020-04-07 10:26 ` Gerd Hoffmann
2020-04-08 11:27 ` Igor Mammedov
2020-04-08 12:59 ` Gerd Hoffmann
2020-04-08 20:28 ` Cameron Esfahani via
2020-04-03 8:04 ` [PATCH v2 08/12] acpi: move aml builder code for serial device Gerd Hoffmann
2020-04-03 10:10 ` Igor Mammedov
2020-04-03 8:04 ` [PATCH v2 09/12] acpi: move aml builder code for parallel device Gerd Hoffmann
2020-04-03 10:12 ` Igor Mammedov
2020-04-03 10:16 ` Igor Mammedov
2020-04-06 10:26 ` Gerd Hoffmann
2020-04-06 11:39 ` Paolo Bonzini
2020-04-06 12:14 ` Igor Mammedov
2020-04-03 8:05 ` [PATCH v2 10/12] acpi: move aml builder code for floppy device Gerd Hoffmann
2020-04-03 8:05 ` [PATCH v2 11/12] acpi: move aml builder code for i8042 (kbd+mouse) device Gerd Hoffmann
2020-04-03 8:05 ` [PATCH v2 12/12] acpi: factor out fw_cfg_add_acpi_dsdt() Gerd Hoffmann
2020-04-03 8:50 ` [PATCH v2 00/12] acpi: i386 tweaks no-reply
2020-04-03 9:09 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403114102.383a8e71@redhat.com \
--to=imammedo@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.