From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B2D9C43331 for ; Fri, 3 Apr 2020 12:00:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D4CEF2078C for ; Fri, 3 Apr 2020 12:00:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585915209; bh=hkh5FQklEbWFEOwnlBdvoKUZrHbWYX9RqG5B+tKkr54=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=lpMUv3nHDTOoMtY44AKrBymy33tAvKPV4Is4WK57hAaSS4noUrnU+TDaPKp1eV7rK jy5PCpQusgn5o9xi+O0ILsn6XHaDagByrrntHChq6fjdxF6XPQwOEgORLAA1rvhTag VFN1so6vNDYE8RW9I9fpqrw2lQvTLh8pkiZycreU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403838AbgDCMAI (ORCPT ); Fri, 3 Apr 2020 08:00:08 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:43977 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403836AbgDCMAI (ORCPT ); Fri, 3 Apr 2020 08:00:08 -0400 Received: by mail-ed1-f68.google.com with SMTP id bd14so8928365edb.10; Fri, 03 Apr 2020 05:00:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2wc7UveTdPZFYH0ZRbje1TaqQfrS6AXkhVJ3giRnWQg=; b=ZoO4biaj8ulqOx5ItHluH705aZy4umwVDJRpNVyrAqmAK9b5X8p86SiL8qP17FUBI1 YMgXNkRYZNNSBoEfZkb0Go0VroKleyG7DQrkyRlaD+KQQlwdFXjOORPMc2YPefih7KTf AIFQMAG2roIiapY2d3n2Grs7jn5PG/VyO3r4ss5yIklVbvzyir20VdDFqgCC2hpB7bsQ Au5+2S6raJQzr/2b2FCcf0jPaUnBYNYP/l3OdCCYvNxWMBHq5GReHccQW0kFZoNdq+kG 7k75Zu1M4JIsQgRvEw5cEHKJnejZzAou1cJXH2LLp4tCQo0YYbdSi5ZJFMc4E08R401j jrxg== X-Gm-Message-State: AGi0PuaTzYHdFlkgFrIM1KrLkfFUPOKx+c/ZrWujxFmTJ9aQmsaBDAu2 kvxw1qttX6M60fg+0AuRwC4= X-Google-Smtp-Source: APiQypLIn4dLIkqkA1s1CVJ9ujO0XsacXjWEzmUXeV58UH95EkaFLEmKyju+jLq5Vt5LYBy6dVckcA== X-Received: by 2002:a50:a743:: with SMTP id h61mr7322529edc.84.1585915204852; Fri, 03 Apr 2020 05:00:04 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id p25sm1662881ejw.49.2020.04.03.04.59.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Apr 2020 05:00:04 -0700 (PDT) Date: Fri, 3 Apr 2020 13:59:41 +0200 From: Krzysztof Kozlowski To: Hyunki Koo Cc: gregkh@linuxfoundation.org, Kukjin Kim , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] tty: samsung_tty: 32-bit access for TX/RX hold registers Message-ID: <20200403115941.GB29484@kozik-lap> References: <20200401082721.19431-1-hyunki00.koo@samsung.com> <20200403111511.10598-1-hyunki00.koo@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200403111511.10598-1-hyunki00.koo@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Fri, Apr 03, 2020 at 08:15:10PM +0900, Hyunki Koo wrote: > Support 32-bit access for the TX/RX hold registers UTXH and URXH. > > This is required for some newer SoCs. > > Signed-off-by: Hyunki Koo > --- > v2: > line 954 : change rd_regl to rd_reg in for backward compatibility. I did not see any change around line 954 in v1... so what was it? Rest looks good for me, although you should address Greg's comments. Reviewed-by: Krzysztof Kozlowski Tested on Odroid HC1 (Exynos5422): Tested-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFF3CC43331 for ; Fri, 3 Apr 2020 12:00:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8EC120737 for ; Fri, 3 Apr 2020 12:00:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eTdy5MTp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8EC120737 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yN4ZxZXxYm60iITVKq8YMEafh+NOczkl2k84w7ukN6c=; b=eTdy5MTpiI9GHI 6N0BgyXhza5Y1j0dd09Q8YJGzXEeIOiFEt7vgiQCXx5RdzP5TpufnIdKBFaC06JkfkUzaC5C0ZzQ8 +phjRGlurBt90wHXk0/xqvTUZqpshthj5dE+Xz9Zy2vHoBJi9QjESHGPCMl1OME97tp8C7WjKNyem HF4F63jrRdNi2vZjSvOfmmWNKeQy17S7oiSkLnMKlron0JZQxgzYH26cZ4HfYxRFLOzGxi+WQGYtx af/r+RKEXfi8SzzN5F2sKX/BXSJOdi2icoRCGEJISMOkFX9AKD1w990Fj6KZ9oNlR4BD6dupMggCa qXuvEdRttu6qcuUIR6jg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jKKzZ-000261-TL; Fri, 03 Apr 2020 12:00:09 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jKKzW-00019f-Uq for linux-arm-kernel@lists.infradead.org; Fri, 03 Apr 2020 12:00:08 +0000 Received: by mail-ed1-f68.google.com with SMTP id i16so8905180edy.11 for ; Fri, 03 Apr 2020 05:00:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2wc7UveTdPZFYH0ZRbje1TaqQfrS6AXkhVJ3giRnWQg=; b=cKWN5LdgTIIUfftghGB1ksntKEFFuWyZwIjzUqbloCd13x7kjKkZMhHEK5KJ96Rbdh reBOuaCWIs0oqdvgbqlblt1ziovYTgf8+1DJWhcbSA4ugIBZYTFCyV4IyWR5rG+jMxi6 fIQA7KukaTNBdyDQd5IBoktZg3lGHDI+waVRYDKX/8MiRkJtly2Ry4pm4EezmkjJc0Yj gsV41X4JAxPEf767ysZsYcSGTG2FSYvC4UKAc6ZdCuV14dsbWPXb0m/15GySR1mTGc0B p9Fa4gpsytj8VF7d0Zul/+6BA6oeTmRDQTSOIwQjyIw+AVBmKT68YEtr0FbDDRyLxy97 iU2w== X-Gm-Message-State: AGi0PuYO8bSQaRE3M7lLAKJcLxtxqwezs+LvbWp4roRDkfJPW4AeVfRn +h8RTxzGJMhtCROXSlET4IM= X-Google-Smtp-Source: APiQypLIn4dLIkqkA1s1CVJ9ujO0XsacXjWEzmUXeV58UH95EkaFLEmKyju+jLq5Vt5LYBy6dVckcA== X-Received: by 2002:a50:a743:: with SMTP id h61mr7322529edc.84.1585915204852; Fri, 03 Apr 2020 05:00:04 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id p25sm1662881ejw.49.2020.04.03.04.59.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Apr 2020 05:00:04 -0700 (PDT) Date: Fri, 3 Apr 2020 13:59:41 +0200 From: Krzysztof Kozlowski To: Hyunki Koo Subject: Re: [PATCH v4] tty: samsung_tty: 32-bit access for TX/RX hold registers Message-ID: <20200403115941.GB29484@kozik-lap> References: <20200401082721.19431-1-hyunki00.koo@samsung.com> <20200403111511.10598-1-hyunki00.koo@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200403111511.10598-1-hyunki00.koo@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200403_050007_019499_B7566C0F X-CRM114-Status: GOOD ( 10.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Kukjin Kim , linux-serial@vger.kernel.org, Jiri Slaby , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 03, 2020 at 08:15:10PM +0900, Hyunki Koo wrote: > Support 32-bit access for the TX/RX hold registers UTXH and URXH. > > This is required for some newer SoCs. > > Signed-off-by: Hyunki Koo > --- > v2: > line 954 : change rd_regl to rd_reg in for backward compatibility. I did not see any change around line 954 in v1... so what was it? Rest looks good for me, although you should address Greg's comments. Reviewed-by: Krzysztof Kozlowski Tested on Odroid HC1 (Exynos5422): Tested-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel