From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Fri, 3 Apr 2020 16:25:04 +0300 Subject: [PATCH v3 23/29] acpi: Convert part of acpi_table to use acpi_ctx In-Reply-To: <20200403132406.GI3676135@smile.fi.intel.com> References: <20200330231305.130488-1-sjg@chromium.org> <20200330171226.v3.23.I93e1e33891714417335e1dd517982b18bf9f882f@changeid> <20200403132406.GI3676135@smile.fi.intel.com> Message-ID: <20200403132504.GJ3676135@smile.fi.intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Apr 03, 2020 at 04:24:06PM +0300, Andy Shevchenko wrote: > On Mon, Mar 30, 2020 at 05:12:59PM -0600, Simon Glass wrote: > > The current code uses an address but a pointer would result in fewer > > casts. Also it repeats the alignment code in a lot of places so this would > > be better done in a helper function. > > > > Update write_acpi_tables() to make use of the new acpi_ctx structure, > > adding a few helpers to clean things up. ... > > +void acpi_inc(struct acpi_ctx *ctx, uint amount); > > inc with amount is not inc, it's rather add. ...or pad if you wish. > > > + * acpi_inc_align() - Increment the ACPI output pointer by a bit and align -- With Best Regards, Andy Shevchenko