All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jules Irenge <jbi.octave@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: boqun.feng@gmail.com, Andrew Morton <akpm@linux-foundation.org>,
	Lu Shuaibing <shuaibinglu@126.com>,
	Nathan Chancellor <natechancellor@gmail.com>,
	Manfred Spraul <manfred@colorfullife.com>
Subject: [PATCH 1/5] ipc/msg: Add missing annotation for freeque()
Date: Fri,  3 Apr 2020 17:05:01 +0100	[thread overview]
Message-ID: <20200403160505.2832-2-jbi.octave@gmail.com> (raw)
In-Reply-To: <20200403160505.2832-1-jbi.octave@gmail.com>

Sparse reports a warning at freeque()

warning: context imbalance in freeque() - unexpected unlock

The root cause is the missing annotation at freeque()

Add the missing __releases(RCU) annotation
Add the missing __releases(&msq->q_perm) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 ipc/msg.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ipc/msg.c b/ipc/msg.c
index caca67368cb5..acd1bc7af55a 100644
--- a/ipc/msg.c
+++ b/ipc/msg.c
@@ -268,6 +268,8 @@ static void expunge_all(struct msg_queue *msq, int res,
  * before freeque() is called. msg_ids.rwsem remains locked on exit.
  */
 static void freeque(struct ipc_namespace *ns, struct kern_ipc_perm *ipcp)
+	__releases(RCU)
+	__releases(&msq->q_perm)
 {
 	struct msg_msg *msg, *t;
 	struct msg_queue *msq = container_of(ipcp, struct msg_queue, q_perm);
-- 
2.24.1


  reply	other threads:[~2020-04-03 16:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0/5>
2020-04-03 16:05 ` [PATCH 0/5] lock warnings cleanup Jules Irenge
2020-04-03 16:05   ` Jules Irenge [this message]
2020-04-03 16:05   ` [PATCH 2/5] video: Add missing annotation for cyber2000fb_enable_ddc() and cyber2000fb_disable_ddc() Jules Irenge
2020-04-03 16:05     ` Jules Irenge
2020-04-03 16:05     ` Jules Irenge
2020-04-03 16:05     ` Jules Irenge
2020-04-07 19:48     ` [PATCH 2/5] video: Add missing annotation for cyber2000fb_enable_ddc() and cyber2000fb_disable_d Sam Ravnborg
2020-04-07 19:48       ` [PATCH 2/5] video: Add missing annotation for cyber2000fb_enable_ddc() and cyber2000fb_disable_ddc() Sam Ravnborg
2020-04-07 19:48       ` Sam Ravnborg
2020-04-07 19:48       ` Sam Ravnborg
2020-04-03 16:05   ` [Ocfs2-devel] [PATCH 3/5] ocfs2: Add missing annotation for dlm_empty_lockres() Jules Irenge
2020-04-03 16:05     ` Jules Irenge
2020-04-03 23:45     ` [Ocfs2-devel] " Joseph Qi
2020-04-03 23:45       ` Joseph Qi
2020-04-16  3:02       ` [Ocfs2-devel] " Andrew Morton
2020-04-16  3:02         ` Andrew Morton
2020-04-03 16:05   ` [PATCH 4/5] libata: Add missing annotation for ata_scsi_rbuf_get() and ata_scsi_rbuf_fill() Jules Irenge
2020-04-03 16:05   ` [PATCH 5/5] ipmi: Add missing annotation for ipmi_ssif_lock_cond() and ipmi_ssif_unlock_cond() Jules Irenge
2020-04-03 18:35     ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200403160505.2832-2-jbi.octave@gmail.com \
    --to=jbi.octave@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=boqun.feng@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=natechancellor@gmail.com \
    --cc=shuaibinglu@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.