All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Shivaprasad G Bhat" <sbhat@linux.ibm.com>,
	"Alexey Kardashevskiy" <aik@ozlabs.ru>,
	"Greg Kurz" <groug@kaod.org>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	qemu-ppc <qemu-ppc@nongnu.org>, "Cédric Le Goater" <clg@kaod.org>,
	"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] nvdimm-utils: clean up headers and add license comment
Date: Fri, 3 Apr 2020 16:12:59 +0200	[thread overview]
Message-ID: <20200403161259.6af638b7@redhat.com> (raw)
In-Reply-To: <CAFEAcA_cyK+1+BjYqVB+nu70jiShx861NM=W0ezp_8g5eV6qcw@mail.gmail.com>

On Fri, 3 Apr 2020 15:06:14 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:

> On Fri, 3 Apr 2020 at 15:00, Igor Mammedov <imammedo@redhat.com> wrote:
> >
> > Fixes: 3f350f6bb36233be50fc2bc18dc78b6a948a5dbe
> > Reported-by: Peter Maydell <peter.maydell@linaro.org>
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> >  include/qemu/nvdimm-utils.h |  2 --
> >  util/nvdimm-utils.c         | 29 +++++++++++++++++++++++++++++
> >  2 files changed, 29 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/qemu/nvdimm-utils.h b/include/qemu/nvdimm-utils.h
> > index 4b8b198ba7..1f1dae477f 100644
> > --- a/include/qemu/nvdimm-utils.h
> > +++ b/include/qemu/nvdimm-utils.h
> > @@ -1,7 +1,5 @@
> >  #ifndef NVDIMM_UTILS_H
> >  #define NVDIMM_UTILS_H
> >  
> 
> .h file still missing the copyright-n-license comment ?
do we have to add that for headers as well?

> 
> > -#include "qemu/osdep.h"
> > -
> >  GSList *nvdimm_get_device_list(void);
> >  #endif
> > diff --git a/util/nvdimm-utils.c b/util/nvdimm-utils.c
> > index 5cc768ca47..ca41d39af5 100644
> > --- a/util/nvdimm-utils.c
> > +++ b/util/nvdimm-utils.c
> > @@ -1,3 +1,32 @@
> > +/*
> > + * NVDIMM utilities
> > + *
> > + * Copyright(C) 2015 Intel Corporation.
> > + *
> > + * Author:
> > + *  Xiao Guangrong <guangrong.xiao@linux.intel.com>
> > + *
> > + * NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT)
> > + * and the DSM specification can be found at:
> > + *       http://pmem.io/documents/NVDIMM_DSM_Interface_Example.pdf
> > + *
> > + * Currently, it only supports PMEM Virtualization.
> > + *
> > + * This library is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU Lesser General Public
> > + * License as published by the Free Software Foundation; either
> > + * version 2 of the License, or (at your option) any later version.  
> 
> I guess you copied this from somewhere else, but commit b7cbb8741b40b7c
> suggests that "Lesser General Public License version 2" is
> wrong and it should either be "Library General Public License
> version 2" or "Lesser General Public License version 2.1"...we
> might as well get it right when we're adding a new file, so
> I would suggest you want 2.1 here.

it's copied from the source file this code was moved from.

> 
> > + *
> > + * This library is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> > + * Lesser General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU Lesser General Public
> > + * License along with this library; if not, see <http://www.gnu.org/licenses/>
> > + */
> > +
> > +#include "qemu/osdep.h"
> >  #include "qemu/nvdimm-utils.h"
> >  #include "hw/mem/nvdimm.h"
> >
> > --
> > 2.18.1
> >  
> 
> 
> thanks
> -- PMM
> 



  reply	other threads:[~2020-04-03 14:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-03 14:00 [PATCH] nvdimm-utils: clean up headers and add license comment Igor Mammedov
2020-04-03 14:06 ` Peter Maydell
2020-04-03 14:12   ` Igor Mammedov [this message]
2020-04-03 14:14     ` Peter Maydell
2020-04-03 22:05 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200403161259.6af638b7@redhat.com \
    --to=imammedo@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=lvivier@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=sbhat@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.