From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E559C43331 for ; Fri, 3 Apr 2020 17:18:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B384206F5 for ; Fri, 3 Apr 2020 17:18:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OrR7ulO7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404164AbgDCRSW (ORCPT ); Fri, 3 Apr 2020 13:18:22 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:43321 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403824AbgDCRSW (ORCPT ); Fri, 3 Apr 2020 13:18:22 -0400 Received: by mail-pl1-f194.google.com with SMTP id v23so2941296ply.10 for ; Fri, 03 Apr 2020 10:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rNydFgIXCSgJ49gDNlW+t8MZPAxnkdmyTdnJc8LVEbc=; b=OrR7ulO7CQcgKwh4Z0ptkVpD+g4IWz0YSQouVgIJkq8zylNmdM9VjUkYCI+zVEXHq1 lrjk0v+SzzklSA+3mXp5BODy0jlzOmVXnhkQZrA5LosYzEJPjTc+DVjL3q19L6W2p/2Y GSb8p2z3ej4vxJWgTaITIQwIo7RZ5qCAjuCHg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rNydFgIXCSgJ49gDNlW+t8MZPAxnkdmyTdnJc8LVEbc=; b=VmloNtECRPtK7rVkCbS0+2lK9BbOS6Eb/aBnA2GFQXBtupc1gIZZ07LVeJNIORDk20 NxJ1kOKNAGQePCwnu+hrzjgztg4KebsYFdblXuxt1P39wZj5fSiiDOQptrI5TRxUxIjl c9ajheR1CoV4ImGo7l5dxHhteiRlVwhzUEKQzTE+xbjwf+b1g7peIUf5PcpDV1NsqHI2 VGbBmT26446u03+ifzg4NiaW7gHcBfIGXzu7qXe2/iK4sx2aJUI2M78WRI4Ww7COnzPB VHyOV+vaLYSK5iJvmu/yF215K0EZUkYgwRP5vFTBsrNqTRO8+diJ98oIrIgb69OGwe+q nLuw== X-Gm-Message-State: AGi0PuYWyFd4570so7p+lk0x9E7YwOV44qNZQ/3K2ncbtIzIW4GjRsmS jF2yXQxjeQJtQmq2VAw2PNBGUQjAnSA= X-Google-Smtp-Source: APiQypKQpzA+XTDciIpGBBtkz7UQo2nLfVOgWlxENb8GSyeAvVRwH6+mhz6UsIGNuBo3cdO/izbarA== X-Received: by 2002:a17:90a:20ad:: with SMTP id f42mr10684986pjg.135.1585934301262; Fri, 03 Apr 2020 10:18:21 -0700 (PDT) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id 13sm6219335pfn.131.2020.04.03.10.18.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 10:18:20 -0700 (PDT) Date: Fri, 3 Apr 2020 10:18:18 -0700 From: Matthias Kaehlcke To: Daniel Lezcano Cc: Lukasz Luba , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, Morten.Rasmussen@arm.com, Dietmar.Eggemann@arm.com, javi.merino@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, qperret@google.com, bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, khilman@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, robh@kernel.org, matthias.bgg@gmail.com, steven.price@arm.com, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch, liviu.dudau@arm.com, lorenzo.pieralisi@arm.com, patrick.bellasi@matbug.net, orjan.eide@arm.com, rdunlap@infradead.org Subject: Re: [PATCH v5 3/5] thermal: devfreq_cooling: Use PM QoS to set frequency limits Message-ID: <20200403171818.GO199755@google.com> References: <20200318114548.19916-1-lukasz.luba@arm.com> <20200318114548.19916-4-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Daniel, On Fri, Apr 03, 2020 at 06:43:20PM +0200, Daniel Lezcano wrote: > On 18/03/2020 12:45, Lukasz Luba wrote: > > From: Matthias Kaehlcke > > > > Now that devfreq supports limiting the frequency range of a device > > through PM QoS make use of it instead of disabling OPPs that should > > not be used. > > > > The switch from disabling OPPs to PM QoS introduces a subtle behavioral > > change in case of conflicting requests (min > max): PM QoS gives > > precedence to the MIN_FREQUENCY request, while higher OPPs disabled > > with dev_pm_opp_disable() would override MIN_FREQUENCY. > > > > Signed-off-by: Matthias Kaehlcke > > Reviewed-by: Lukasz Luba > > Reviewed-by: Chanwoo Choi > > This patch is standalone, right? If yes, I will apply it. Yes, it is standalone, please apply Thanks Matthias From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0AD8C43331 for ; Fri, 3 Apr 2020 17:18:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 816E32073B for ; Fri, 3 Apr 2020 17:18:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ijqjbc7p"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OrR7ulO7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 816E32073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4Nhg3G4l9X2XIbAzxlfIt+pBitCK6zz1ppMfHTQEiHk=; b=ijqjbc7pyIxCfn OCUHPfKRM+by9fl9MPyljLhKaSk5DYDHdnEp8M0mxtXnhPR0N2hT8h6xmarY2gpe02yCSMqgGO5U1 1pEJnHOSTKGS3E3JV47Y74zgoRoXli5GpvH9dPNkxRNuDNqxBYuL5R+z6RWSpyrxWRn0oe/sIXFrG lNk7q2GbQVzfu79LS6gPY3Tl1X2AHSrSY0EH7fBexc63oLWMa/LVSmt/Em9igzXdB+BDXuJj0fbb7 Os1C2ZZFvdY7JpaSU3/Rznp+rUqseK0bjPdFNTtySF6bAbgdV5CPKKoCHoEkbpWX1yuOFRcWHAyws HvmXj3S6YTMF1Oipv4TQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jKPxY-0002y6-Td; Fri, 03 Apr 2020 17:18:24 +0000 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jKPxW-0002xQ-Gs for linux-mediatek@lists.infradead.org; Fri, 03 Apr 2020 17:18:23 +0000 Received: by mail-pj1-x1044.google.com with SMTP id g9so3240156pjp.0 for ; Fri, 03 Apr 2020 10:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rNydFgIXCSgJ49gDNlW+t8MZPAxnkdmyTdnJc8LVEbc=; b=OrR7ulO7CQcgKwh4Z0ptkVpD+g4IWz0YSQouVgIJkq8zylNmdM9VjUkYCI+zVEXHq1 lrjk0v+SzzklSA+3mXp5BODy0jlzOmVXnhkQZrA5LosYzEJPjTc+DVjL3q19L6W2p/2Y GSb8p2z3ej4vxJWgTaITIQwIo7RZ5qCAjuCHg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rNydFgIXCSgJ49gDNlW+t8MZPAxnkdmyTdnJc8LVEbc=; b=G/V9YEICSw41lEiWLo2zT5qIsQ7yHAl2mKcj7icyPCzoK4xS3wU6i3ZAbhobv1aMWV OjKdSOLP0iW7TxUIFzI8fGUdjn3n4FBMV0z2pZoonYb+ePhByvsDuP68Q0A065M2l7rU C/DNr/yI4MOfKhbz+jkJ5bptN2+oEnO2Ul/n5p85bddsypnyoPMfasvSHHH67V+BUlDr UYZ4UfR/8H245rybLNtwW7rhA54QTUbeRM2Hp4LRUDS2rfqX1+MKo08TUPpV3+oirzVH dqLkVUxys6ln5dgfJya7hX7P95ZKNUGEkQ4ZwQ3R+fv0HQwLffmHqkbHnZwkkP1rwfCV QUrg== X-Gm-Message-State: AGi0PuYncGBm6qmKR9zRRQwxKrBYR63cBGCqhMPWqWVxsypBdnaFzuT+ CyM9tvkVLY9Um8kREojaAHuaaA== X-Google-Smtp-Source: APiQypKQpzA+XTDciIpGBBtkz7UQo2nLfVOgWlxENb8GSyeAvVRwH6+mhz6UsIGNuBo3cdO/izbarA== X-Received: by 2002:a17:90a:20ad:: with SMTP id f42mr10684986pjg.135.1585934301262; Fri, 03 Apr 2020 10:18:21 -0700 (PDT) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id 13sm6219335pfn.131.2020.04.03.10.18.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 10:18:20 -0700 (PDT) Date: Fri, 3 Apr 2020 10:18:18 -0700 From: Matthias Kaehlcke To: Daniel Lezcano Subject: Re: [PATCH v5 3/5] thermal: devfreq_cooling: Use PM QoS to set frequency limits Message-ID: <20200403171818.GO199755@google.com> References: <20200318114548.19916-1-lukasz.luba@arm.com> <20200318114548.19916-4-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200403_101822_583243_5F4FD02A X-CRM114-Status: GOOD ( 11.66 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, vincent.guittot@linaro.org, khilman@kernel.org, agross@kernel.org, b.zolnierkie@samsung.com, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, orjan.eide@arm.com, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-omap@vger.kernel.org, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, qperret@google.com, sboyd@kernel.org, rdunlap@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org, Lukasz Luba Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Daniel, On Fri, Apr 03, 2020 at 06:43:20PM +0200, Daniel Lezcano wrote: > On 18/03/2020 12:45, Lukasz Luba wrote: > > From: Matthias Kaehlcke > > > > Now that devfreq supports limiting the frequency range of a device > > through PM QoS make use of it instead of disabling OPPs that should > > not be used. > > > > The switch from disabling OPPs to PM QoS introduces a subtle behavioral > > change in case of conflicting requests (min > max): PM QoS gives > > precedence to the MIN_FREQUENCY request, while higher OPPs disabled > > with dev_pm_opp_disable() would override MIN_FREQUENCY. > > > > Signed-off-by: Matthias Kaehlcke > > Reviewed-by: Lukasz Luba > > Reviewed-by: Chanwoo Choi > > This patch is standalone, right? If yes, I will apply it. Yes, it is standalone, please apply Thanks Matthias _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 187A4C43331 for ; Fri, 3 Apr 2020 17:18:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AAB2E2073B for ; Fri, 3 Apr 2020 17:18:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MbmWhUAi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OrR7ulO7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAB2E2073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SlesVQs4fGktwxOnOyPc69iuJz0V/RDB5wxCkz7su8M=; b=MbmWhUAiJ0v3K0 C4I8xtSDwyDtV/OLlSSupgKErXe4q/ekhNXPaLxESHR40phGxmrPHEqFeVXRnlPoc0Ucl0TYtMD/n o89X+vJigJqtJH1wcyk4lEflv9DG9JnFQksh5ZUE4QjDu96ru7fPKjmxl+x2+2t4Pe0TB7svmReNJ S3wu6zG2vXBH1fiJsyd51YDSYW7aQlJ5Tsg7cnAnB9DVjowplmOKRuYpqt6df20hQFjRnrDN0OHCx GzF0MXwjzI8nqKZkZ6AsaCXcOwRkoFUu6uxk6tmpcqSsk0VH66oncRO0g3E1gUKsZc+m88wiGJoAd ekYnUwtIG7OaG9R9noHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jKPxZ-0002z1-St; Fri, 03 Apr 2020 17:18:25 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jKPxW-0002xR-LK for linux-arm-kernel@lists.infradead.org; Fri, 03 Apr 2020 17:18:23 +0000 Received: by mail-pl1-x641.google.com with SMTP id s23so2932891plq.13 for ; Fri, 03 Apr 2020 10:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rNydFgIXCSgJ49gDNlW+t8MZPAxnkdmyTdnJc8LVEbc=; b=OrR7ulO7CQcgKwh4Z0ptkVpD+g4IWz0YSQouVgIJkq8zylNmdM9VjUkYCI+zVEXHq1 lrjk0v+SzzklSA+3mXp5BODy0jlzOmVXnhkQZrA5LosYzEJPjTc+DVjL3q19L6W2p/2Y GSb8p2z3ej4vxJWgTaITIQwIo7RZ5qCAjuCHg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rNydFgIXCSgJ49gDNlW+t8MZPAxnkdmyTdnJc8LVEbc=; b=LPQpwLDWa+zjsfRX136OBzJxY4mt0dJfz8NndWrHWTcAKqjEWeyXYe1VswEAtqy1cI BohA3h4sy9ucVeJTpd0VdpukPPWc58jroGPRtBIWo195l8cDqBobfdhR4IDMWaPQ/pbv AltDTND+QQx2sB9GnbIqqdGvuTybyx+KhPAPMTREIWc6IuMXvMMCtUa2IFTUPd2iNmlh 8gjBdiDO2/6+lzhH1iuX/oEpimnOQ6uxBXUSWg/Hf+/SZOMDXn9/hek7gGSbNWH0oxH3 cy1V65Y08TNUZFsk3mBgxranADiEQ5V7fNPJrIudB8GGIrZ70gFhjATdBZdQrrsh8V6k Ep7w== X-Gm-Message-State: AGi0PuY6vXLrLLRMr3mqQhDIl9/B8qsQbR2dGshfQLYBgZP+fS89sgTU Mn6+3Yq29gUMkoODlvvI27OSFg== X-Google-Smtp-Source: APiQypKQpzA+XTDciIpGBBtkz7UQo2nLfVOgWlxENb8GSyeAvVRwH6+mhz6UsIGNuBo3cdO/izbarA== X-Received: by 2002:a17:90a:20ad:: with SMTP id f42mr10684986pjg.135.1585934301262; Fri, 03 Apr 2020 10:18:21 -0700 (PDT) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id 13sm6219335pfn.131.2020.04.03.10.18.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 10:18:20 -0700 (PDT) Date: Fri, 3 Apr 2020 10:18:18 -0700 From: Matthias Kaehlcke To: Daniel Lezcano Subject: Re: [PATCH v5 3/5] thermal: devfreq_cooling: Use PM QoS to set frequency limits Message-ID: <20200403171818.GO199755@google.com> References: <20200318114548.19916-1-lukasz.luba@arm.com> <20200318114548.19916-4-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200403_101822_701815_D71F4A15 X-CRM114-Status: GOOD ( 13.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, khilman@kernel.org, agross@kernel.org, b.zolnierkie@samsung.com, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, orjan.eide@arm.com, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-omap@vger.kernel.org, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, qperret@google.com, sboyd@kernel.org, rdunlap@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org, Lukasz Luba Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Daniel, On Fri, Apr 03, 2020 at 06:43:20PM +0200, Daniel Lezcano wrote: > On 18/03/2020 12:45, Lukasz Luba wrote: > > From: Matthias Kaehlcke > > > > Now that devfreq supports limiting the frequency range of a device > > through PM QoS make use of it instead of disabling OPPs that should > > not be used. > > > > The switch from disabling OPPs to PM QoS introduces a subtle behavioral > > change in case of conflicting requests (min > max): PM QoS gives > > precedence to the MIN_FREQUENCY request, while higher OPPs disabled > > with dev_pm_opp_disable() would override MIN_FREQUENCY. > > > > Signed-off-by: Matthias Kaehlcke > > Reviewed-by: Lukasz Luba > > Reviewed-by: Chanwoo Choi > > This patch is standalone, right? If yes, I will apply it. Yes, it is standalone, please apply Thanks Matthias _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E306FC2BA12 for ; Fri, 3 Apr 2020 17:18:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A9502080C for ; Fri, 3 Apr 2020 17:18:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OrR7ulO7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A9502080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F1CA36EC33; Fri, 3 Apr 2020 17:18:22 +0000 (UTC) Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by gabe.freedesktop.org (Postfix) with ESMTPS id B676B6EC33 for ; Fri, 3 Apr 2020 17:18:21 +0000 (UTC) Received: by mail-pj1-x1041.google.com with SMTP id m15so3228466pje.3 for ; Fri, 03 Apr 2020 10:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rNydFgIXCSgJ49gDNlW+t8MZPAxnkdmyTdnJc8LVEbc=; b=OrR7ulO7CQcgKwh4Z0ptkVpD+g4IWz0YSQouVgIJkq8zylNmdM9VjUkYCI+zVEXHq1 lrjk0v+SzzklSA+3mXp5BODy0jlzOmVXnhkQZrA5LosYzEJPjTc+DVjL3q19L6W2p/2Y GSb8p2z3ej4vxJWgTaITIQwIo7RZ5qCAjuCHg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rNydFgIXCSgJ49gDNlW+t8MZPAxnkdmyTdnJc8LVEbc=; b=hWOBGujxQqIf549j8e2mTF4ujm5OUAIAGf2o2smgjgmx4JBJMHYdUGh8GScsfMvIk/ SajdaEoMh1kH/BkVEJGolHfKlY5/akKBhR7hzfXmyQbxYOkgOPDBbOtdC20obVN0syoc 7KhOak+5/iQ2SYfl3oTerx1LkCr58MnuPjYXAORtq4pxQNOy/naDA3/SU4v1gHCwUcCI q+Jnu93WqLkgJM5PYIzHv+Y+u6Y2MtNOsfweBkeYYiaIfnRgTs7mj7Am8a8lP89k1FG4 IkoDAertI6cbySlb4laKoG2ys1SryQSWkocz3/7gZct7bYYyRF45U9G84rglGEOXDu30 /pHw== X-Gm-Message-State: AGi0PuaDPjsrS/4ZHzLfAh73J5o5KhM//FZAHvvelOR/1Sbv+vAyRyPc istMZ1m/B21oArKOB19HttU3Cg== X-Google-Smtp-Source: APiQypKQpzA+XTDciIpGBBtkz7UQo2nLfVOgWlxENb8GSyeAvVRwH6+mhz6UsIGNuBo3cdO/izbarA== X-Received: by 2002:a17:90a:20ad:: with SMTP id f42mr10684986pjg.135.1585934301262; Fri, 03 Apr 2020 10:18:21 -0700 (PDT) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id 13sm6219335pfn.131.2020.04.03.10.18.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 10:18:20 -0700 (PDT) Date: Fri, 3 Apr 2020 10:18:18 -0700 From: Matthias Kaehlcke To: Daniel Lezcano Subject: Re: [PATCH v5 3/5] thermal: devfreq_cooling: Use PM QoS to set frequency limits Message-ID: <20200403171818.GO199755@google.com> References: <20200318114548.19916-1-lukasz.luba@arm.com> <20200318114548.19916-4-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, Morten.Rasmussen@arm.com, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, vincent.guittot@linaro.org, khilman@kernel.org, agross@kernel.org, b.zolnierkie@samsung.com, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, orjan.eide@arm.com, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-omap@vger.kernel.org, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, qperret@google.com, sboyd@kernel.org, rdunlap@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org, Lukasz Luba Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Daniel, On Fri, Apr 03, 2020 at 06:43:20PM +0200, Daniel Lezcano wrote: > On 18/03/2020 12:45, Lukasz Luba wrote: > > From: Matthias Kaehlcke > > > > Now that devfreq supports limiting the frequency range of a device > > through PM QoS make use of it instead of disabling OPPs that should > > not be used. > > > > The switch from disabling OPPs to PM QoS introduces a subtle behavioral > > change in case of conflicting requests (min > max): PM QoS gives > > precedence to the MIN_FREQUENCY request, while higher OPPs disabled > > with dev_pm_opp_disable() would override MIN_FREQUENCY. > > > > Signed-off-by: Matthias Kaehlcke > > Reviewed-by: Lukasz Luba > > Reviewed-by: Chanwoo Choi > > This patch is standalone, right? If yes, I will apply it. Yes, it is standalone, please apply Thanks Matthias _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel