All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Alexandre Chartre <alexandre.chartre@oracle.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	jthierry@redhat.com, tglx@linutronix.de
Subject: Re: [PATCH 5/7] x86/speculation: Annotate intra-function calls
Date: Fri, 3 Apr 2020 20:20:05 +0200	[thread overview]
Message-ID: <20200403182005.GC20730@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200403172408.odvcsymwlyx6ises@treble>

On Fri, Apr 03, 2020 at 12:24:08PM -0500, Josh Poimboeuf wrote:
> On Fri, Apr 03, 2020 at 07:18:36PM +0200, Peter Zijlstra wrote:
> > What we need in this case though is only a different stack layout inside
> > the alternative, and that is doable.
> 
> I'm not sure what you mean... any stack changes within the alternative
> have to match exactly the stack changes at the same offsets of the
> original code because ORC doesn't know the difference between the two.

I mean that the ORC entries on either side of the alternative have to be
invariant wrt the specific alternative chosen, but that -- provded you
whip up that ORC alternative stuff -- stack layout inside of an
alternative could possibly be different.

  reply	other threads:[~2020-04-03 18:20 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02  8:22 [PATCH 0/7] objtool changes to remove most ANNOTATE_NOSPEC_ALTERNATIVE Alexandre Chartre
2020-04-02  8:22 ` [PATCH 1/7] objtool: is_fentry_call() crashes if call has no destination Alexandre Chartre
2020-04-02  8:22 ` [PATCH 2/7] objtool: Allow branches within the same alternative Alexandre Chartre
2020-04-02 12:03   ` Julien Thierry
2020-04-02 12:38     ` Alexandre Chartre
2020-04-02  8:22 ` [PATCH 3/7] objtool: Add support for intra-function calls Alexandre Chartre
2020-04-02 12:53   ` Julien Thierry
2020-04-02 13:24     ` Alexandre Chartre
2020-04-02 13:38       ` Julien Thierry
2020-04-02 14:56         ` Alexandre Chartre
2020-04-02 15:04       ` Peter Zijlstra
2020-04-02 15:54         ` Josh Poimboeuf
2020-04-03  7:06           ` Alexandre Chartre
2020-04-02 15:49     ` Josh Poimboeuf
2020-04-02 17:27       ` Josh Poimboeuf
2020-04-03  8:01       ` Julien Thierry
2020-04-03 12:41         ` Peter Zijlstra
2020-04-03 12:49           ` Julien Thierry
2020-04-03 14:37             ` Peter Zijlstra
2020-04-03 14:44         ` Josh Poimboeuf
2020-04-02  8:22 ` [PATCH 4/7] objtool: Add support for return trampoline call Alexandre Chartre
2020-04-02 13:26   ` Julien Thierry
2020-04-02 14:46     ` Alexandre Chartre
2020-04-02 15:31       ` Julien Thierry
2020-04-02 15:40         ` Peter Zijlstra
2020-04-03  8:11           ` Julien Thierry
2020-04-03 15:17             ` Josh Poimboeuf
2020-04-03 15:22               ` Josh Poimboeuf
2020-04-03 15:32                 ` Josh Poimboeuf
2020-04-03 15:46               ` Peter Zijlstra
2020-04-03 15:55                 ` Josh Poimboeuf
2020-04-04 13:32                 ` Peter Zijlstra
2020-04-04 14:22                   ` Josh Poimboeuf
2020-04-04 15:51                     ` Peter Zijlstra
2020-04-06  8:19                       ` Alexandre Chartre
2020-04-06  9:31                         ` Peter Zijlstra
2020-04-06 11:03                           ` Alexandre Chartre
2020-04-06 14:16                       ` Josh Poimboeuf
2020-04-02 15:27   ` Peter Zijlstra
2020-04-03  7:19     ` Alexandre Chartre
2020-04-06 14:34     ` Alexandre Chartre
2020-04-06 14:55       ` Alexandre Chartre
2020-04-02  8:22 ` [PATCH 5/7] x86/speculation: Annotate intra-function calls Alexandre Chartre
2020-04-03 16:05   ` Josh Poimboeuf
2020-04-03 16:16     ` Josh Poimboeuf
2020-04-03 17:14       ` Alexandre Chartre
2020-04-03 17:18         ` Peter Zijlstra
2020-04-03 17:24           ` Josh Poimboeuf
2020-04-03 18:20             ` Peter Zijlstra [this message]
2020-04-02  8:22 ` [PATCH 6/7] x86/speculation: Annotate retpoline return instructions Alexandre Chartre
2020-04-02  8:22 ` [PATCH 7/7] x86/speculation: Remove most ANNOTATE_NOSPEC_ALTERNATIVE Alexandre Chartre
2020-04-03  7:53   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200403182005.GC20730@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=alexandre.chartre@oracle.com \
    --cc=jpoimboe@redhat.com \
    --cc=jthierry@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.