All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Borislav Petkov <bp@alien8.de>, "H . Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Leo Yan <leo.yan@linaro.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH V6 14/15] perf script: Add option --show-text-poke-events
Date: Sun,  5 Apr 2020 23:13:26 +0300	[thread overview]
Message-ID: <20200405201327.7332-15-adrian.hunter@intel.com> (raw)
In-Reply-To: <20200405201327.7332-1-adrian.hunter@intel.com>

Consistent with other new events, add an option to perf script to display
text poke events and ksymbol events. Both text poke events and ksymbol
events are displayed because some text pokes (e.g. ftrace trampolines) have
corresponding ksymbol events.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
 tools/perf/Documentation/perf-script.txt |  4 ++++
 tools/perf/builtin-script.c              | 19 +++++++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/tools/perf/Documentation/perf-script.txt b/tools/perf/Documentation/perf-script.txt
index 99a9853a11ba..8fe507d69f95 100644
--- a/tools/perf/Documentation/perf-script.txt
+++ b/tools/perf/Documentation/perf-script.txt
@@ -322,6 +322,10 @@ OPTIONS
 --show-cgroup-events
 	Display cgroup events i.e. events of type PERF_RECORD_CGROUP.
 
+--show-text-poke-events
+	Display text poke events i.e. events of type PERF_RECORD_TEXT_POKE and
+	PERF_RECORD_KSYMBOL.
+
 --demangle::
 	Demangle symbol names to human readable form. It's enabled by default,
 	disable with --no-demangle.
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 348fec9743a4..e934bf46269d 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -1695,6 +1695,7 @@ struct perf_script {
 	bool			show_round_events;
 	bool			show_bpf_events;
 	bool			show_cgroup_events;
+	bool			show_text_poke_events;
 	bool			allocated;
 	bool			per_event_dump;
 	struct evswitch		evswitch;
@@ -2319,6 +2320,18 @@ process_bpf_events(struct perf_tool *tool __maybe_unused,
 			   sample->tid);
 }
 
+static int process_text_poke_events(struct perf_tool *tool,
+				    union perf_event *event,
+				    struct perf_sample *sample,
+				    struct machine *machine)
+{
+	if (perf_event__process_text_poke(tool, event, sample, machine) < 0)
+		return -1;
+
+	return print_event(tool, event, sample, machine, sample->pid,
+			   sample->tid);
+}
+
 static void sig_handler(int sig __maybe_unused)
 {
 	session_done = 1;
@@ -2427,6 +2440,10 @@ static int __cmd_script(struct perf_script *script)
 		script->tool.ksymbol = process_bpf_events;
 		script->tool.bpf     = process_bpf_events;
 	}
+	if (script->show_text_poke_events) {
+		script->tool.ksymbol   = process_bpf_events;
+		script->tool.text_poke = process_text_poke_events;
+	}
 
 	if (perf_script__setup_per_event_dump(script)) {
 		pr_err("Couldn't create the per event dump files\n");
@@ -3452,6 +3469,8 @@ int cmd_script(int argc, const char **argv)
 		    "Show round events (if recorded)"),
 	OPT_BOOLEAN('\0', "show-bpf-events", &script.show_bpf_events,
 		    "Show bpf related events (if recorded)"),
+	OPT_BOOLEAN('\0', "show-text-poke-events", &script.show_text_poke_events,
+		    "Show text poke related events (if recorded)"),
 	OPT_BOOLEAN('\0', "per-event-dump", &script.per_event_dump,
 		    "Dump trace output to files named by the monitored events"),
 	OPT_BOOLEAN('f', "force", &symbol_conf.force, "don't complain, do it"),
-- 
2.17.1


  parent reply	other threads:[~2020-04-05 20:15 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-05 20:13 [PATCH V6 00/15] perf/x86: Add perf text poke events Adrian Hunter
2020-04-05 20:13 ` [PATCH V6 01/15] perf: Add perf text poke event Adrian Hunter
2020-04-05 20:13 ` [PATCH V6 02/15] perf/x86: Add support for perf text poke event for text_poke_bp_batch() callers Adrian Hunter
2020-04-05 20:13 ` [PATCH V6 03/15] kprobes: Add symbols for kprobe insn pages Adrian Hunter
2020-04-05 20:13 ` [PATCH V6 04/15] kprobes: Add perf ksymbol events " Adrian Hunter
2020-04-05 20:13 ` [PATCH V6 05/15] perf/x86: Add perf text poke events for kprobes Adrian Hunter
2020-04-05 20:13 ` [PATCH V6 06/15] ftrace: Add symbols for ftrace trampolines Adrian Hunter
2020-04-05 20:13 ` [PATCH V6 07/15] ftrace: Add perf ksymbol events " Adrian Hunter
2020-04-05 20:13 ` [PATCH V6 08/15] ftrace: Add perf text poke " Adrian Hunter
2020-04-21 13:45   ` Peter Zijlstra
2020-04-22  7:39     ` Adrian Hunter
2020-04-22 11:46       ` Peter Zijlstra
2020-04-27  7:23         ` Adrian Hunter
2020-04-27 18:34           ` Steven Rostedt
2020-04-28 16:47             ` Peter Zijlstra
2020-04-27 20:10           ` Arnaldo Carvalho de Melo
2020-04-05 20:13 ` [PATCH V6 09/15] perf kcore_copy: Fix module map when there are no modules loaded Adrian Hunter
2020-04-05 20:13 ` [PATCH V6 10/15] perf evlist: Disable 'immediate' events last Adrian Hunter
2020-04-05 20:13 ` [PATCH V6 11/15] perf tools: Add support for PERF_RECORD_TEXT_POKE Adrian Hunter
2020-04-05 20:13 ` [PATCH V6 12/15] perf tools: Add support for PERF_RECORD_KSYMBOL_TYPE_OOL Adrian Hunter
2020-04-05 20:13 ` [PATCH V6 13/15] perf intel-pt: Add support for text poke events Adrian Hunter
2020-04-21 12:50   ` Jiri Olsa
2020-04-21 13:02     ` Adrian Hunter
2020-04-21 13:06       ` Jiri Olsa
2020-04-21 13:10         ` Adrian Hunter
2020-04-21 13:35           ` Jiri Olsa
2020-04-21 13:45             ` Adrian Hunter
2020-04-21 15:38               ` Adrian Hunter
2020-04-05 20:13 ` Adrian Hunter [this message]
2020-04-05 20:13 ` [PATCH V6 15/15] perf script: Show text poke address symbol Adrian Hunter
2020-04-20  6:21 ` [PATCH V6 00/15] perf/x86: Add perf text poke events Adrian Hunter
2020-04-21 13:46 ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200405201327.7332-15-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.