From: Uladzislau Rezki <urezki@gmail.com>
To: William Kucharski <william.kucharski@oracle.com>
Cc: Uladzislau Rezki <urezki@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>,
jroedel@suse.de, Vlastimil Babka <vbabka@suse.cz>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] mm/vmalloc: Sanitize __get_vm_area() arguments
Date: Mon, 6 Apr 2020 14:59:28 +0200 [thread overview]
Message-ID: <20200406125928.GA23653@pc636> (raw)
In-Reply-To: <65663E36-DC60-4E6E-B6C6-3A0F6852543D@oracle.com>
On Sun, Apr 05, 2020 at 02:49:13PM -0600, William Kucharski wrote:
> That's fine.
>
> One could still argue size should be sanitized earlier when start and end
> are, but it's a nit either way (though size is used before it's checked,
> it's not in any way that could fail with bad results.)
>
Agree. Therefore i do not have a strong opinion here, so it
basically depends on how to look at it :)
--
Vlad Rezki
next prev parent reply other threads:[~2020-04-06 12:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-04 15:35 [PATCH] mm/vmalloc: Sanitize __get_vm_area() arguments William Kucharski
2020-04-04 18:52 ` Uladzislau Rezki
2020-04-05 5:25 ` William Kucharski
2020-04-05 17:23 ` Uladzislau Rezki
2020-04-05 19:21 ` Uladzislau Rezki
2020-04-05 20:49 ` William Kucharski
2020-04-06 12:59 ` Uladzislau Rezki [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-03 16:32 Peter Zijlstra
2020-04-03 18:18 ` Uladzislau Rezki
2020-04-03 18:53 ` Peter Zijlstra
2020-04-04 19:00 ` Uladzislau Rezki
2020-04-06 13:01 ` Christoph Hellwig
2020-04-06 14:06 ` Peter Zijlstra
2020-04-17 12:57 ` Sakari Ailus
2020-04-17 13:14 ` Peter Zijlstra
2020-04-17 13:38 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406125928.GA23653@pc636 \
--to=urezki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.