From: Peter Zijlstra <peterz@infradead.org>
To: Jessica Yu <jeyu@kernel.org>
Cc: Miroslav Benes <mbenes@suse.cz>,
Josh Poimboeuf <jpoimboe@redhat.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
keescook@chromium.org
Subject: Re: [PATCH] module: Harden STRICT_MODULE_RWX
Date: Mon, 6 Apr 2020 16:11:30 +0200 [thread overview]
Message-ID: <20200406141130.GO20730@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200406125336.GA21006@linux-8ccs>
On Mon, Apr 06, 2020 at 02:53:37PM +0200, Jessica Yu wrote:
> > > > > > + for (i = 0; i < hdr->e_shnum; i++) {
> > > > > > + if (sechdrs[i].sh_flags & (SHF_EXECINSTR|SHF_WRITE))
> > > > > > + return -ENOEXEC;
Hehe, I'm well familiar with the brain going funny, as evidenced by the
above... :facepalm:
> Ugh sorry, my brain shorted out and for some reason I mistakenly
> thought the check excluded SHF_WRITE|SHF_EXECINSTR|SHF_ALLOC sections.
> It doesn't obviously. Sorry for the noise.
next prev parent reply other threads:[~2020-04-06 14:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 16:37 [PATCH] module: Harden STRICT_MODULE_RWX Peter Zijlstra
2020-04-03 16:56 ` Josh Poimboeuf
2020-04-03 17:08 ` Peter Zijlstra
2020-04-06 9:55 ` Miroslav Benes
2020-04-06 10:46 ` Jessica Yu
2020-04-06 11:27 ` Peter Zijlstra
2020-04-06 12:53 ` Jessica Yu
2020-04-06 14:11 ` Peter Zijlstra [this message]
2020-04-07 7:43 ` Miroslav Benes
2020-04-09 16:55 ` Miroslav Benes
2020-04-10 9:04 ` Jessica Yu
2020-04-03 16:59 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406141130.GO20730@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=jeyu@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.