From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Mon, 06 Apr 2020 14:51:09 +0000 Subject: Re: [PATCH] RDMA/cm: Fix an error check in cm_alloc_id_priv() Message-Id: <20200406145109.GQ20941@ziepe.ca> List-Id: References: <20200406144335.GD68494@mwanda> In-Reply-To: <20200406144335.GD68494@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Doug Ledford , Leon Romanovsky , Danit Goldberg , Parav Pandit , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org On Mon, Apr 06, 2020 at 05:43:35PM +0300, Dan Carpenter wrote: > The xa_alloc_cyclic_irq() function returns either 0 or 1 on success and > negatives on error. This code treats 1 as an error and returns > ERR_PTR(1) which will cause an Oops in the caller. > > Fixes: e8dc4e885c45 ("RDMA/cm: Fix ordering of xa_alloc_cyclic() in ib_create_cm_id()") > Signed-off-by: Dan Carpenter > --- > The Fixes tag may not be correct. That's the patch which introduces an > Oops but we may want to backport this further back. Right it should be Fixes: ae78ff3a0f0c ("RDMA/cm: Convert local_id_table to XArray") Thanks, Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C3FC2BA19 for ; Mon, 6 Apr 2020 14:51:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8EFEA23C43 for ; Mon, 6 Apr 2020 14:51:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="fp1TsRVJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728704AbgDFOvL (ORCPT ); Mon, 6 Apr 2020 10:51:11 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:42955 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728734AbgDFOvL (ORCPT ); Mon, 6 Apr 2020 10:51:11 -0400 Received: by mail-qk1-f196.google.com with SMTP id 123so3607118qkm.9 for ; Mon, 06 Apr 2020 07:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QLcJLS6gh3Pyw1Kb8Qcjn7YnCly0p8aglXTQ552vZuY=; b=fp1TsRVJUgrD0C5YqaopF+9Lazs5FzJC/aUPVwr2KhStCASxgpleYVJGoYD3aluwj5 KfOVAnuDgo8BK7Dd06ievhU1TIr4+L77KQ3IbF66ACNcGxRhTvwu26A+Nj9MBh4RGpr/ 6P6oT4zivnfu6E97Yb1mm836i1ipVG+65bxxVXeZ0SQ2lMFrK1qD1hp+2bbUvXQ9p2Y8 OC/xWSMDpM1pOWP1AwqTSME0bAEtvz8XpwBatlv9Gs6AXGamACzXh6sX9JleQrNz32Ak Gk+t0DQ7qPAHiqr4WBQa4Ta7k5Ke7focVwgutedc9SMAebxJFVrsN8QU/gwMSemZnv2X H21g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QLcJLS6gh3Pyw1Kb8Qcjn7YnCly0p8aglXTQ552vZuY=; b=G5eUHdIdA+zcLv8WELDAcZDy8+q/EQr4rCb+aS+Gamm3G+d4+5QloQAchWxfXDmGeK Gr6tdlsCAtHxORTbV/tPskRqc6goB3WJQqa4jp+iV3sZiZb+ay6k5/unMUUwfl0kWQob 6tIsCg2HmAXOD27ueFgETeeS67SQ/cEsOgjzaJkLZ5JL3zDZl0KKzJuHcURGP9a2sgxQ uHvdl9XoL+ztM5oXTYvU9AH7heJKyFfIRkdvVQtzF5bXluXcELaj7VzdciKZzqncOCle 57/FN525vqcC6zt7CH26ziI6gHYYnpilL7BhZ1HJGexi2gU3Hekpou/TcIhU+LbslRJk 4G2w== X-Gm-Message-State: AGi0PuZ1rT3lGpwgIMwM1tHXe1qgcOhEpBoirtCRVjPmD2BayoT3HxKs lA3Zl8itqeE6WqVRZsAyvecpjA== X-Google-Smtp-Source: APiQypIjI6lG1ooeDObkWABulcNgWH7LhaRsQCl2qp2qdvNjPo6uYknax/IMVDXJg1lKOfXm5V6K3w== X-Received: by 2002:a37:7605:: with SMTP id r5mr19728783qkc.345.1586184670672; Mon, 06 Apr 2020 07:51:10 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id f127sm14675009qkd.74.2020.04.06.07.51.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Apr 2020 07:51:10 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jLT5h-0005YO-Da; Mon, 06 Apr 2020 11:51:09 -0300 Date: Mon, 6 Apr 2020 11:51:09 -0300 From: Jason Gunthorpe To: Dan Carpenter Cc: Doug Ledford , Leon Romanovsky , Danit Goldberg , Parav Pandit , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] RDMA/cm: Fix an error check in cm_alloc_id_priv() Message-ID: <20200406145109.GQ20941@ziepe.ca> References: <20200406144335.GD68494@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200406144335.GD68494@mwanda> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Apr 06, 2020 at 05:43:35PM +0300, Dan Carpenter wrote: > The xa_alloc_cyclic_irq() function returns either 0 or 1 on success and > negatives on error. This code treats 1 as an error and returns > ERR_PTR(1) which will cause an Oops in the caller. > > Fixes: e8dc4e885c45 ("RDMA/cm: Fix ordering of xa_alloc_cyclic() in ib_create_cm_id()") > Signed-off-by: Dan Carpenter > --- > The Fixes tag may not be correct. That's the patch which introduces an > Oops but we may want to backport this further back. Right it should be Fixes: ae78ff3a0f0c ("RDMA/cm: Convert local_id_table to XArray") Thanks, Jason