From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] KVM: VMX: Remove unnecessary exception trampoline in vmx_vmenter
Date: Mon, 6 Apr 2020 09:28:48 -0700 [thread overview]
Message-ID: <20200406162848.GF21330@linux.intel.com> (raw)
In-Reply-To: <20200406151641.67698-1-ubizjak@gmail.com>
On Mon, Apr 06, 2020 at 05:16:41PM +0200, Uros Bizjak wrote:
> The exception trampoline in .fixup section is not needed, the exception handling code can jump directly to the label in .text section.
Changelog need to be wrapped at 75 chars, and "label in .text section"
should be "label in the .text section".
Nits aside,
Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
> Cc: Sean Christopherson <sean.j.christopherson@intel.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> ---
> arch/x86/kvm/vmx/vmenter.S | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx/vmenter.S b/arch/x86/kvm/vmx/vmenter.S
> index 81ada2ce99e7..56d701db8734 100644
> --- a/arch/x86/kvm/vmx/vmenter.S
> +++ b/arch/x86/kvm/vmx/vmenter.S
> @@ -58,12 +58,8 @@ SYM_FUNC_START(vmx_vmenter)
> ret
> 4: ud2
>
> - .pushsection .fixup, "ax"
> -5: jmp 3b
> - .popsection
> -
> - _ASM_EXTABLE(1b, 5b)
> - _ASM_EXTABLE(2b, 5b)
> + _ASM_EXTABLE(1b, 3b)
> + _ASM_EXTABLE(2b, 3b)
>
> SYM_FUNC_END(vmx_vmenter)
>
> --
> 2.25.1
>
prev parent reply other threads:[~2020-04-06 16:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 15:16 [PATCH] KVM: VMX: Remove unnecessary exception trampoline in vmx_vmenter Uros Bizjak
2020-04-06 16:28 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406162848.GF21330@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.