All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Longerbeam <slongerbeam@gmail.com>
To: linux-media@vger.kernel.org
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Rui Miguel Silva <rmfrfs@gmail.com>,
	Steve Longerbeam <slongerbeam@gmail.com>
Subject: [PATCH v7 05/11] media: imx: Fix some pixel format selections
Date: Mon,  6 Apr 2020 09:38:59 -0700	[thread overview]
Message-ID: <20200406163905.24475-6-slongerbeam@gmail.com> (raw)
In-Reply-To: <20200406163905.24475-1-slongerbeam@gmail.com>

- imx_media_capture_device_register() needs to use CS_SEL_ANY when
  finding the format from the attached source subdevice, because the
  source can be a CSI which supports bayer, and the CSI may have selected
  a bayer format when it registered.

- Likewise, imx_media_init_mbus_fmt() is called from the CSI, so the
  function may be passed a bayer code. Use CS_SEL_ANY when locating
  the format.

Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>
---
 drivers/staging/media/imx/imx-media-capture.c | 2 +-
 drivers/staging/media/imx/imx-media-utils.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/imx/imx-media-capture.c b/drivers/staging/media/imx/imx-media-capture.c
index fe1c49a33fd9..970f54960cac 100644
--- a/drivers/staging/media/imx/imx-media-capture.c
+++ b/drivers/staging/media/imx/imx-media-capture.c
@@ -792,7 +792,7 @@ int imx_media_capture_device_register(struct imx_media_video_dev *vdev)
 	vdev->compose.width = fmt_src.format.width;
 	vdev->compose.height = fmt_src.format.height;
 	vdev->cc = imx_media_find_format(vdev->fmt.fmt.pix.pixelformat,
-					 CS_SEL_YUV_RGB);
+					 CS_SEL_ANY);
 
 	v4l2_info(sd, "Registered %s as /dev/%s\n", vfd->name,
 		  video_device_node_name(vfd));
diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c
index 5552039a9d7e..852badd55bd1 100644
--- a/drivers/staging/media/imx/imx-media-utils.c
+++ b/drivers/staging/media/imx/imx-media-utils.c
@@ -402,7 +402,7 @@ int imx_media_init_mbus_fmt(struct v4l2_mbus_framefmt *mbus,
 	mbus->field = field;
 	if (code == 0)
 		imx_media_enum_mbus_format(&code, 0, CS_SEL_YUV);
-	lcc = imx_media_find_mbus_format(code, CS_SEL_YUV_RGB);
+	lcc = imx_media_find_mbus_format(code, CS_SEL_ANY);
 	if (!lcc) {
 		lcc = imx_media_find_ipu_format(code, CS_SEL_YUV_RGB);
 		if (!lcc)
-- 
2.17.1


  parent reply	other threads:[~2020-04-06 16:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 16:38 [PATCH v7 00/11] media: imx: Miscellaneous format-related cleanups Steve Longerbeam
2020-04-06 16:38 ` [PATCH v7 01/11] media: imx: utils: fix and simplify pixel format enumeration Steve Longerbeam
2020-04-09 15:38   ` Fabio Estevam
2020-04-14 21:00     ` Steve Longerbeam
2020-04-14 21:20   ` [PATCH v7.1 " Steve Longerbeam
2020-04-06 16:38 ` [PATCH v7 02/11] media: imx: utils: fix media bus " Steve Longerbeam
2020-04-14 21:23   ` [PATCH v7.1 " Steve Longerbeam
2020-04-06 16:38 ` [PATCH v7 03/11] media: imx: utils: Inline init_mbus_colorimetry() in its caller Steve Longerbeam
2020-04-06 16:38 ` [PATCH v7 04/11] media: imx: utils: Handle Bayer format lookup through a selection flag Steve Longerbeam
2020-04-21 11:12   ` Mauro Carvalho Chehab
2020-04-06 16:38 ` Steve Longerbeam [this message]
2020-04-06 17:13   ` [PATCH v7 05/11] media: imx: Fix some pixel format selections Laurent Pinchart
2020-04-06 16:39 ` [PATCH v7 06/11] media: imx: utils: Rename pixel format selection enumeration Steve Longerbeam
2020-04-06 16:39 ` [PATCH v7 07/11] media: imx: utils: Introduce PIXFMT_SEL_IPU Steve Longerbeam
2020-04-06 16:39 ` [PATCH v7 08/11] media: imx: utils: Make imx_media_pixfmt handle variable number of codes Steve Longerbeam
2020-04-06 16:39 ` [PATCH v7 09/11] media: imx: utils: Split find|enum_format into fourcc and mbus functions Steve Longerbeam
2020-04-06 16:39 ` [PATCH v7 10/11] media: imx: utils: Rename format lookup and enumeration functions Steve Longerbeam
2020-04-06 16:39 ` [PATCH v7 11/11] media: imx: utils: Constify some mbus and ipu_image arguments Steve Longerbeam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200406163905.24475-6-slongerbeam@gmail.com \
    --to=slongerbeam@gmail.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rmfrfs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.