From: Kalle Valo <kvalo@codeaurora.org>
To: Yu Wang <yyuwang@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ath10k: add ppdu stats support for QCA6174/QCA9377
Date: Tue, 7 Apr 2020 05:27:18 +0000 (UTC) [thread overview]
Message-ID: <20200407052718.958BFC433BA@smtp.codeaurora.org> (raw)
In-Reply-To: <0101016e82883b59-e52fb973-84a7-4c15-a236-c7a01390087b-000000@us-west-2.amazonses.com>
Yu Wang <yyuwang@codeaurora.org> wrote:
> When QCA6174/QCA9377 working in station mode, after connected
> to AP, tx bitrate is always '1.0 MBit/s' in output of command
> 'iw wlan0 link'.
>
> That's because the parameters to calculate the tx bitrate are
> not well updated for QCA6174/QCA9377.
>
> To fix this issue:
> 1. Add processing for HTT_T2H_MSG_TYPE_PPDU_STATS_IND which includes
> the peer tx stats;
> 2. Map WMI_TLV_SERVICE_PEER_STATS_INFO to WMI_SERVICE_PEER_STATS to
> enable the feature.
>
> Tested with QCA6174 PCIe with firmware WLAN.RM.4.4.1.c3-00031.
> Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029.
>
> Signed-off-by: Yu Wang <yyuwang@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This has new warnings:
drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_process_ppdu_stats':
drivers/net/wireless/ath/ath10k/htt_rx.c:3746:21: warning: variable 'arsta' set but not used [-Wunused-but-set-variable]
drivers/net/wireless/ath/ath10k/htt_rx.c:3751:18: warning: incorrect type in assignment (different base types)
drivers/net/wireless/ath/ath10k/htt_rx.c:3751:18: expected unsigned char [usertype] num_ppdu
drivers/net/wireless/ath/ath10k/htt_rx.c:3751:18: got restricted __le32 [usertype] num_ppdu
--
https://patchwork.kernel.org/patch/11250999/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-04-07 5:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1574147982-3956-1-git-send-email-yyuwang@codeaurora.org>
2019-11-19 7:19 ` [PATCH v2 2/2] ath10k: correct legacy rate in tx stats Yu Wang
2020-03-24 14:35 ` Kalle Valo
2020-03-24 14:35 ` Kalle Valo
2020-03-24 14:40 ` Kalle Valo
2020-03-24 14:40 ` Kalle Valo
2020-04-09 14:13 ` Kalle Valo
2020-04-09 14:13 ` Kalle Valo
2019-11-19 7:19 ` [PATCH v2 1/2] ath10k: add ppdu stats support for QCA6174/QCA9377 Yu Wang
2020-04-07 5:27 ` Kalle Valo [this message]
2020-04-07 5:27 ` Kalle Valo
2019-11-19 7:19 ` Yu Wang
2019-11-19 7:19 ` [PATCH v2 2/2] ath10k: correct legacy rate in tx stats Yu Wang
2020-04-09 14:21 ` Kalle Valo
2020-04-14 5:32 ` Yu Wang
2020-04-14 5:32 ` Yu Wang
2020-04-14 8:53 ` Tom Psyborg
2020-04-14 8:53 ` Tom Psyborg
2020-04-09 14:21 ` Kalle Valo
2019-11-19 0:20 [PATCH v2 0/2] ath10k: correct tx bitrate for QCA6174/QCA9377/QCA9888 root
2019-11-19 0:20 ` [PATCH v2 1/2] ath10k: add ppdu stats support for QCA6174/QCA9377 root
2019-11-19 0:20 ` root
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407052718.958BFC433BA@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yyuwang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.