Re: [Outreachy kernel] [Outreachy] [PATCH v4 2/3] staging: rtl8188eu: Remove unnecessary extra parentheses

[Stefano Brivio <sbrivio@redhat.com>]

On Mon,  6 Apr 2020 16:47:05 +0530
Soumyajit Deb <debsoumyajit100@gmail.com> wrote:

> Remove unnecessary extra parentheses to improve code readability.
> 
> Signed-off-by: Soumyajit Deb <debsoumyajit100@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_ap.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
> index eb48095b9de2..2dd775fbcc4b 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_ap.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
> @@ -315,7 +315,7 @@ void expire_timeout_chk(struct adapter *padapter)
>  
>  			psta->keep_alive_trycnt = 0;
>  
> -			DBG_88E("asoc expire %pM, state = 0x%x\n", (psta->hwaddr), psta->state);
> +			DBG_88E("asoc expire %pM, state = 0x%x\n", psta->hwaddr, psta->state);

49 lines above this you have another:

                        list_del_init(&psta->asoc_list);
                        pstapriv->asoc_list_cnt--;
 
                        DBG_88E("asoc expire %pM, state = 0x%x\n", (psta->hwaddr), psta->state);

which you're then touching in 3/3, but keeping it as (psta->hwaddr). I
think this should at least be consistent.

-- 
Stefano