From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: linux-leds@vger.kernel.org
Subject: Re: Cleanups in "next" tree
Date: Tue, 7 Apr 2020 09:28:54 +0200 [thread overview]
Message-ID: <20200407072854.GA18673@amd.ucw.cz> (raw)
In-Reply-To: <a4802e70-106b-3476-536f-1d8798ce156f@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1709 bytes --]
Hi!
> > I'm sorry I failed to meet your high expectations... But I don't
> > believe I done anything completely outside of usual kernel procedures.
>
> I believe code review is quite usual kernel procedure.
I don't disagree with that.
> > Could you list the patches and objections you have?
>
> I already expressed my concerns regarding Turris Omnia patch.
Ok.
> My comments regarding remaining patches:
>
> - "Make label "white:power" to be consistent with"
>
> I disagree here. "system" was OK.
It was too vague... I know the hardware and it is a LED above power
button used as a power indicator.
> - "Warn about old defines that probably should not be used."
>
> Obsolete is only LED_FULL, so the comment is in wrong line
No, all of them are bad. Maybe LED_OFF could be used going forward,
but... it is simply easier to write 0. The type is not really an en
enumeration, it is brightness, with variable maximum value.
> - "Group LED functions according to functionality, and add some"
>
> You're adding here some random comments referencing obsolete
> naming. I think that it is enough to say what is current standard.
Ok, I'll drop that part. But I really want to get that documented
_somewhere_, because obsolete naming is currently in use, and we won't
be able to change it :-(.
> Also, I had a patch [0] describing standard LED functions in my LED
> naming patch set, but it was not merged. It could be worth getting
> back to it at this occasion.
I'll take a look.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2020-04-07 7:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 11:59 Cleanups in "next" tree Pavel Machek
2020-03-22 13:35 ` Jacek Anaszewski
2020-03-22 15:05 ` Dan Murphy
2020-04-02 22:57 ` Pavel Machek
2020-04-03 12:49 ` Dan Murphy
2020-04-03 18:45 ` Jacek Anaszewski
2020-04-03 19:07 ` Dan Murphy
2020-04-07 7:28 ` Pavel Machek [this message]
2020-04-07 20:23 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407072854.GA18673@amd.ucw.cz \
--to=pavel@ucw.cz \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.