From: Oleg Nesterov <oleg@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org, peterz@infradead.org
Subject: Re: [PATCH 2/4] task_work: don't run task_work if task_work_exited is queued
Date: Tue, 7 Apr 2020 19:43:09 +0200 [thread overview]
Message-ID: <20200407174309.GA11784@redhat.com> (raw)
In-Reply-To: <8ce5fd3f-2f6b-e0da-9db0-26c09c5320a6@kernel.dk>
Jens,
I'll read your email tomorrow, just one note for now ...
On 04/07, Jens Axboe wrote:
>
> On 4/7/20 9:19 AM, Oleg Nesterov wrote:
> >
> > but this task has not passed exit_task_work(),
>
> But it's definitely hitting callback->func == NULL, which is the
> exit_work. So if it's not from past exit_task_work(), where is it from?
I guess it comes from task_work_run() added by the next patch ;)
> I see your newer email on this, I'll go read it.
please look at the "bad_work_func" example.
Oleg.
next prev parent reply other threads:[~2020-04-07 17:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 19:48 [PATCHSET 0/4] io_uring and task_work interactions Jens Axboe
2020-04-06 19:48 ` [PATCH 1/4] task_work: add task_work_pending() helper Jens Axboe
2020-04-07 11:28 ` Oleg Nesterov
2020-04-07 15:43 ` Jens Axboe
2020-04-06 19:48 ` [PATCH 2/4] task_work: don't run task_work if task_work_exited is queued Jens Axboe
2020-04-07 11:39 ` Oleg Nesterov
2020-04-07 11:54 ` Oleg Nesterov
2020-04-07 15:40 ` Jens Axboe
2020-04-07 16:19 ` Oleg Nesterov
2020-04-07 16:59 ` Jens Axboe
2020-04-07 17:43 ` Oleg Nesterov [this message]
2020-04-07 12:47 ` Peter Zijlstra
2020-04-07 15:43 ` Jens Axboe
2020-04-06 19:48 ` [PATCH 3/4] task_work: kill current->task_works checking in callers Jens Axboe
2020-04-06 19:48 ` [PATCH 4/4] io_uring: flush task work before waiting for ring exit Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407174309.GA11784@redhat.com \
--to=oleg@redhat.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.