From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6388C2D0EC for ; Tue, 7 Apr 2020 18:46:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B63F20730 for ; Tue, 7 Apr 2020 18:46:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B63F20730 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE55C6E8DD; Tue, 7 Apr 2020 18:46:07 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id D0B3B6E8D8; Tue, 7 Apr 2020 18:46:06 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id BCB7E80538; Tue, 7 Apr 2020 20:46:04 +0200 (CEST) Date: Tue, 7 Apr 2020 20:46:03 +0200 From: Sam Ravnborg To: Ville Syrjala Subject: Re: [PATCH v2 09/17] drm: Flatten drm_mode_vrefresh() Message-ID: <20200407184603.GI6356@ravnborg.org> References: <20200403204008.14864-1-ville.syrjala@linux.intel.com> <20200403204008.14864-10-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200403204008.14864-10-ville.syrjala@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=XpTUx2N9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=8nJEP1OIZ-IA:10 a=QyXUC8HyAAAA:8 a=QX4gbG5DAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=HPv8fEl2qouvAlxC6HYA:9 a=MG5i2C4Bp9e4CIY8:21 a=NJ9UzGjZE1qqg5t5:21 a=wPNLvfGTeEIA:10 a=AbAUZ8qAyYyZVLSsDulk:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Emil Velikov Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Apr 03, 2020 at 11:40:00PM +0300, Ville Syrjala wrote: > From: Ville Syrj=E4l=E4 > = > Remove the pointless whole-function indentation. Also don't > need to worry about negative values anymore since we switched > everything to u16. > = > Reviewed-by: Emil Velikov > Signed-off-by: Ville Syrj=E4l=E4 First change could have been in the patch that made this check pointless. But this works too. Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/drm_modes.c | 26 ++++++++++++-------------- > 1 file changed, 12 insertions(+), 14 deletions(-) > = > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > index 77d68120931a..f2865f88bd54 100644 > --- a/drivers/gpu/drm/drm_modes.c > +++ b/drivers/gpu/drm/drm_modes.c > @@ -757,24 +757,22 @@ EXPORT_SYMBOL(drm_mode_set_name); > */ > int drm_mode_vrefresh(const struct drm_display_mode *mode) > { > - int refresh =3D 0; > + unsigned int num, den; > = > - if (mode->htotal > 0 && mode->vtotal > 0) { > - unsigned int num, den; > + if (mode->htotal =3D=3D 0 || mode->vtotal =3D=3D 0) > + return 0; > = > - num =3D mode->clock * 1000; > - den =3D mode->htotal * mode->vtotal; > + num =3D mode->clock * 1000; > + den =3D mode->htotal * mode->vtotal; > = > - if (mode->flags & DRM_MODE_FLAG_INTERLACE) > - num *=3D 2; > - if (mode->flags & DRM_MODE_FLAG_DBLSCAN) > - den *=3D 2; > - if (mode->vscan > 1) > - den *=3D mode->vscan; > + if (mode->flags & DRM_MODE_FLAG_INTERLACE) > + num *=3D 2; > + if (mode->flags & DRM_MODE_FLAG_DBLSCAN) > + den *=3D 2; > + if (mode->vscan > 1) > + den *=3D mode->vscan; > = > - refresh =3D DIV_ROUND_CLOSEST(num, den); > - } > - return refresh; > + return DIV_ROUND_CLOSEST(num, den); > } > EXPORT_SYMBOL(drm_mode_vrefresh); > = > -- = > 2.24.1 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 269CEC2D0EC for ; Tue, 7 Apr 2020 18:46:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E05F820730 for ; Tue, 7 Apr 2020 18:46:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E05F820730 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 702466E8D8; Tue, 7 Apr 2020 18:46:07 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id D0B3B6E8D8; Tue, 7 Apr 2020 18:46:06 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id BCB7E80538; Tue, 7 Apr 2020 20:46:04 +0200 (CEST) Date: Tue, 7 Apr 2020 20:46:03 +0200 From: Sam Ravnborg To: Ville Syrjala Message-ID: <20200407184603.GI6356@ravnborg.org> References: <20200403204008.14864-1-ville.syrjala@linux.intel.com> <20200403204008.14864-10-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200403204008.14864-10-ville.syrjala@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=XpTUx2N9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=8nJEP1OIZ-IA:10 a=QyXUC8HyAAAA:8 a=QX4gbG5DAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=HPv8fEl2qouvAlxC6HYA:9 a=MG5i2C4Bp9e4CIY8:21 a=NJ9UzGjZE1qqg5t5:21 a=wPNLvfGTeEIA:10 a=AbAUZ8qAyYyZVLSsDulk:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 Subject: Re: [Intel-gfx] [PATCH v2 09/17] drm: Flatten drm_mode_vrefresh() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Emil Velikov Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Apr 03, 2020 at 11:40:00PM +0300, Ville Syrjala wrote: > From: Ville Syrj=E4l=E4 > = > Remove the pointless whole-function indentation. Also don't > need to worry about negative values anymore since we switched > everything to u16. > = > Reviewed-by: Emil Velikov > Signed-off-by: Ville Syrj=E4l=E4 First change could have been in the patch that made this check pointless. But this works too. Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/drm_modes.c | 26 ++++++++++++-------------- > 1 file changed, 12 insertions(+), 14 deletions(-) > = > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > index 77d68120931a..f2865f88bd54 100644 > --- a/drivers/gpu/drm/drm_modes.c > +++ b/drivers/gpu/drm/drm_modes.c > @@ -757,24 +757,22 @@ EXPORT_SYMBOL(drm_mode_set_name); > */ > int drm_mode_vrefresh(const struct drm_display_mode *mode) > { > - int refresh =3D 0; > + unsigned int num, den; > = > - if (mode->htotal > 0 && mode->vtotal > 0) { > - unsigned int num, den; > + if (mode->htotal =3D=3D 0 || mode->vtotal =3D=3D 0) > + return 0; > = > - num =3D mode->clock * 1000; > - den =3D mode->htotal * mode->vtotal; > + num =3D mode->clock * 1000; > + den =3D mode->htotal * mode->vtotal; > = > - if (mode->flags & DRM_MODE_FLAG_INTERLACE) > - num *=3D 2; > - if (mode->flags & DRM_MODE_FLAG_DBLSCAN) > - den *=3D 2; > - if (mode->vscan > 1) > - den *=3D mode->vscan; > + if (mode->flags & DRM_MODE_FLAG_INTERLACE) > + num *=3D 2; > + if (mode->flags & DRM_MODE_FLAG_DBLSCAN) > + den *=3D 2; > + if (mode->vscan > 1) > + den *=3D mode->vscan; > = > - refresh =3D DIV_ROUND_CLOSEST(num, den); > - } > - return refresh; > + return DIV_ROUND_CLOSEST(num, den); > } > EXPORT_SYMBOL(drm_mode_vrefresh); > = > -- = > 2.24.1 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx