Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

[Roman Kagan <rvkagan@yandex-team.ru>]

On Mon, Apr 06, 2020 at 11:20:39AM +0300, Jon Doron wrote:
> Well I want it to be merged in :-)

Hmm I'm curious why, it has little to offer over virtio.

Anyway the series you've posted seems to be based on a fairly old
version.

The one in openvz repo is more recent.  It's still in need for
improvement, too, but should be testable at least.

Thanks,
Roman.

> On Mon, Apr 6, 2020, 10:32 Roman Kagan <rvkagan@yandex-team.ru> wrote:
> 
> > On Fri, Apr 03, 2020 at 11:00:27PM +0200, Maciej S. Szmigiero wrote:
> > > It seems to me that Roman might not be getting our e-mails since his
> > > new e-mail address seems to be "rvkagan@yandex-team.ru".
> >
> > Indeed.  I'm subscribed with my new address to qemu-devel ML but must
> > have missed this series.
> >
> > > @Roman, are you with us?
> >
> > Yes ;)
> >
> > So what are your plans regarding this patchset?
> >
> > Thanks,
> > Roman.
> >
> > > On 03.04.2020 19:18, Maciej S. Szmigiero wrote:
> > > > Hi Jon,
> > > >
> > > > The patches are available here:
> > > > https://github.com/maciejsszmigiero/qemu.git in "vmbus-patches"
> > branch.
> > > >
> > > > Please note that these patches don't have Roman's "Signed-off-by:"
> > tags,
> > > > so I haven't applied mine, either.
> > > >
> > > > If you are able to establish a proper SoB chain then please also add:
> > > > "Signed-off-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>".
> > > >
> > > > Thanks for the effort,
> > > > Maciej
> > > >
> > > > On 03.04.2020 17:30, Jon Doron wrote:
> > > >>  Thank you Maciej it seems like your version is really ahead I'll do
> > > >> the required work and merge it so i can submit a v2 with the latest
> > > >> patchset from Roman
> > > >>
> > > >> On Fri, Apr 3, 2020 at 6:06 PM Jon Doron <arilou@gmail.com> wrote:
> > > >>>
> > > >>> Thank you Maciej, I based it on top of what Denis (den@openvz.org)
> > gave me
> > > >>> which was this:
> > > >>>
> > https://ftp.openvz.org/virtuozzo/releases/openvz-7.0.12-288/source/SRPMS/q/qemu-kvm-vz-2.12.0-33.vz7.14.4.src.rpm
> > > >>>
> > > >>> Do you think you have a more recent version I dont mind diffing and
> > > >>> resubmitting a new version of the patchset?
> > > >>>
> > > >>> Thanks,
> > > >>> -- Jon.
> > > >>>
> > > >>> On Fri, Apr 3, 2020 at 5:56 PM Maciej S. Szmigiero
> > > >>> <mail@maciej.szmigiero.name> wrote:
> > > >>>>
> > > >>>> Hi Jon,
> > > >>>>
> > > >>>> On 03.04.2020 16:23, Jon Doron wrote:
> > > >>>>> Guest OS uses ACPI to discover vmbus presence.  Add a corresponding
> > > >>>>> entry to DSDT in case vmbus has been enabled.
> > > >>>>>
> > > >>>>> Experimentally Windows guests were found to require this entry to
> > > >>>>> include two IRQ resources, so this patch adds two semi-arbitrarily
> > > >>>>> chosen ones (7 and 13).  This results, in particular, in parallel
> > port
> > > >>>>> conflicting with vmbus.
> > > >>>>>
> > > >>>>> TODO: discover and use spare IRQs to avoid conflicts.
> > > >>>>>
> > > >>>>> Signed-off-by: Evgeny Yakovlev <eyakovlev@virtuozzo.com>
> > > >>>>> Signed-off-by: Roman Kagan <rkagan@virtuozzo.com>
> > > >>>>> Signed-off-by: Jon Doron <arilou@gmail.com>
> > > >>>>
> > > >>>> Nice work, thanks!
> > > >>>>
> > > >>>> However, it seems to be based on the code version that was posted in
> > > >>>> February 2018, and not the latest version in OpenVZ qemu repository
> > > >>>> dated October 2019:
> > > >>>>
> > https://src.openvz.org/projects/UP/repos/qemu/commits?until=refs%2Fheads%2Fvmbus
> > > >>>>
> > > >>>> This newer version has slightly different API here and there.
> > > >>>> Any particular reason for selecting that older version for porting?
> > > >>>>
> > > >>>> I have actually rebased this latest version on the top of the
> > current
> > > >>>> QEMU master, and it basically seems to work fine.
> > > >>>> However, I haven't done extensive tests whether there isn't a
> > memory leak
> > > >>>> somewhere or so on.
> > > >>>>
> > > >>>> Maciej
> > > >
> > >
> >