All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Podtelezhnikov <apodtele@gmail.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH xf86-video-intel] sna: Fix double-free crashes.
Date: Tue,  7 Apr 2020 23:09:21 -0400	[thread overview]
Message-ID: <20200408030921.6436-1-apodtele@gmail.com> (raw)

Fix double-free crashes.
See https://bugzilla.redhat.com/show_bug.cgi?id=1808767

Signed-off-by:  Alexei Podtelezhnikov <apodtele@gmail.com>
---
 src/sna/kgem.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/sna/kgem.c b/src/sna/kgem.c
index 6a35067c..76bb1599 100644
--- a/src/sna/kgem.c
+++ b/src/sna/kgem.c
@@ -3079,6 +3079,9 @@ static void kgem_buffer_release(struct kgem *kgem, struct kgem_buffer *bo)
 		assert(cached != &bo->base);
 		list_del(&cached->vma);
 
+		if (!cached->map__gtt)
+			continue;
+
 		assert(*(struct kgem_bo **)cached->map__gtt == cached);
 		*(struct kgem_bo **)cached->map__gtt = NULL;
 		cached->map__gtt = NULL;
-- 
2.26.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2020-04-08  3:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08  3:09 Alexei Podtelezhnikov [this message]
2020-04-08  3:23 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for sna: Fix double-free crashes Patchwork
2020-04-08  7:09 ` [Intel-gfx] [PATCH xf86-video-intel] " Chris Wilson
2020-04-08  7:27   ` Alexei Podtelezhnikov
  -- strict thread matches above, loose matches on Subject: below --
2020-04-08  2:41 Alexei Podtelezhnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200408030921.6436-1-apodtele@gmail.com \
    --to=apodtele@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.